Skip to content

autodiscovery: Add process listener based on Service Discovery #37896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

autodiscovery: Add process listener based on Service Discovery #37896

wants to merge 9 commits into from

Conversation

vitkyrka
Copy link
Contributor

What does this PR do?

Add process listener to autodiscovery based on Service Discovery.

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@vitkyrka vitkyrka added changelog/no-changelog qa/done QA done before merge and regressions are covered by tests team/agent-discovery labels Jun 12, 2025
@cit-pr-commenter cit-pr-commenter
Copy link

Go Package Import Differences

Baseline: 9b1c4ad
Comparison: ed0e8fd

binaryosarchchange
agentlinuxamd64
+2, -0 
+github.com/DataDog/datadog-agent/pkg/collector/corechecks/servicediscovery/core
+github.com/DataDog/datadog-agent/pkg/collector/corechecks/servicediscovery/servicetype
agentlinuxarm64
+2, -0 
+github.com/DataDog/datadog-agent/pkg/collector/corechecks/servicediscovery/core
+github.com/DataDog/datadog-agent/pkg/collector/corechecks/servicediscovery/servicetype
iot-agentlinuxamd64
+2, -0 
+github.com/DataDog/datadog-agent/pkg/collector/corechecks/servicediscovery/core
+github.com/DataDog/datadog-agent/pkg/collector/corechecks/servicediscovery/servicetype
iot-agentlinuxarm64
+2, -0 
+github.com/DataDog/datadog-agent/pkg/collector/corechecks/servicediscovery/core
+github.com/DataDog/datadog-agent/pkg/collector/corechecks/servicediscovery/servicetype
heroku-agentlinuxamd64
+2, -0 
+github.com/DataDog/datadog-agent/pkg/collector/corechecks/servicediscovery/core
+github.com/DataDog/datadog-agent/pkg/collector/corechecks/servicediscovery/servicetype
cluster-agent-cloudfoundrylinuxamd64
+1, -0 
+github.com/DataDog/datadog-agent/pkg/discovery/tracermetadata
cluster-agent-cloudfoundrylinuxarm64
+1, -0 
+github.com/DataDog/datadog-agent/pkg/discovery/tracermetadata
dogstatsdlinuxamd64
+1, -0 
+github.com/DataDog/datadog-agent/pkg/discovery/tracermetadata
dogstatsdlinuxarm64
+1, -0 
+github.com/DataDog/datadog-agent/pkg/discovery/tracermetadata
process-agentlinuxamd64
+1, -0 
+github.com/DataDog/datadog-agent/pkg/discovery/tracermetadata
process-agentlinuxarm64
+1, -0 
+github.com/DataDog/datadog-agent/pkg/discovery/tracermetadata
process-agentwindowsamd64
+1, -0 
+github.com/DataDog/datadog-agent/pkg/discovery/tracermetadata
process-agentdarwinamd64
+1, -0 
+github.com/DataDog/datadog-agent/pkg/discovery/tracermetadata
process-agentdarwinarm64
+1, -0 
+github.com/DataDog/datadog-agent/pkg/discovery/tracermetadata
heroku-process-agentlinuxamd64
+1, -0 
+github.com/DataDog/datadog-agent/pkg/discovery/tracermetadata
security-agentlinuxamd64
+1, -0 
+github.com/DataDog/datadog-agent/pkg/discovery/tracermetadata
security-agentlinuxarm64
+1, -0 
+github.com/DataDog/datadog-agent/pkg/discovery/tracermetadata
security-agentwindowsamd64
+1, -0 
+github.com/DataDog/datadog-agent/pkg/discovery/tracermetadata
sbomgenlinuxamd64
+7, -0 
+github.com/DataDog/datadog-agent/pkg/discovery/tracermetadata
+github.com/DataDog/datadog-agent/pkg/util/funcs
+github.com/DataDog/datadog-agent/pkg/util/kernel
+github.com/DataDog/datadog-agent/pkg/util/safeelf
+github.com/DataDog/gopsutil/host
+github.com/philhofer/fwd
+github.com/tinylib/msgp/msgp
sbomgenlinuxarm64
+7, -0 
+github.com/DataDog/datadog-agent/pkg/discovery/tracermetadata
+github.com/DataDog/datadog-agent/pkg/util/funcs
+github.com/DataDog/datadog-agent/pkg/util/kernel
+github.com/DataDog/datadog-agent/pkg/util/safeelf
+github.com/DataDog/gopsutil/host
+github.com/philhofer/fwd
+github.com/tinylib/msgp/msgp
serverlesslinuxamd64
+1, -0 
+github.com/DataDog/datadog-agent/pkg/discovery/tracermetadata
serverlesslinuxarm64
+1, -0 
+github.com/DataDog/datadog-agent/pkg/discovery/tracermetadata
system-probewindowsamd64
+1, -0 
+github.com/DataDog/datadog-agent/pkg/discovery/tracermetadata
otel-agentlinuxamd64
+7, -0 
+debug/dwarf
+debug/elf
+github.com/DataDog/datadog-agent/pkg/discovery/tracermetadata
+github.com/DataDog/datadog-agent/pkg/util/kernel
+github.com/DataDog/datadog-agent/pkg/util/safeelf
+github.com/DataDog/gopsutil/host
+github.com/moby/sys/mountinfo
otel-agentlinuxarm64
+7, -0 
+debug/dwarf
+debug/elf
+github.com/DataDog/datadog-agent/pkg/discovery/tracermetadata
+github.com/DataDog/datadog-agent/pkg/util/kernel
+github.com/DataDog/datadog-agent/pkg/util/safeelf
+github.com/DataDog/gopsutil/host
+github.com/moby/sys/mountinfo

@cit-pr-commenter cit-pr-commenter
Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 3c692950-b3cf-4041-abd7-fd867cf8f06d

Baseline: 9b1c4ad
Comparison: ed0e8fd
Diff

Optimization Goals: ❌ Regression(s) detected

perf experiment goal Δ mean % Δ mean % CI trials links
❌ docker_containers_cpu % cpu utilization +5.50 [+2.51, +8.49] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
❌ docker_containers_cpu % cpu utilization +5.50 [+2.51, +8.49] 1 Logs
➖ docker_containers_memory memory utilization +1.03 [+0.95, +1.10] 1 Logs
➖ quality_gate_idle_all_features memory utilization +0.93 [+0.84, +1.02] 1 Logs bounds checks dashboard
➖ uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.25 [+0.20, +0.30] 1 Logs
➖ file_to_blackhole_100ms_latency egress throughput +0.12 [-0.43, +0.67] 1 Logs
➖ file_to_blackhole_0ms_latency_http1 egress throughput +0.10 [-0.49, +0.69] 1 Logs
➖ ddot_metrics memory utilization +0.08 [-0.03, +0.20] 1 Logs
➖ file_to_blackhole_0ms_latency egress throughput +0.08 [-0.50, +0.66] 1 Logs
➖ file_to_blackhole_1000ms_latency_linear_load egress throughput +0.06 [-0.18, +0.29] 1 Logs
➖ file_to_blackhole_300ms_latency egress throughput +0.04 [-0.59, +0.67] 1 Logs
➖ otlp_ingest_metrics memory utilization +0.01 [-0.18, +0.19] 1 Logs
➖ uds_dogstatsd_to_api ingress throughput +0.00 [-0.26, +0.26] 1 Logs
➖ tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.03, +0.02] 1 Logs
➖ file_to_blackhole_1000ms_latency egress throughput -0.05 [-0.57, +0.48] 1 Logs
➖ file_to_blackhole_0ms_latency_http2 egress throughput -0.07 [-0.63, +0.49] 1 Logs
➖ file_tree memory utilization -0.09 [-0.26, +0.08] 1 Logs
➖ file_to_blackhole_500ms_latency egress throughput -0.09 [-0.68, +0.50] 1 Logs
➖ ddot_logs memory utilization -0.11 [-0.25, +0.03] 1 Logs
➖ otlp_ingest_logs memory utilization -0.20 [-0.33, -0.07] 1 Logs
➖ quality_gate_idle memory utilization -0.28 [-0.36, -0.20] 1 Logs bounds checks dashboard
➖ quality_gate_logs % cpu utilization -0.66 [-3.44, +2.13] 1 Logs bounds checks dashboard
➖ uds_dogstatsd_to_api_cpu % cpu utilization -0.78 [-1.64, +0.09] 1 Logs
➖ tcp_syslog_to_blackhole ingress throughput -1.16 [-1.21, -1.11] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
✅ docker_containers_cpu simple_check_run 10/10
✅ docker_containers_memory memory_usage 10/10
✅ docker_containers_memory simple_check_run 10/10
✅ file_to_blackhole_0ms_latency lost_bytes 10/10
✅ file_to_blackhole_0ms_latency memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http1 memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http2 memory_usage 10/10
✅ file_to_blackhole_1000ms_latency memory_usage 10/10
✅ file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
✅ file_to_blackhole_100ms_latency lost_bytes 10/10
✅ file_to_blackhole_100ms_latency memory_usage 10/10
✅ file_to_blackhole_300ms_latency lost_bytes 10/10
✅ file_to_blackhole_300ms_latency memory_usage 10/10
✅ file_to_blackhole_500ms_latency lost_bytes 10/10
✅ file_to_blackhole_500ms_latency memory_usage 10/10
✅ quality_gate_idle intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle memory_usage 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
✅ quality_gate_logs intake_connections 10/10 bounds checks dashboard
✅ quality_gate_logs lost_bytes 10/10 bounds checks dashboard
✅ quality_gate_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.

@agent-platform-auto-pr
Copy link
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 9b1c4ad

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
✅ agent_deb_amd64 $${+0.05}$$ $${695.76}$$ < $${752.99}$$ $${+0.04}$$ $${175.96}$$ < $${187.44}$$
✅ agent_deb_amd64_fips $${+0.06}$$ $${693.98}$$ < $${751.36}$$ $${-0}$$ $${175.6}$$ < $${187.06}$$
✅ agent_heroku_amd64 $${+0.04}$$ $${358.24}$$ < $${369.68}$$ $${+0.01}$$ $${96.45}$$ < $${99.55}$$
✅ agent_msi $${+0.2}$$ $${957.92}$$ < $${987.01}$$ $${+0.02}$$ $${146.14}$$ < $${150.72}$$
✅ agent_rpm_amd64 $${+0.05}$$ $${695.75}$$ < $${752.98}$$ $${+0.02}$$ $${177.5}$$ < $${190.03}$$
✅ agent_rpm_amd64_fips $${+0.06}$$ $${693.97}$$ < $${751.35}$$ $${-0.05}$$ $${177.32}$$ < $${189.81}$$
✅ agent_rpm_arm64 $${+0.05}$$ $${685.75}$$ < $${739.42}$$ $${+0.01}$$ $${160.86}$$ < $${171.23}$$
✅ agent_rpm_arm64_fips $${+0.05}$$ $${684.1}$$ < $${737.91}$$ $${-0}$$ $${160.03}$$ < $${170.22}$$
✅ agent_suse_amd64 $${+0.05}$$ $${695.75}$$ < $${752.98}$$ $${+0.02}$$ $${177.5}$$ < $${190.03}$$
✅ agent_suse_amd64_fips $${+0.06}$$ $${693.97}$$ < $${751.35}$$ $${-0.05}$$ $${177.32}$$ < $${189.81}$$
✅ agent_suse_arm64 $${+0.05}$$ $${685.75}$$ < $${739.42}$$ $${+0.01}$$ $${160.86}$$ < $${171.23}$$
✅ agent_suse_arm64_fips $${+0.05}$$ $${684.1}$$ < $${737.91}$$ $${-0}$$ $${160.03}$$ < $${170.22}$$
✅ docker_agent_amd64 $${+0.05}$$ $${779.55}$$ < $${849.39}$$ $${+0.04}$$ $${268.48}$$ < $${288.34}$$
✅ docker_agent_arm64 $${+0.05}$$ $${793.0}$$ < $${858.97}$$ $${+0.02}$$ $${255.85}$$ < $${274.36}$$
✅ docker_agent_jmx_amd64 $${+0.05}$$ $${970.74}$$ < $${1040.59}$$ $${-0.01}$$ $${337.42}$$ < $${357.3}$$
✅ docker_agent_jmx_arm64 $${+0.05}$$ $${972.79}$$ < $${1038.77}$$ $${+0.01}$$ $${320.79}$$ < $${339.32}$$
✅ docker_agent_windows1809 $${-0.22}$$ $${1485.6}$$ < $${1557.19}$$ $${-0.49}$$ $${487.18}$$ < $${507.33}$$
✅ docker_agent_windows1809_core $${+0.2}$$ $${6215.97}$$ < $${6287.46}$$ $${0}$$ $${2048.0}$$ < $${2067.76}$$
✅ docker_agent_windows1809_core_jmx $${+22.45}$$ $${6359.8}$$ < $${6409.04}$$ $${0}$$ $${2048.0}$$ < $${2067.76}$$
✅ docker_agent_windows1809_jmx $${+0.19}$$ $${1607.64}$$ < $${1679.14}$$ $${+0.13}$$ $${530.0}$$ < $${550.27}$$
✅ docker_agent_windows2022 $${+0.09}$$ $${1505.25}$$ < $${1576.85}$$ $${+0.08}$$ $${500.43}$$ < $${520.76}$$
✅ docker_agent_windows2022_core $${+0.2}$$ $${6189.19}$$ < $${6260.53}$$ $${0}$$ $${2048.0}$$ < $${2067.76}$$
✅ docker_agent_windows2022_core_jmx $${+0.38}$$ $${6310.86}$$ < $${6382.17}$$ $${0}$$ $${2048.0}$$ < $${2067.76}$$
✅ docker_agent_windows2022_jmx $${+0.31}$$ $${1627.0}$$ < $${1698.2}$$ $${+0.09}$$ $${542.73}$$ < $${562.99}$$
✅ docker_cluster_agent_amd64 $${+0.02}$$ $${259.24}$$ < $${259.73}$$ $${+0.02}$$ $${102.92}$$ < $${103.68}$$
✅ docker_cluster_agent_arm64 $${+0.07}$$ $${273.65}$$ < $${274.24}$$ $${-0}$$ $${97.58}$$ < $${98.45}$$
✅ docker_cws_instrumentation_amd64 $${0}$$ $${7.08}$$ < $${7.12}$$ $${-0}$$ $${2.95}$$ < $${3.29}$$
✅ docker_cws_instrumentation_arm64 $${-0}$$ $${6.69}$$ < $${6.92}$$ $${+0}$$ $${2.7}$$ < $${3.07}$$
✅ docker_dogstatsd_amd64 $${+0.01}$$ $${39.22}$$ < $${39.57}$$ $${+0}$$ $${15.11}$$ < $${15.76}$$
✅ docker_dogstatsd_arm64 $${-0}$$ $${37.88}$$ < $${38.2}$$ $${+0}$$ $${14.53}$$ < $${14.83}$$
✅ dogstatsd_deb_amd64 $${+0}$$ $${30.44}$$ < $${31.52}$$ $${+0}$$ $${8.0}$$ < $${8.97}$$
✅ dogstatsd_deb_arm64 $${+0}$$ $${29.01}$$ < $${30.08}$$ $${-0}$$ $${6.94}$$ < $${7.92}$$
✅ dogstatsd_rpm_amd64 $${+0}$$ $${30.44}$$ < $${31.52}$$ $${+0}$$ $${8.01}$$ < $${8.98}$$
✅ dogstatsd_suse_amd64 $${+0}$$ $${30.44}$$ < $${31.52}$$ $${+0}$$ $${8.01}$$ < $${8.98}$$
✅ iot_agent_deb_amd64 $${+0.04}$$ $${50.35}$$ < $${60.17}$$ $${+0.01}$$ $${12.81}$$ < $${15.82}$$
✅ iot_agent_deb_arm64 $${+0.04}$$ $${47.82}$$ < $${56.94}$$ $${+0.01}$$ $${11.12}$$ < $${13.86}$$
✅ iot_agent_deb_armhf $${+0.04}$$ $${47.39}$$ < $${56.41}$$ $${+0.01}$$ $${11.18}$$ < $${13.86}$$
✅ iot_agent_rpm_amd64 $${+0.04}$$ $${50.35}$$ < $${60.18}$$ $${+0.01}$$ $${12.83}$$ < $${15.84}$$
✅ iot_agent_rpm_arm64 $${+0.04}$$ $${47.82}$$ < $${56.94}$$ $${+0.01}$$ $${11.14}$$ < $${13.76}$$
✅ iot_agent_suse_amd64 $${+0.04}$$ $${50.35}$$ < $${60.18}$$ $${+0.01}$$ $${12.83}$$ < $${15.84}$$

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
changelog/no-changelog qa/done QA done before merge and regressions are covered by tests team/agent-discovery
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vitkyrka @Yumasi