Skip to content

[CWS] Fix runc init path resolution #37906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

[CWS] Fix runc init path resolution #37906

wants to merge 8 commits into from
+498 −33

Conversation

kovagsm
Copy link
Contributor

@kovagsm kovagsm commented Jun 12, 2025

What does this PR do?

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@kovagsm kovagsm force-pushed the CWS-3772_Abnormal_Path_Fix branch 2 times, most recently from 650cb67 to 99d8ab9 Compare June 12, 2025 17:48
@kovagsm
Copy link
Contributor Author

kovagsm commented Jun 12, 2025

/trigger-ci

@dd-devflow
Copy link

dd-devflow bot commented Jun 12, 2025

View all feedbacks in Devflow UI.

2025-06-12 17:48:45 UTC ℹ️ Start processing command /trigger-ci
If you need support, contact us on Slack #devflow!

2025-06-12 17:51:49 UTC 🚨 Devflow

Post "https://gitlab.ddbuild.io/api/v4/projects/DataDog%2Fdatadog-agent/pipeline": net/http: request canceled (Client.Timeout exceeded while awaiting headers)

Details 
child workflow execution error (type: devflow.Devflow_TriggerCiFromPr, workflowID: 22ea7dd8-ece5-412e-a5b4-2ac818f30e6a_26, runID: 607bb387-a6f2-4e99-8535-685bb08c1853, initiatedEventID: 26, startedEventID: 27): child workflow execution error (type: devflow.Devflow_TriggerCi, workflowID: 607bb387-a6f2-4e99-8535-685bb08c1853_14, runID: 3a083afc-1cb6-487a-8105-3e18ba4c1edd, initiatedEventID: 14, startedEventID: 15): activity error (type: gitlab.GitlabService_CreatePipeline, scheduledEventID: 26, startedEventID: 27, identity: ): activity ScheduleToClose timeout (type: ScheduleToClose): Post "https://gitlab.ddbuild.io/api/v4/projects/DataDog%2Fdatadog-agent/pipeline": net/http: request canceled (Client.Timeout exceeded while awaiting headers) (type: Error, retryable: true): net/http: request canceled (Client.Timeout exceeded while awaiting headers) (type: timeoutError, retryable: true)

If you need support, contact us on Slack #devflow with those details!

@cit-pr-commenter cit-pr-commenter
Copy link

cit-pr-commenter bot commented Jun 12, 2025 •
edited
Loading

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: efcb258c-b53f-424b-ada2-5f8b3cd247cd

Baseline: 207d15f
Comparison: cee6369
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
➖ docker_containers_cpu % cpu utilization +1.53 [-1.46, +4.52] 1 Logs
➖ uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.56 [+0.50, +0.62] 1 Logs
➖ otlp_ingest_metrics memory utilization +0.54 [+0.38, +0.70] 1 Logs
➖ ddot_metrics memory utilization +0.42 [+0.30, +0.54] 1 Logs
➖ quality_gate_idle memory utilization +0.39 [+0.33, +0.45] 1 Logs bounds checks dashboard
➖ ddot_logs memory utilization +0.36 [+0.24, +0.48] 1 Logs
➖ file_tree memory utilization +0.28 [+0.11, +0.44] 1 Logs
➖ file_to_blackhole_500ms_latency egress throughput +0.07 [-0.58, +0.72] 1 Logs
➖ file_to_blackhole_1000ms_latency egress throughput +0.06 [-0.53, +0.64] 1 Logs
➖ file_to_blackhole_1000ms_latency_linear_load egress throughput +0.03 [-0.21, +0.26] 1 Logs
➖ file_to_blackhole_100ms_latency egress throughput +0.02 [-0.60, +0.64] 1 Logs
➖ file_to_blackhole_0ms_latency_http2 egress throughput +0.02 [-0.57, +0.60] 1 Logs
➖ file_to_blackhole_0ms_latency egress throughput +0.00 [-0.55, +0.56] 1 Logs
➖ file_to_blackhole_300ms_latency egress throughput +0.00 [-0.62, +0.63] 1 Logs
➖ uds_dogstatsd_to_api ingress throughput +0.00 [-0.26, +0.26] 1 Logs
➖ tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.02, +0.02] 1 Logs
➖ quality_gate_idle_all_features memory utilization -0.01 [-0.09, +0.08] 1 Logs bounds checks dashboard
➖ file_to_blackhole_0ms_latency_http1 egress throughput -0.03 [-0.63, +0.57] 1 Logs
➖ otlp_ingest_logs memory utilization -0.29 [-0.42, -0.17] 1 Logs
➖ tcp_syslog_to_blackhole ingress throughput -0.32 [-0.37, -0.27] 1 Logs
➖ uds_dogstatsd_to_api_cpu % cpu utilization -0.54 [-1.40, +0.32] 1 Logs
➖ docker_containers_memory memory utilization -0.55 [-0.60, -0.49] 1 Logs
➖ quality_gate_logs % cpu utilization -3.59 [-6.30, -0.88] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
✅ docker_containers_cpu simple_check_run 10/10
✅ docker_containers_memory memory_usage 10/10
✅ docker_containers_memory simple_check_run 10/10
✅ file_to_blackhole_0ms_latency lost_bytes 10/10
✅ file_to_blackhole_0ms_latency memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http1 memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http2 memory_usage 10/10
✅ file_to_blackhole_1000ms_latency memory_usage 10/10
✅ file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
✅ file_to_blackhole_100ms_latency lost_bytes 10/10
✅ file_to_blackhole_100ms_latency memory_usage 10/10
✅ file_to_blackhole_300ms_latency lost_bytes 10/10
✅ file_to_blackhole_300ms_latency memory_usage 10/10
✅ file_to_blackhole_500ms_latency lost_bytes 10/10
✅ file_to_blackhole_500ms_latency memory_usage 10/10
✅ quality_gate_idle intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle memory_usage 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
✅ quality_gate_logs intake_connections 10/10 bounds checks dashboard
✅ quality_gate_logs lost_bytes 10/10 bounds checks dashboard
✅ quality_gate_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@github-actions github-actions bot added long review PR is complex, plan time to review it and removed medium review PR review might take time labels Jun 13, 2025
@kovagsm kovagsm force-pushed the CWS-3772_Abnormal_Path_Fix branch from a2059c1 to ae9bf4f Compare June 13, 2025 15:35
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jun 13, 2025 •
edited
Loading

Static quality checks

❌ Please find below the results from static quality gates
Comparison made with ancestor 207d15f

Error

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
❌ docker_agent_windows2022_jmx $${+0.27}$$ $${1628.2}$$ > $${1628.16}$$ $${+0.03}$$ $${543.05}$$ < $${543.98}$$
Gate failure full details
Quality gate Error type Error message
docker_agent_windows2022_jmx AssertionError Image size on disk (uncompressed image size) 1707289418 is higher than the maximum allowed 1707249500 by the gate !

Static quality gates prevent the PR to merge! You can check the static quality gates confluence page for guidance. We also have a toolbox page available to list tools useful to debug the size increase.

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
✅ agent_deb_amd64 $${+0.14}$$ $${696.51}$$ < $${697.37}$$ $${+0.01}$$ $${176.08}$$ < $${177.03}$$
✅ agent_deb_amd64_fips $${+0.14}$$ $${694.81}$$ < $${695.59}$$ $${+0.01}$$ $${175.56}$$ < $${176.51}$$
✅ agent_heroku_amd64 $${0}$$ $${358.67}$$ < $${359.67}$$ $${+0}$$ $${96.52}$$ < $${97.47}$$
✅ agent_msi $${0}$$ $${958.87}$$ < $${959.86}$$ $${-0.01}$$ $${146.29}$$ < $${147.27}$$
✅ agent_rpm_amd64 $${+0.14}$$ $${696.5}$$ < $${697.36}$$ $${-0.01}$$ $${177.6}$$ < $${178.56}$$
✅ agent_rpm_amd64_fips $${+0.14}$$ $${694.79}$$ < $${695.58}$$ $${-0.03}$$ $${177.48}$$ < $${178.43}$$
✅ agent_rpm_arm64 $${+0.14}$$ $${686.52}$$ < $${687.37}$$ $${+0.02}$$ $${161.01}$$ < $${161.99}$$
✅ agent_rpm_arm64_fips $${+0.14}$$ $${684.93}$$ < $${685.72}$$ $${-0.03}$$ $${160.18}$$ < $${161.11}$$
✅ agent_suse_amd64 $${+0.14}$$ $${696.5}$$ < $${697.36}$$ $${-0.01}$$ $${177.6}$$ < $${178.56}$$
✅ agent_suse_amd64_fips $${+0.14}$$ $${694.79}$$ < $${695.58}$$ $${-0.03}$$ $${177.48}$$ < $${178.43}$$
✅ agent_suse_arm64 $${+0.14}$$ $${686.52}$$ < $${687.37}$$ $${+0.02}$$ $${161.01}$$ < $${161.99}$$
✅ agent_suse_arm64_fips $${+0.14}$$ $${684.93}$$ < $${685.72}$$ $${-0.03}$$ $${160.18}$$ < $${161.11}$$
✅ docker_agent_amd64 $${+0.14}$$ $${780.3}$$ < $${781.16}$$ $${+0.02}$$ $${268.69}$$ < $${269.63}$$
✅ docker_agent_arm64 $${+0.14}$$ $${793.77}$$ < $${794.62}$$ $${+0.02}$$ $${256.06}$$ < $${257.0}$$
✅ docker_agent_jmx_amd64 $${+0.14}$$ $${971.5}$$ < $${972.35}$$ $${+0.02}$$ $${337.67}$$ < $${338.6}$$
✅ docker_agent_jmx_arm64 $${+0.14}$$ $${973.56}$$ < $${974.41}$$ $${+0.02}$$ $${321.01}$$ < $${321.97}$$
✅ docker_agent_windows1809 $${+0.26}$$ $${1487.03}$$ < $${1488.0}$$ $${+0.16}$$ $${488.02}$$ < $${488.95}$$
✅ docker_agent_windows1809_core $${+0}$$ $${6216.97}$$ < $${6218.0}$$ $${0}$$ $${2048.0}$$ < $${2049.0}$$
✅ docker_agent_windows1809_core_jmx $${-0}$$ $${6338.54}$$ < $${6339.0}$$ $${0}$$ $${2048.0}$$ < $${2049.0}$$
✅ docker_agent_windows1809_jmx $${+0}$$ $${1608.65}$$ < $${1609.5}$$ $${-0.12}$$ $${530.31}$$ < $${531.32}$$
✅ docker_agent_windows2022 $${+0.16}$$ $${1506.31}$$ < $${1507.0}$$ $${+0.02}$$ $${500.75}$$ < $${501.7}$$
✅ docker_agent_windows2022_core $${+0.02}$$ $${6190.28}$$ < $${6311.0}$$ $${0}$$ $${2048.0}$$ < $${2049.0}$$
✅ docker_agent_windows2022_core_jmx $${+0.02}$$ $${6311.86}$$ < $${6313.0}$$ $${0}$$ $${2048.0}$$ < $${2049.0}$$
✅ docker_cluster_agent_amd64 $${+0}$$ $${212.84}$$ < $${213.79}$$ $${+0}$$ $${72.38}$$ < $${73.33}$$
✅ docker_cluster_agent_arm64 $${0}$$ $${228.68}$$ < $${229.64}$$ $${-0}$$ $${68.65}$$ < $${69.6}$$
✅ docker_cws_instrumentation_amd64 $${0}$$ $${7.08}$$ < $${7.12}$$ $${-0}$$ $${2.95}$$ < $${3.29}$$
✅ docker_cws_instrumentation_arm64 $${0}$$ $${6.69}$$ < $${6.92}$$ $${+0}$$ $${2.7}$$ < $${3.07}$$
✅ docker_dogstatsd_amd64 $${0}$$ $${39.22}$$ < $${39.57}$$ $${-0}$$ $${15.12}$$ < $${15.76}$$
✅ docker_dogstatsd_arm64 $${-0}$$ $${37.88}$$ < $${38.2}$$ $${-0}$$ $${14.53}$$ < $${14.83}$$
✅ dogstatsd_deb_amd64 $${0}$$ $${30.45}$$ < $${31.4}$$ $${+0}$$ $${8.0}$$ < $${8.95}$$
✅ dogstatsd_deb_arm64 $${0}$$ $${29.02}$$ < $${29.97}$$ $${-0}$$ $${6.94}$$ < $${7.89}$$
✅ dogstatsd_rpm_amd64 $${0}$$ $${30.45}$$ < $${31.4}$$ $${+0}$$ $${8.01}$$ < $${8.96}$$
✅ dogstatsd_suse_amd64 $${0}$$ $${30.45}$$ < $${31.4}$$ $${+0}$$ $${8.01}$$ < $${8.96}$$
✅ iot_agent_deb_amd64 $${0}$$ $${50.42}$$ < $${51.38}$$ $${+0}$$ $${12.84}$$ < $${13.79}$$
✅ iot_agent_deb_arm64 $${0}$$ $${47.9}$$ < $${48.85}$$ $${-0}$$ $${11.14}$$ < $${12.09}$$
✅ iot_agent_deb_armhf $${0}$$ $${47.47}$$ < $${48.42}$$ $${+0.01}$$ $${11.21}$$ < $${12.16}$$
✅ iot_agent_rpm_amd64 $${0}$$ $${50.42}$$ < $${51.38}$$ $${-0}$$ $${12.86}$$ < $${13.81}$$
✅ iot_agent_rpm_arm64 $${0}$$ $${47.9}$$ < $${48.85}$$ $${+0}$$ $${11.16}$$ < $${12.11}$$
✅ iot_agent_suse_amd64 $${0}$$ $${50.42}$$ < $${51.38}$$ $${-0}$$ $${12.86}$$ < $${13.81}$$

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component/system-probe long review PR is complex, plan time to review it team/agent-security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kovagsm