Skip to content

[CWS] make kfilters naming consistent #37936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[CWS] make kfilters naming consistent #37936

wants to merge 2 commits into from

Conversation

safchain
Copy link
Contributor

What does this PR do?

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@safchain safchain added this to the Triage milestone Jun 13, 2025
@safchain safchain added changelog/no-changelog team/agent-security category/improvement qa/done QA done before merge and regressions are covered by tests labels Jun 13, 2025
@github-actions github-actions bot added component/system-probe medium review PR review might take time labels Jun 13, 2025
@safchain safchain force-pushed the safchain/kfilters-refacto branch from 8a1ebbc to 42ffdbf Compare June 13, 2025 14:37
@github-actions github-actions bot added long review PR is complex, plan time to review it and removed medium review PR review might take time labels Jun 13, 2025
@safchain safchain force-pushed the safchain/kfilters-refacto branch from 42ffdbf to 68a62d3 Compare June 13, 2025 15:28
@cit-pr-commenter cit-pr-commenter
Copy link

cit-pr-commenter bot commented Jun 13, 2025 •
edited
Loading

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: e14521e8-9e9b-4fbb-8b96-35f6397d2625

Baseline: 650ae4e
Comparison: 6d726c2
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
➖ quality_gate_idle memory utilization +1.03 [+0.98, +1.08] 1 Logs bounds checks dashboard
➖ otlp_ingest_logs memory utilization +0.27 [+0.14, +0.40] 1 Logs
➖ docker_containers_cpu % cpu utilization +0.10 [-2.94, +3.14] 1 Logs
➖ file_to_blackhole_300ms_latency egress throughput +0.08 [-0.56, +0.73] 1 Logs
➖ file_to_blackhole_1000ms_latency egress throughput +0.07 [-0.52, +0.66] 1 Logs
➖ file_to_blackhole_0ms_latency egress throughput +0.07 [-0.51, +0.65] 1 Logs
➖ uds_dogstatsd_to_api_cpu % cpu utilization +0.06 [-0.79, +0.91] 1 Logs
➖ file_to_blackhole_0ms_latency_http2 egress throughput +0.05 [-0.51, +0.61] 1 Logs
➖ file_tree memory utilization +0.05 [-0.10, +0.20] 1 Logs
➖ file_to_blackhole_0ms_latency_http1 egress throughput +0.01 [-0.60, +0.62] 1 Logs
➖ file_to_blackhole_1000ms_latency_linear_load egress throughput +0.01 [-0.23, +0.25] 1 Logs
➖ uds_dogstatsd_to_api ingress throughput -0.00 [-0.26, +0.25] 1 Logs
➖ tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.03, +0.02] 1 Logs
➖ ddot_logs memory utilization -0.01 [-0.13, +0.11] 1 Logs
➖ file_to_blackhole_500ms_latency egress throughput -0.03 [-0.61, +0.56] 1 Logs
➖ file_to_blackhole_100ms_latency egress throughput -0.11 [-0.69, +0.46] 1 Logs
➖ ddot_metrics memory utilization -0.27 [-0.39, -0.16] 1 Logs
➖ tcp_syslog_to_blackhole ingress throughput -0.34 [-0.40, -0.28] 1 Logs
➖ quality_gate_idle_all_features memory utilization -0.37 [-0.44, -0.29] 1 Logs bounds checks dashboard
➖ otlp_ingest_metrics memory utilization -0.40 [-0.56, -0.24] 1 Logs
➖ uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -1.01 [-1.08, -0.93] 1 Logs
➖ docker_containers_memory memory utilization -1.18 [-1.27, -1.10] 1 Logs
➖ quality_gate_logs % cpu utilization -1.25 [-3.98, +1.49] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
✅ docker_containers_cpu simple_check_run 10/10
✅ docker_containers_memory memory_usage 10/10
✅ docker_containers_memory simple_check_run 10/10
✅ file_to_blackhole_0ms_latency lost_bytes 10/10
✅ file_to_blackhole_0ms_latency memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http1 memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http2 memory_usage 10/10
✅ file_to_blackhole_1000ms_latency memory_usage 10/10
✅ file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
✅ file_to_blackhole_100ms_latency lost_bytes 10/10
✅ file_to_blackhole_100ms_latency memory_usage 10/10
✅ file_to_blackhole_300ms_latency lost_bytes 10/10
✅ file_to_blackhole_300ms_latency memory_usage 10/10
✅ file_to_blackhole_500ms_latency lost_bytes 10/10
✅ file_to_blackhole_500ms_latency memory_usage 10/10
✅ quality_gate_idle intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle memory_usage 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
✅ quality_gate_logs intake_connections 10/10 bounds checks dashboard
✅ quality_gate_logs lost_bytes 10/10 bounds checks dashboard
✅ quality_gate_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.

@safchain safchain marked this pull request as ready for review June 13, 2025 16:37
@safchain safchain requested a review from a team as a code owner June 13, 2025 16:37
@agent-platform-auto-pr
Copy link
Contributor

Static quality checks

❌ Please find below the results from static quality gates
Comparison made with ancestor 650ae4e

Error

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
❌ docker_agent_windows1809 $${-0}$$ $${1487.0}$$ > $${1484.8}$$ $${-0.01}$$ $${488.02}$$ < $${488.95}$$
❌ docker_agent_windows1809_core $${-0}$$ $${6216.96}$$ > $${6215.68}$$ $${0}$$ $${2048.0}$$ < $${2048.0}$$
❌ docker_agent_windows1809_jmx $${-0}$$ $${1608.63}$$ > $${1607.68}$$ $${-0.11}$$ $${530.28}$$ < $${531.32}$$
❌ docker_agent_windows2022 $${-0.13}$$ $${1506.34}$$ > $${1505.28}$$ $${-0.03}$$ $${500.75}$$ < $${501.7}$$
❌ docker_agent_windows2022_core_jmx $${+0.19}$$ $${6311.88}$$ > $${6307.84}$$ $${0}$$ $${2048.0}$$ < $${2048.0}$$
Gate failure full details
Quality gate Error type Error message
docker_agent_windows1809 AssertionError Image size on disk (uncompressed image size) 1559229847 is higher than the maximum allowed 1556925644 by the gate !
docker_agent_windows1809_core AssertionError Image size on disk (uncompressed image size) 6518950344 is higher than the maximum allowed 6517612871 by the gate !
docker_agent_windows1809_jmx AssertionError Image size on disk (uncompressed image size) 1686767856 is higher than the maximum allowed 1685774663 by the gate !
docker_agent_windows2022 AssertionError Image size on disk (uncompressed image size) 1579512671 is higher than the maximum allowed 1578400481 by the gate !
docker_agent_windows2022_core_jmx AssertionError Image size on disk (uncompressed image size) 6618485376 is higher than the maximum allowed 6614249635 by the gate !

Static quality gates prevent the PR to merge! You can check the static quality gates confluence page for guidance. We also have a toolbox page available to list tools useful to debug the size increase.

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
✅ agent_deb_amd64 $${+0.01}$$ $${696.38}$$ < $${697.37}$$ $${-0}$$ $${176.05}$$ < $${177.03}$$
✅ agent_deb_amd64_fips $${+0.01}$$ $${694.6}$$ < $${695.59}$$ $${+0}$$ $${175.48}$$ < $${176.51}$$
✅ agent_heroku_amd64 $${0}$$ $${358.66}$$ < $${359.67}$$ $${-0}$$ $${96.52}$$ < $${97.47}$$
✅ agent_msi $${0}$$ $${958.86}$$ < $${959.86}$$ $${+0}$$ $${146.29}$$ < $${147.27}$$
✅ agent_rpm_amd64 $${+0.01}$$ $${696.36}$$ < $${697.36}$$ $${-0}$$ $${177.59}$$ < $${178.56}$$
✅ agent_rpm_amd64_fips $${+0.01}$$ $${694.59}$$ < $${695.58}$$ $${+0}$$ $${177.47}$$ < $${178.43}$$
✅ agent_rpm_arm64 $${+0.01}$$ $${686.37}$$ < $${687.37}$$ $${-0.01}$$ $${161.04}$$ < $${161.99}$$
✅ agent_rpm_arm64_fips $${+0.01}$$ $${684.72}$$ < $${685.72}$$ $${+0.01}$$ $${160.16}$$ < $${161.11}$$
✅ agent_suse_amd64 $${+0.01}$$ $${696.36}$$ < $${697.36}$$ $${-0}$$ $${177.59}$$ < $${178.56}$$
✅ agent_suse_amd64_fips $${+0.01}$$ $${694.59}$$ < $${695.58}$$ $${+0}$$ $${177.47}$$ < $${178.43}$$
✅ agent_suse_arm64 $${+0.01}$$ $${686.37}$$ < $${687.37}$$ $${-0.01}$$ $${161.04}$$ < $${161.99}$$
✅ agent_suse_arm64_fips $${+0.01}$$ $${684.72}$$ < $${685.72}$$ $${+0.01}$$ $${160.16}$$ < $${161.11}$$
✅ docker_agent_amd64 $${+0.01}$$ $${780.16}$$ < $${781.16}$$ $${+0}$$ $${268.68}$$ < $${269.63}$$
✅ docker_agent_arm64 $${+0.01}$$ $${793.62}$$ < $${794.62}$$ $${-0}$$ $${256.05}$$ < $${257.0}$$
✅ docker_agent_jmx_amd64 $${+0.01}$$ $${971.36}$$ < $${972.35}$$ $${-0}$$ $${337.66}$$ < $${338.6}$$
✅ docker_agent_jmx_arm64 $${+0.01}$$ $${973.41}$$ < $${974.41}$$ $${+0}$$ $${320.99}$$ < $${321.97}$$
✅ docker_agent_windows1809_core_jmx $${-0}$$ $${6338.53}$$ < $${6338.56}$$ $${0}$$ $${2048.0}$$ < $${2048.0}$$
✅ docker_agent_windows2022_core $${+0.25}$$ $${6190.27}$$ < $${6195.2}$$ $${0}$$ $${2048.0}$$ < $${2048.0}$$
✅ docker_agent_windows2022_jmx $${-0.01}$$ $${1628.15}$$ < $${1628.16}$$ $${-0.01}$$ $${543.05}$$ < $${543.98}$$
✅ docker_cluster_agent_amd64 $${-0}$$ $${212.84}$$ < $${213.79}$$ $${-0}$$ $${72.38}$$ < $${73.33}$$
✅ docker_cluster_agent_arm64 $${+0}$$ $${228.68}$$ < $${229.64}$$ $${+0}$$ $${68.64}$$ < $${69.6}$$
✅ docker_cws_instrumentation_amd64 $${-0}$$ $${7.08}$$ < $${7.12}$$ $${-0}$$ $${2.95}$$ < $${3.29}$$
✅ docker_cws_instrumentation_arm64 $${0}$$ $${6.69}$$ < $${6.92}$$ $${-0}$$ $${2.7}$$ < $${3.07}$$
✅ docker_dogstatsd_amd64 $${0}$$ $${39.22}$$ < $${39.57}$$ $${+0}$$ $${15.12}$$ < $${15.76}$$
✅ docker_dogstatsd_arm64 $${-0}$$ $${37.88}$$ < $${38.2}$$ $${+0}$$ $${14.54}$$ < $${14.83}$$
✅ dogstatsd_deb_amd64 $${0}$$ $${30.44}$$ < $${31.4}$$ $${-0}$$ $${8.0}$$ < $${8.95}$$
✅ dogstatsd_deb_arm64 $${0}$$ $${29.02}$$ < $${29.97}$$ $${+0}$$ $${6.94}$$ < $${7.89}$$
✅ dogstatsd_rpm_amd64 $${0}$$ $${30.44}$$ < $${31.4}$$ $${+0}$$ $${8.01}$$ < $${8.96}$$
✅ dogstatsd_suse_amd64 $${0}$$ $${30.44}$$ < $${31.4}$$ $${+0}$$ $${8.01}$$ < $${8.96}$$
✅ iot_agent_deb_amd64 $${0}$$ $${50.42}$$ < $${51.38}$$ $${-0}$$ $${12.84}$$ < $${13.79}$$
✅ iot_agent_deb_arm64 $${0}$$ $${47.9}$$ < $${48.85}$$ $${-0}$$ $${11.14}$$ < $${12.09}$$
✅ iot_agent_deb_armhf $${0}$$ $${47.47}$$ < $${48.42}$$ $${-0}$$ $${11.2}$$ < $${12.16}$$
✅ iot_agent_rpm_amd64 $${0}$$ $${50.42}$$ < $${51.38}$$ $${-0}$$ $${12.86}$$ < $${13.81}$$
✅ iot_agent_rpm_arm64 $${0}$$ $${47.9}$$ < $${48.85}$$ $${-0}$$ $${11.15}$$ < $${12.11}$$
✅ iot_agent_suse_amd64 $${0}$$ $${50.42}$$ < $${51.38}$$ $${-0}$$ $${12.86}$$ < $${13.81}$$

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
category/improvement changelog/no-changelog component/system-probe long review PR is complex, plan time to review it qa/done QA done before merge and regressions are covered by tests team/agent-security
Projects
None yet
Milestone
Triage
Development

Successfully merging this pull request may close these issues.
1 participant
@safchain