Skip to content

[pkg/dyninst] Support pointer chasing limit #37945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2025
Merged

[pkg/dyninst] Support pointer chasing limit #37945

merged 1 commit into from
Jun 13, 2025
+1,199 −880

Conversation

piob-io
Copy link
Contributor

@piob-io piob-io commented Jun 13, 2025

What does this PR do?

Respect MaxReferenceDepth as a pointer chasing limit. Pointers (and interfaces in the futures) count towards the limit. Strings, slices (and maps in the future) do not count towards the limit.

Motivation

https://datadoghq.atlassian.net/browse/DEBUG-4066

@github-actions github-actions bot added the long review PR is complex, plan time to review it label Jun 13, 2025
@piob-io piob-io added changelog/no-changelog team/dynamic-instrumentation Dynamic Instrumentation qa/done QA done before merge and regressions are covered by tests labels Jun 13, 2025
@cit-pr-commenter cit-pr-commenter
Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: e7134696-ad22-4eba-913a-d7097a52fb02

Baseline: 99942ff
Comparison: 766d08f
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
➖ otlp_ingest_metrics memory utilization +0.27 [+0.11, +0.43] 1 Logs
➖ file_to_blackhole_0ms_latency_http1 egress throughput +0.06 [-0.50, +0.62] 1 Logs
➖ file_to_blackhole_300ms_latency egress throughput +0.04 [-0.59, +0.68] 1 Logs
➖ file_to_blackhole_0ms_latency egress throughput +0.04 [-0.54, +0.61] 1 Logs
➖ ddot_metrics memory utilization +0.03 [-0.09, +0.15] 1 Logs
➖ file_to_blackhole_500ms_latency egress throughput +0.01 [-0.59, +0.60] 1 Logs
➖ file_to_blackhole_100ms_latency egress throughput +0.00 [-0.55, +0.55] 1 Logs
➖ uds_dogstatsd_to_api ingress throughput +0.00 [-0.29, +0.29] 1 Logs
➖ tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
➖ file_to_blackhole_0ms_latency_http2 egress throughput -0.02 [-0.57, +0.53] 1 Logs
➖ quality_gate_idle memory utilization -0.02 [-0.07, +0.03] 1 Logs bounds checks dashboard
➖ file_to_blackhole_1000ms_latency egress throughput -0.03 [-0.62, +0.57] 1 Logs
➖ file_to_blackhole_1000ms_latency_linear_load egress throughput -0.04 [-0.28, +0.19] 1 Logs
➖ ddot_logs memory utilization -0.05 [-0.16, +0.07] 1 Logs
➖ otlp_ingest_logs memory utilization -0.31 [-0.44, -0.18] 1 Logs
➖ quality_gate_logs % cpu utilization -0.41 [-3.16, +2.34] 1 Logs bounds checks dashboard
➖ file_tree memory utilization -0.47 [-0.61, -0.33] 1 Logs
➖ quality_gate_idle_all_features memory utilization -0.58 [-0.67, -0.49] 1 Logs bounds checks dashboard
➖ docker_containers_memory memory utilization -0.82 [-0.89, -0.76] 1 Logs
➖ uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -0.96 [-1.01, -0.90] 1 Logs
➖ uds_dogstatsd_to_api_cpu % cpu utilization -1.06 [-1.94, -0.19] 1 Logs
➖ tcp_syslog_to_blackhole ingress throughput -1.26 [-1.33, -1.19] 1 Logs
➖ docker_containers_cpu % cpu utilization -3.02 [-5.89, -0.15] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
✅ docker_containers_cpu simple_check_run 10/10
✅ docker_containers_memory memory_usage 10/10
✅ docker_containers_memory simple_check_run 10/10
✅ file_to_blackhole_0ms_latency lost_bytes 10/10
✅ file_to_blackhole_0ms_latency memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http1 memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http2 memory_usage 10/10
✅ file_to_blackhole_1000ms_latency memory_usage 10/10
✅ file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
✅ file_to_blackhole_100ms_latency lost_bytes 10/10
✅ file_to_blackhole_100ms_latency memory_usage 10/10
✅ file_to_blackhole_300ms_latency lost_bytes 10/10
✅ file_to_blackhole_300ms_latency memory_usage 10/10
✅ file_to_blackhole_500ms_latency lost_bytes 10/10
✅ file_to_blackhole_500ms_latency memory_usage 10/10
✅ quality_gate_idle intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle memory_usage 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
✅ quality_gate_logs intake_connections 10/10 bounds checks dashboard
✅ quality_gate_logs lost_bytes 10/10 bounds checks dashboard
✅ quality_gate_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.

@piob-io piob-io marked this pull request as ready for review June 13, 2025 18:41
@piob-io piob-io requested a review from a team as a code owner June 13, 2025 18:41
ajwerner
ajwerner approved these changes Jun 13, 2025
View reviewed changes
Copy link
Contributor

@ajwerner ajwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@piob-io
Copy link
Contributor Author

piob-io commented Jun 13, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jun 13, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-06-13 19:19:17 UTC ℹ️ Start processing command /merge

2025-06-13 19:19:28 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-06-13 19:33:18 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 1h (p90).

2025-06-13 20:12:15 UTC ℹ️ MergeQueue: This merge request was merged

@agent-platform-auto-pr
Copy link
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 99942ff

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
✅ agent_deb_amd64 $${+0}$$ $${696.38}$$ < $${697.37}$$ $${+0.04}$$ $${176.09}$$ < $${177.03}$$
✅ agent_deb_amd64_fips $${+0}$$ $${694.67}$$ < $${695.59}$$ $${+0.03}$$ $${175.53}$$ < $${176.51}$$
✅ agent_heroku_amd64 $${0}$$ $${358.67}$$ < $${359.67}$$ $${-0}$$ $${96.51}$$ < $${97.47}$$
✅ agent_msi $${-0}$$ $${958.87}$$ < $${959.86}$$ $${-0.04}$$ $${146.28}$$ < $${147.27}$$
✅ agent_rpm_amd64 $${+0}$$ $${696.37}$$ < $${697.36}$$ $${-0.01}$$ $${177.59}$$ < $${178.56}$$
✅ agent_rpm_amd64_fips $${+0}$$ $${694.66}$$ < $${695.58}$$ $${+0.07}$$ $${177.5}$$ < $${178.43}$$
✅ agent_rpm_arm64 $${+0}$$ $${686.38}$$ < $${687.37}$$ $${+0.04}$$ $${161.07}$$ < $${161.99}$$
✅ agent_rpm_arm64_fips $${+0}$$ $${684.79}$$ < $${685.72}$$ $${-0.04}$$ $${160.18}$$ < $${161.11}$$
✅ agent_suse_amd64 $${+0}$$ $${696.37}$$ < $${697.36}$$ $${-0.01}$$ $${177.59}$$ < $${178.56}$$
✅ agent_suse_amd64_fips $${+0}$$ $${694.66}$$ < $${695.58}$$ $${+0.07}$$ $${177.5}$$ < $${178.43}$$
✅ agent_suse_arm64 $${+0}$$ $${686.38}$$ < $${687.37}$$ $${+0.04}$$ $${161.07}$$ < $${161.99}$$
✅ agent_suse_arm64_fips $${+0}$$ $${684.79}$$ < $${685.72}$$ $${-0.04}$$ $${160.18}$$ < $${161.11}$$
✅ docker_agent_amd64 $${+0}$$ $${780.17}$$ < $${781.16}$$ $${+0}$$ $${268.68}$$ < $${269.63}$$
✅ docker_agent_arm64 $${+0}$$ $${793.63}$$ < $${794.62}$$ $${-0.01}$$ $${256.05}$$ < $${257.0}$$
✅ docker_agent_jmx_amd64 $${+0}$$ $${971.36}$$ < $${972.35}$$ $${+0}$$ $${337.64}$$ < $${338.6}$$
✅ docker_agent_jmx_arm64 $${+0}$$ $${973.43}$$ < $${974.41}$$ $${+0.01}$$ $${320.99}$$ < $${321.97}$$
✅ docker_agent_windows1809 $${-0.07}$$ $${1486.95}$$ < $${1488.0}$$ $${+0.03}$$ $${488.03}$$ < $${488.95}$$
✅ docker_agent_windows1809_core $${-0.01}$$ $${6216.97}$$ < $${6218.0}$$ $${0}$$ $${2048.0}$$ < $${2049.0}$$
✅ docker_agent_windows1809_core_jmx $${-22.35}$$ $${6338.54}$$ < $${6361.0}$$ $${0}$$ $${2048.0}$$ < $${2049.0}$$
✅ docker_agent_windows1809_jmx $${-0}$$ $${1608.64}$$ < $${1609.5}$$ $${-0.09}$$ $${530.27}$$ < $${531.32}$$
✅ docker_agent_windows2022 $${+0.21}$$ $${1506.34}$$ < $${1507.0}$$ $${+0.01}$$ $${500.77}$$ < $${501.7}$$
✅ docker_agent_windows2022_core $${-0.24}$$ $${6190.02}$$ < $${6311.0}$$ $${0}$$ $${2048.0}$$ < $${2049.0}$$
✅ docker_agent_windows2022_core_jmx $${+0.03}$$ $${6311.92}$$ < $${6313.0}$$ $${0}$$ $${2048.0}$$ < $${2049.0}$$
✅ docker_agent_windows2022_jmx $${-0.06}$$ $${1628.09}$$ < $${1628.16}$$ $${+0}$$ $${543.04}$$ < $${543.98}$$
✅ docker_cluster_agent_amd64 $${-0}$$ $${212.84}$$ < $${213.79}$$ $${+0}$$ $${72.38}$$ < $${73.33}$$
✅ docker_cluster_agent_arm64 $${-0}$$ $${228.68}$$ < $${229.64}$$ $${+0}$$ $${68.65}$$ < $${69.6}$$
✅ docker_cws_instrumentation_amd64 $${0}$$ $${7.08}$$ < $${7.12}$$ $${+0}$$ $${2.95}$$ < $${3.29}$$
✅ docker_cws_instrumentation_arm64 $${0}$$ $${6.69}$$ < $${6.92}$$ $${-0}$$ $${2.7}$$ < $${3.07}$$
✅ docker_dogstatsd_amd64 $${+0}$$ $${39.22}$$ < $${39.57}$$ $${+0}$$ $${15.12}$$ < $${15.76}$$
✅ docker_dogstatsd_arm64 $${+0}$$ $${37.88}$$ < $${38.2}$$ $${-0}$$ $${14.53}$$ < $${14.83}$$
✅ dogstatsd_deb_amd64 $${0}$$ $${30.45}$$ < $${31.4}$$ $${+0}$$ $${8.0}$$ < $${8.95}$$
✅ dogstatsd_deb_arm64 $${0}$$ $${29.02}$$ < $${29.97}$$ $${-0}$$ $${6.94}$$ < $${7.89}$$
✅ dogstatsd_rpm_amd64 $${0}$$ $${30.45}$$ < $${31.4}$$ $${+0}$$ $${8.01}$$ < $${8.96}$$
✅ dogstatsd_suse_amd64 $${0}$$ $${30.45}$$ < $${31.4}$$ $${+0}$$ $${8.01}$$ < $${8.96}$$
✅ iot_agent_deb_amd64 $${0}$$ $${50.43}$$ < $${51.38}$$ $${+0}$$ $${12.84}$$ < $${13.79}$$
✅ iot_agent_deb_arm64 $${0}$$ $${47.9}$$ < $${48.85}$$ $${-0}$$ $${11.13}$$ < $${12.09}$$
✅ iot_agent_deb_armhf $${0}$$ $${47.47}$$ < $${48.42}$$ $${+0}$$ $${11.2}$$ < $${12.16}$$
✅ iot_agent_rpm_amd64 $${0}$$ $${50.43}$$ < $${51.38}$$ $${-0}$$ $${12.86}$$ < $${13.81}$$
✅ iot_agent_rpm_arm64 $${0}$$ $${47.9}$$ < $${48.85}$$ $${+0}$$ $${11.16}$$ < $${12.11}$$
✅ iot_agent_suse_amd64 $${0}$$ $${50.43}$$ < $${51.38}$$ $${-0}$$ $${12.86}$$ < $${13.81}$$

@dd-mergequeue dd-mergequeue bot merged commit 56572b4 into main Jun 13, 2025
350 of 353 checks passed
@dd-mergequeue dd-mergequeue bot deleted the piob-io/dyninst-ptr-ttl branch June 13, 2025 20:12
@github-actions github-actions bot added this to the 7.69.0 milestone Jun 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajwerner ajwerner ajwerner approved these changes

Assignees
No one assigned
Labels
changelog/no-changelog long review PR is complex, plan time to review it qa/done QA done before merge and regressions are covered by tests team/dynamic-instrumentation Dynamic Instrumentation
Projects
None yet
Milestone
7.69.0
Development

Successfully merging this pull request may close these issues.
2 participants
@piob-io @ajwerner