Skip to content

Allow other extended addresses than just 0xc8 to be routed from TX <-> RX (3.x.x maintenance) #2975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: 3.x.x-maintenance
Choose a base branch
from

Conversation

wimalopaan
Copy link

This PR tries to solve #2901

@wimalopaan wimalopaan force-pushed the 3.x.x-wmaddress branch 2 times, most recently from 2a8a6f4 to f60fd0b Compare October 22, 2024 04:39
@pkendall64
Copy link
Collaborator

It looks like you've targeted the 3.x.x branch but you code is on top of master. This cannot be merged to 3.x.x as it stands.

@wimalopaan
Copy link
Author

Yes, I Made a mistake and accidentially rebased on master instead of 3.x.x-maintenance. Now I have a hard time to figure Out how to revert. Maybe you can Help?

@mha1
Copy link
Contributor

mha1 commented Oct 22, 2024

Yes, I Made a mistake and accidentially rebased on master instead of 3.x.x-maintenance. Now I have a hard time to figure Out how to revert. Maybe you can Help?

Just rebase on master again. Prior to doing so make sure master is up-to-date

@wimalopaan
Copy link
Author

Yes, I Made a mistake and accidentially rebased on master instead of 3.x.x-maintenance. Now I have a hard time to figure Out how to revert. Maybe you can Help?

Just rebase on master again. Prior to doing so make sure master is up-to-date

Did you see, that this PR originates from 3.x.x-maintenance?

@mha1
Copy link
Contributor

mha1 commented Oct 22, 2024

Did you see, that this PR originates from 3.x.x-maintenance?

replace master with 3.x.x-maintenance in my comment

@wimalopaan
Copy link
Author

Did you see, that this PR originates from 3.x.x-maintenance?

replace master with 3.x.x-maintenance in my comment

Mmh ... I was looking for a way to reset HEAD to the last correct commit. Examining the reflog should make that possible, I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants