Skip to content

Mavlink dynamic sysIDv3 #3032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

LupusTheCanine
Copy link
Contributor

Makes source and target SysID dynamic
Adds event handler to SerialMavlink that updates SysIDs when the config is changed
Requires #3031

@pkendall64
Copy link
Collaborator

@LupusTheCanine we've merged the new eventing framework and now this one should be able to implemented on top of master quite simply.

@LupusTheCanine
Copy link
Contributor Author

LupusTheCanine commented Dec 19, 2024

@LupusTheCanine we've merged the new eventing framework and now this one should be able to implemented on top of master quite simply.

I will take a look.

Unfortunately, it won't be quite simple as I have to modify subscribed events depending on which subdriver is loaded if we are to avoid unnecessary event calls.

Main serialIO driver is subscribed to EVENT_CONNECTION_CHANGED and I need to respond to EVENT_CONFIG_SERIAL_CHANGE.

@pkendall64
Copy link
Collaborator

Main serialIO driver is subscribed to EVENT_CONNECTION_CHANGED and I need to respond to EVENT_CONFIG_SERIAL_CHANGE.

I'm happy for you no add another subscription to the serial driver. The subscriptions are bits that can be ORed together.
So the serial driver would have

    .subscribe = EVENT_CONNECTION_CHANGED | EVENT_CONFIG_SERIAL_CHANGE

I don't think it will be a big deal responding to the both events as they are both very infrequent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants