Skip to content

Improve tests: ergonomics, unification, filling-gaps, etc. #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Sep 23, 2019
Merged

Improve tests: ergonomics, unification, filling-gaps, etc. #118

merged 14 commits into from
Sep 23, 2019

Conversation

regexident
Copy link
Collaborator

@regexident regexident commented Sep 23, 2019 •
edited
Loading

This PR improves the unit testing ergonomics and tries to clean things up structurally.

@regexident
Removed test helper functions in favor of explicit literals. K.I.S.S.
46c67de
@regexident
Increased size of too-small arrays in performance measurements
7f90497
@regexident
Added benchmark measurements to VectorTests
5aa73ce
@regexident
Added // MARK: - … to unit tests to improve ergonomics in Xcode’s m…
8468bd3 
…inimaps
@regexident
Added missing tests for dot product of Vector<Scalar>
368e655
@regexident
Moved functions with Scalar as lhs into separate ScalarTests file
ea85687
@regexident
Moved func test_mul_empty_float and added corresponding `func test_…
d4c4111 
…mul_empty_double`
@regexident
Added missing // MARK: - … to implementation files
2de109f
@regexident
Renamed func test_grid to func test_init_arrayLiteral
8f639c2
@regexident
Changed use of (0..<n).map { Scalar($0) } to `(1…n).map { Scalar($0…
cb734b1 
…) }` avoiding divide-by-zero
@regexident
Moved pow() into ‘Arithmetic.swift’
b12f110
@regexident
Moved exp()/exp2() into ‘Arithmetic.swift’
c20ecd7
@regexident
Resolved FIXMEs, adding missing unit tests
78a977d
@regexident
Fixed missing target memberships of ‘ScalarTests.swift’ file for non-…
6b1af4c 
…macOS platforms
@regexident regexident merged commit d3f7a50 into master Sep 23, 2019
@regexident regexident deleted the improve-tests branch September 23, 2019 20:58
@regexident regexident mentioned this pull request Nov 2, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@regexident