QuotaExceededError: Update to a DOMException derived interface #52556
Conversation
This change introduces a new QuotaExceededError class to update the existing QuotaExceededError so services can return `quota` and `requested` properties as needed. Implemented behind RuntimeEnabledFlag `QuotaExceededErrorUpdate`. Changes to update services throwing QuotaExceededError to use the new class will be made in following changes (except for IDB which triggered failures with this change). Proposal: whatwg/webidl#1465 Chromestatus: https://chromestatus.com/feature/6194847180128256 Bug: 406162261 Change-Id: I68e91e15724e64c0995365ee63d4abe627fe06d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6516473 Reviewed-by: Domenic Denicola <domenic@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Reviewed-by: Joe Mason <joenotcharles@google.com> Cr-Commit-Position: refs/heads/main@{#1460403}
There was a problem hiding this comment.
With my WPT Core Team hat on, this change to testharness.js absolutely cannot land until whatwg/webidl#1465 does.
|
[notice] A new release of pip is available: 25.0.1 -> 25.1.1
The above exception was the direct cause of the following exception: |
|
The failure on resources/tests is due to failure in downloading firefox. @DanielRyanSmith, can you help admin merge? Thanks! |
I saw your comment and merged @WeizhongX - missing @gsnedders ' comment. It looks like we should revert here. |
That's unfortunate. I see Sam put a request to change on this PR, but that will not block admin merge? |
Admin merging allows overriding of all restrictions, so no, a negative review doesn't block it. |
|
As this is an exported PR, the change already lands in chromium. Is that not a problem? Also gsnedders@ got a chance to comment on this change because some check did not pass. In most cases such change should just land? |
…ce (#52556)" This reverts commit 2f96fa1. See whatwg/webidl#1465.
This change introduces a new QuotaExceededError class to
update the existing QuotaExceededError so services can return
quotaandrequestedproperties as needed. Implemented behindRuntimeEnabledFlag
QuotaExceededErrorUpdate. Changes toupdate services throwing QuotaExceededError to use the new class
will be made in following changes (except for IDB which triggered
failures with this change).
Proposal: whatwg/webidl#1465
Chromestatus: https://chromestatus.com/feature/6194847180128256
Bug: 406162261
Change-Id: I68e91e15724e64c0995365ee63d4abe627fe06d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6516473
Reviewed-by: Domenic Denicola <domenic@chromium.org>
Commit-Queue: Ayu Ishii <ayui@chromium.org>
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Joe Mason <joenotcharles@google.com>
Cr-Commit-Position: refs/heads/main@{#1460403}