Upgrade QuotaExceededError to a DOMException derived interface #1465
+93
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenic
added
the
do not merge yet
This was referenced Jan 27, 2025
domenic
added a commit
to webmachinelearning/writing-assistance-apis
that referenced
this pull request
Mar 4, 2025
Closes #5. Closes #31 by obsoleting it. Depends on whatwg/webidl#1465.
This was referenced Mar 4, 2025
Merged
domenic
added a commit
to webmachinelearning/writing-assistance-apis
that referenced
this pull request
Mar 5, 2025
Closes #5. Closes #31 by obsoleting it. Depends on whatwg/webidl#1465.
This was referenced Mar 5, 2025
domenic
added a commit
to webmachinelearning/writing-assistance-apis
that referenced
this pull request
Mar 7, 2025
Closes #5. Obsoletes #31. Depends on whatwg/webidl#1465.
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
May 14, 2025
This change introduces a new QuotaExceededError class to update the existing QuotaExceededError so services can return `quota` and `requested` properties as needed. Implemented behind RuntimeEnabledFlag `QuotaExceededErrorUpdate`. Changes to update services throwing QuotaExceededError to use the new class will be made in following changes (except for IDB which triggered failures with this change). Proposal: whatwg/webidl#1465 Chromestatus: https://chromestatus.com/feature/6194847180128256 Bug: 406162261 Change-Id: I68e91e15724e64c0995365ee63d4abe627fe06d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6516473 Reviewed-by: Domenic Denicola <domenic@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Reviewed-by: Joe Mason <joenotcharles@google.com> Cr-Commit-Position: refs/heads/main@{#1460403}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
May 14, 2025
This change introduces a new QuotaExceededError class to update the existing QuotaExceededError so services can return `quota` and `requested` properties as needed. Implemented behind RuntimeEnabledFlag `QuotaExceededErrorUpdate`. Changes to update services throwing QuotaExceededError to use the new class will be made in following changes (except for IDB which triggered failures with this change). Proposal: whatwg/webidl#1465 Chromestatus: https://chromestatus.com/feature/6194847180128256 Bug: 406162261 Change-Id: I68e91e15724e64c0995365ee63d4abe627fe06d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6516473 Reviewed-by: Domenic Denicola <domenic@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Reviewed-by: Joe Mason <joenotcharles@google.com> Cr-Commit-Position: refs/heads/main@{#1460403}
DanielRyanSmith
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
May 15, 2025
This change introduces a new QuotaExceededError class to update the existing QuotaExceededError so services can return `quota` and `requested` properties as needed. Implemented behind RuntimeEnabledFlag `QuotaExceededErrorUpdate`. Changes to update services throwing QuotaExceededError to use the new class will be made in following changes (except for IDB which triggered failures with this change). Proposal: whatwg/webidl#1465 Chromestatus: https://chromestatus.com/feature/6194847180128256 Bug: 406162261 Change-Id: I68e91e15724e64c0995365ee63d4abe627fe06d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6516473 Reviewed-by: Domenic Denicola <domenic@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Reviewed-by: Joe Mason <joenotcharles@google.com> Cr-Commit-Position: refs/heads/main@{#1460403} Co-authored-by: Ayu Ishii <ayui@chromium.org>
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
May 21, 2025
This change updates services that use QuotaExceededError to use the new DOMException derived QuotaExceededError class when the flag is enabled. I've not been allowed to update external wpts until the webidl spec has been updated[0][1], so this change only updates tests for Chrome only wpts, and otherwise updates expectations for the external ones. External wpts will be updated when the webidl spec is merged and I am allowed to update the external wpts (as seen in chained CL). [0] Spec PR: whatwg/webidl#1465 [1] Discussion: web-platform-tests/wpt#52571 (comment) Bug: 406162261 Change-Id: Ie45d6095a3e4c21e21a35d2519d268580b8bc36b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6538066 Commit-Queue: Ayu Ishii <ayui@chromium.org> Reviewed-by: Daseul Lee <dslee@chromium.org> Cr-Commit-Position: refs/heads/main@{#1463139}
6 tasks
lando-prod-mozilla bot
pushed a commit
to mozilla-firefox/firefox
that referenced
this pull request
May 22, 2025
…tion derived interface, Automatic update from web-platform-tests QuotaExceededError: Update to a DOMException derived interface (#52556) This change introduces a new QuotaExceededError class to update the existing QuotaExceededError so services can return `quota` and `requested` properties as needed. Implemented behind RuntimeEnabledFlag `QuotaExceededErrorUpdate`. Changes to update services throwing QuotaExceededError to use the new class will be made in following changes (except for IDB which triggered failures with this change). Proposal: whatwg/webidl#1465 Chromestatus: https://chromestatus.com/feature/6194847180128256 Bug: 406162261 Change-Id: I68e91e15724e64c0995365ee63d4abe627fe06d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6516473 Reviewed-by: Domenic Denicola <domenic@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Reviewed-by: Joe Mason <joenotcharles@google.com> Cr-Commit-Position: refs/heads/main@{#1460403} Co-authored-by: Ayu Ishii <ayui@chromium.org> -- wpt-commits: 16a71c4282b0379f639051c0a3f98f3fcdaa2149 wpt-pr: 52556 Differential Revision: https://phabricator.services.mozilla.com/D250632
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
May 22, 2025
…tion derived interface, Automatic update from web-platform-tests QuotaExceededError: Update to a DOMException derived interface (#52556) This change introduces a new QuotaExceededError class to update the existing QuotaExceededError so services can return `quota` and `requested` properties as needed. Implemented behind RuntimeEnabledFlag `QuotaExceededErrorUpdate`. Changes to update services throwing QuotaExceededError to use the new class will be made in following changes (except for IDB which triggered failures with this change). Proposal: whatwg/webidl#1465 Chromestatus: https://chromestatus.com/feature/6194847180128256 Bug: 406162261 Change-Id: I68e91e15724e64c0995365ee63d4abe627fe06d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6516473 Reviewed-by: Domenic Denicola <domenic@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Reviewed-by: Joe Mason <joenotcharles@google.com> Cr-Commit-Position: refs/heads/main@{#1460403} Co-authored-by: Ayu Ishii <ayui@chromium.org> -- wpt-commits: 16a71c4282b0379f639051c0a3f98f3fcdaa2149 wpt-pr: 52556 Differential Revision: https://phabricator.services.mozilla.com/D250632
i3roly
pushed a commit
to i3roly/firefox-dynasty
that referenced
this pull request
May 24, 2025
…tion derived interface, Automatic update from web-platform-tests QuotaExceededError: Update to a DOMException derived interface (#52556) This change introduces a new QuotaExceededError class to update the existing QuotaExceededError so services can return `quota` and `requested` properties as needed. Implemented behind RuntimeEnabledFlag `QuotaExceededErrorUpdate`. Changes to update services throwing QuotaExceededError to use the new class will be made in following changes (except for IDB which triggered failures with this change). Proposal: whatwg/webidl#1465 Chromestatus: https://chromestatus.com/feature/6194847180128256 Bug: 406162261 Change-Id: I68e91e15724e64c0995365ee63d4abe627fe06d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6516473 Reviewed-by: Domenic Denicola <domenic@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Reviewed-by: Joe Mason <joenotcharles@google.com> Cr-Commit-Position: refs/heads/main@{#1460403} Co-authored-by: Ayu Ishii <ayui@chromium.org> -- wpt-commits: 16a71c4282b0379f639051c0a3f98f3fcdaa2149 wpt-pr: 52556 Differential Revision: https://phabricator.services.mozilla.com/D250632
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
May 27, 2025
This info will be used for QuotaExceededError.requested and QuotaExceededError.quota in a follow-up CL. Spec: whatwg/webidl#1465 Bug: 416303646, 406162261 Change-Id: Id1d414722d2f53de0a566e8b453acdd97f501714 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6568411 Reviewed-by: Mike Wasserman <msw@chromium.org> Commit-Queue: Daseul Lee <dslee@chromium.org> Reviewed-by: Emily Stark <estark@chromium.org> Reviewed-by: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/main@{#1466096}
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
May 28, 2025
…tion derived interface, Automatic update from web-platform-tests QuotaExceededError: Update to a DOMException derived interface (#52556) This change introduces a new QuotaExceededError class to update the existing QuotaExceededError so services can return `quota` and `requested` properties as needed. Implemented behind RuntimeEnabledFlag `QuotaExceededErrorUpdate`. Changes to update services throwing QuotaExceededError to use the new class will be made in following changes (except for IDB which triggered failures with this change). Proposal: whatwg/webidl#1465 Chromestatus: https://chromestatus.com/feature/6194847180128256 Bug: 406162261 Change-Id: I68e91e15724e64c0995365ee63d4abe627fe06d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6516473 Reviewed-by: Domenic Denicola <domenicchromium.org> Commit-Queue: Ayu Ishii <ayuichromium.org> Reviewed-by: Joey Arhar <jarharchromium.org> Reviewed-by: Joe Mason <joenotcharlesgoogle.com> Cr-Commit-Position: refs/heads/main{#1460403} Co-authored-by: Ayu Ishii <ayuichromium.org> -- wpt-commits: 16a71c4282b0379f639051c0a3f98f3fcdaa2149 wpt-pr: 52556 Differential Revision: https://phabricator.services.mozilla.com/D250632 UltraBlame original commit: 869cbd71034aec8dfdce6d5342adbfc5d8dbf8e6
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
May 28, 2025
…tion derived interface, Automatic update from web-platform-tests QuotaExceededError: Update to a DOMException derived interface (#52556) This change introduces a new QuotaExceededError class to update the existing QuotaExceededError so services can return `quota` and `requested` properties as needed. Implemented behind RuntimeEnabledFlag `QuotaExceededErrorUpdate`. Changes to update services throwing QuotaExceededError to use the new class will be made in following changes (except for IDB which triggered failures with this change). Proposal: whatwg/webidl#1465 Chromestatus: https://chromestatus.com/feature/6194847180128256 Bug: 406162261 Change-Id: I68e91e15724e64c0995365ee63d4abe627fe06d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6516473 Reviewed-by: Domenic Denicola <domenicchromium.org> Commit-Queue: Ayu Ishii <ayuichromium.org> Reviewed-by: Joey Arhar <jarharchromium.org> Reviewed-by: Joe Mason <joenotcharlesgoogle.com> Cr-Commit-Position: refs/heads/main{#1460403} Co-authored-by: Ayu Ishii <ayuichromium.org> -- wpt-commits: 16a71c4282b0379f639051c0a3f98f3fcdaa2149 wpt-pr: 52556 Differential Revision: https://phabricator.services.mozilla.com/D250632 UltraBlame original commit: 869cbd71034aec8dfdce6d5342adbfc5d8dbf8e6
|
This change seems to have stuck with Chrome 138 stable, so this is ready for review. I will work on filing other browser bugs, PRs to other specs, etc. |
domenic
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 8, 2025
…ce (#52556)" This reverts commit 2f96fa1. See whatwg/webidl#1465.
domenic
added a commit
to whatwg/fs
that referenced
this pull request
Jul 8, 2025
QuotaExceededError is graduating from being a DOMException name into a new error class, in whatwg/webidl#1465. Update creation sites to reflect this. For now, the quota and requested properties are left at their default (null). Future work could include setting them in an informative fashion.
5 tasks
domenic
added a commit
to whatwg/html
that referenced
this pull request
Jul 8, 2025
…a new error class, in whatwg/webidl#1465. Update creation sites to reflect this. For now, the quota and requested properties are left at their default (null). Future work could include setting them in an informative fashion.
domenic
added a commit
to whatwg/html
that referenced
this pull request
Jul 8, 2025
QuotaExceededError is graduating from being a DOMException name into a new error class, in whatwg/webidl#1465. Update creation sites to reflect this. For now, the quota and requested properties are left at their default (null). Future work could include setting them in an informative fashion.
5 tasks
domenic
added a commit
to webmachinelearning/writing-assistance-apis
that referenced
this pull request
Jul 8, 2025
Once whatwg/webidl#1465 is merged, we can reference Web IDL directly, instead of the pull request preview.
domenic
added a commit
to domenic/handwriting-recognition
that referenced
this pull request
Jul 8, 2025
QuotaExceededError is graduating from being a DOMException name into a new error class, in whatwg/webidl#1465. Update creation sites to reflect this. For now, the quota and requested properties are left at their default (null). Future work could include setting them in an informative fashion.
domenic
added a commit
to domenic/handwriting-recognition
that referenced
this pull request
Jul 8, 2025
QuotaExceededError is graduating from being a DOMException name into a new error class, in whatwg/webidl#1465. Update creation sites to reflect this. For now, the quota and requested properties are left at their default (null). Future work could include setting them in an informative fashion.
domenic
added a commit
to w3c/IndexedDB
that referenced
this pull request
Jul 8, 2025
QuotaExceededError is graduating from being a DOMException name into a new error class, in whatwg/webidl#1465. Update creation sites to reflect this. For now, the quota and requested properties are left at their default (null). Future work could include setting them in an informative fashion.
2 tasks
domenic
added a commit
to domenic/ServiceWorker
that referenced
this pull request
Jul 8, 2025
QuotaExceededError is graduating from being a DOMException name into a new error class, in whatwg/webidl#1465. Update creation sites to reflect this. For now, the quota and requested properties are left at their default (null). Future work could include setting them in an informative fashion.
domenic
added a commit
to domenic/webcodecs
that referenced
this pull request
Jul 8, 2025
QuotaExceededError is graduating from being a DOMException name into a new error class, in whatwg/webidl#1465. Update creation sites to reflect this. For now, the quota and requested properties are left at their default (null). Future work could include setting them in an informative fashion.
domenic
removed
the
do not merge yet
|
Is there a reason for the change to I had originally read the OP as suggesting this would only be different when manually doing |
|
The reason isn't a strong one, but since |
Djuffin
pushed a commit
to w3c/webcodecs
that referenced
this pull request
Jul 8, 2025
QuotaExceededError is graduating from being a DOMException name into a new error class, in whatwg/webidl#1465. Update creation sites to reflect this. For now, the quota and requested properties are left at their default (null). Future work could include setting them in an informative fashion.
wacky6
pushed a commit
to WICG/handwriting-recognition
that referenced
this pull request
Jul 9, 2025
QuotaExceededError is graduating from being a DOMException name into a new error class, in whatwg/webidl#1465. Update creation sites to reflect this. For now, the quota and requested properties are left at their default (null). Future work could include setting them in an informative fashion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proposal
The web platform benefits from having a type of exception that tells you about when you exceed quotas. In some cases, it can be helpful to tell you what the quota was, and by how much you exceeded it. webmachinelearning/writing-assistance-apis#5 gives one specific use case.
The web platform already has an exception type for telling you when you exceed quotas: it is
DOMException, with the specificnameproperty set to"QuotaExceededError". However, this does not allow carrying additional information.This PR proposes removing
"QuotaExceededError"from the list of built-inDOMExceptionnames, and instead creates a class namedQuotaExceededErrorthat derives fromDOMExceptionand has the additional optional propertiesquotaandrequested. We propose that all instances of specs that throw"QuotaExceededError"DOMExceptions get upgraded to instead throwQuotaExceededErrors. For now, such specs would leave thequotaandrequestedproperties at their default value ofnull, but they could eventually upgrade to include that data, if it's useful for their use case (and isn't, e.g., a privacy leak).Alternative considered
The most promising alternative considered was to add a new class that sits alongside
"QuotaExceededError"DOMException. Maybe it would be calledQuotaExceededErrorWithDetails, or maybe we could even call itQuotaExceededErrordespite the confusion this might cause. But it would be undesirable for the web platform to have two types of quota-exceeded errors, with different APIs giving different ones. So, because we believe the compat implications are not too bad, we're interested in trying this upgrade route instead.There are other possibilities, such as using custom bindings to sometimes add properties to base
"QuotaExceededError"DOMExceptioninstances, or trying to add some generic additional information capability to the baseDOMExceptionclass. However, these don't fit well with how classes work on the web platform, with getters providing predefined data on a per-class basis. They would be hacky to maintain both in specs and implementations, and a bit surprising for web developers as well due to the mismatch with other web platform classes.Compat considerations
The following coding patterns will work unchanged if we upgrade all
"QuotaExceededError"DOMExceptions toQuotaExceedErrors:ex instanceof DOMExceptionex.name === "QuotaExceededError"DOMException.QUOTA_EXCEEDED_ERR === 22(new DOMException("message", "QuotaExceededError")).name === "QuotaExceededError"The following coding patterns will start giving different answers:
ex.constructor === DOMExceptionex.constructor.name === "DOMException"(new DOMException("message", "QuotaExceededError")).code === DOMException.QUOTA_EXCEEDED_ERR(now it will be0)We believe that these coding patterns are quite rare. See, for example, these GitHub search results, which show only a couple instances of
.constructortesting (repeated in a few forks).The tests like
ex instanceof DOMExceptionandex.name === "QuotaExceededError"are much more common, and commonly seen in documentation. (See, e.g., these GitHub search results.)Furthermore, since quotas being exceeded is a relatively rare thing to happen on the web, we suspect that the combination of these rare coding patterns with this rare type of
DOMExceptionmeans the impacted number of page views will be extremely small.We could add some use counters for these coding patterns, but they would be sloppy. In particular, we could count cases where
.constructoris accessed, but not cases where it is compared toDOMException, so any count would be inflated by generic constructor-accessing code, and not really tell us much about the problematic coding pattern.Nevertheless, there's definitely some compat risk. So the best rollout plan here would probably be for Chromium to cautiously take the lead and report back if it sticks, before necessarily merging changes to all the relevant specs.
Proposed commit message:
Upgrade QuotaExceededError to a DOMException derived interface
Closes #1463.
Labeling "do not merge yet" as we should also create PRs for these specs, and we probably don't want to merge until we see if this sticks in Chromium:
The following cases did not need PRs because they were using inaccurate spec text (just
QuotaExceededError, instead of"QuotaExceededError"DOMException), which has now become correct by accident:(See WHATWG Working Mode: Changes for more details.)
Preview | Diff