feat: update docker api #254
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luboszima
commented
Jun 26, 2025
Comment on lines
+104
to
+111
| if sort_dir not in ['ASC', 'DESC']: | ||
| raise ValueError("sort_dir must be either 'ASC' or 'DESC'") | ||
|
|
||
| if sort_by not in ['time', 'level', 'user', 'event']: | ||
| raise ValueError("sort_by must be one of: 'time', 'level', 'user', 'event'") | ||
|
|
||
| if loglevel not in ['', 'information', 'warning', 'error']: | ||
| raise ValueError("loglevel must be one of: '', 'information', 'warning', 'error'") |
There was a problem hiding this comment.
I am adding validation for params. I think it will be good to add similar validation to other APIs.
FYI: @N4S4 @joeperpetua
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal is to update docker_api.py with for me all known docker related APIs.