Skip to content

Ugrade k8s version to 1.33 #2054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2025
Merged

Ugrade k8s version to 1.33 #2054

merged 1 commit into from
Jun 23, 2025

Conversation

za
Copy link
Contributor

@za za commented Jun 20, 2025 •
edited
Loading

Issue #1984

Checklist:

  • All the contributions made are solely the work of me and my co-authors
  • I tested the changes in this PR (if applicable)
  • I added unit tests to ensure my change works (when change in Java or on front-end code)
  • I added UI tests to ensure my UI changes work (when change in the overall UI, not needed if just adding a challenge)
  • The PR passes pre-commit hooks and automated tests

@za za requested review from commjoen and bendehaan as code owners June 20, 2025 06:07
@za
Copy link
Contributor Author

za commented Jun 20, 2025

AWS terratest result:

➜  aws git:(issue-1984-upgrade-k8s-1.33) ✗ go test -timeout 999999s 
...
TestTerraformWrongSecretsAWS 2025-06-20T15:39:24+07:00 logger.go:67: Destroy complete! Resources: 83 destroyed.
TestTerraformWrongSecretsAWS 2025-06-20T15:39:24+07:00 logger.go:67: 
PASS
ok      wrongsecrets    1771.351s

cc: @commjoen

@commjoen
Copy link
Collaborator

Now only GCP and Azure to go!

@za
Copy link
Contributor Author

za commented Jun 23, 2025

Azure result:

$  go test -timeout 999999s
...
TestTerraformWrongSecretsAzure 2025-06-23T12:55:23+07:00 logger.go:67: Destroy complete! Resources: 17 destroyed.
TestTerraformWrongSecretsAzure 2025-06-23T12:55:23+07:00 logger.go:67: 
PASS
ok      wrongsecrets    1308.075s

@za
Copy link
Contributor Author

za commented Jun 23, 2025 •
edited
Loading

Finally, GCP test result:

➜  gcp git:(issue-1984-upgrade-k8s-1.33) ✗ go test -timeout 999999s 

TestTerraformWrongSecretsGCP 2025-06-23T14:24:30+07:00 logger.go:67: Destroy complete! Resources: 21 destroyed.
TestTerraformWrongSecretsGCP 2025-06-23T14:24:30+07:00 logger.go:67: 
PASS
ok      wrongsecrets    1244.011s

@commjoen we're good to go.

PS: I think there's a hardcoded project_id somewhere in gcp/ folder. I'll create a separate issue/PR for this.

@commjoen commjoen merged commit 3908fff into OWASP:master Jun 23, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@commjoen commjoen Awaiting requested review from commjoen commjoen is a code owner

@bendehaan bendehaan Awaiting requested review from bendehaan bendehaan is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@za @commjoen