Fix Lim Launched RC medium half loops from clipping in to eachother #23085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mixiate
force-pushed
the
lim-launched-roller-coaster-medium-loop-clipping
branch
from
01a11df to
c7bf43b
Compare
|
@SpartanFrederic104 this one too |
mixiate
force-pushed
the
lim-launched-roller-coaster-medium-loop-clipping
branch
2 times, most recently
from
c7bf43b to
7aa768b
Compare
|
Finally got around to testing. There is still some minor Z-fighting like with the other PR I tested but again that's more an issue with the trains themselves (yes, all three LIM coaster train types). In fact I can even see the LIM coaster trains Z-fighting on straight vertical track. I am using the software drawing engine for this, so there might be some different spots for Z-fighting on OpenGL. |
distribution/changelog.txt
Outdated
| @@ -16,6 +16,7 @@ | |||
| - Fix: [#23044] "remove_unused_objects" command causes blank peep names. | |||
| - Fix: [#23048] Map generator allows map sizes out of range through text input. | |||
| - Fix: [#23058] [Plugin] Changing window colours doesn’t trigger the window to be fully redrawn. | |||
| - Fix: [#23085] LIM Launched Roller Coaster medium half loops clip in to eachother. | |||
There was a problem hiding this comment.
Should be:
- Fix: [#23085] LIM Launched Roller Coaster medium half loops clip into each other when built back-to-back.
There was a problem hiding this comment.
Thanks, i've changed it to this.
mixiate
force-pushed
the
lim-launched-roller-coaster-medium-loop-clipping
branch
from
7aa768b to
e94ddba
Compare
Gymnasiast
approved these changes
Oct 30, 2024
janisozaur
added a commit
that referenced
this pull request
Nov 3, 2024
- Feature: [#20810] New ride type: LSM Launched Roller Coaster. - Improved: [#22937] Add banked sloped turns and many other pieces to the Corkscrew, Hypercoaster and Lay-down Roller Coaster. - Improved: [#22967] Add medium and large half loops to the Wooden and Classic Wooden Roller Coasters. - Improved: [#23010] Make AppImage compatible with Ubuntu 22.04 and Debian Bookworm again. - Change: [#20810] Giga Coaster boosters and launched lift hill track pieces are now locked behind cheats. - Fix: [#21221] Trains use unbanked sprites on flat to gentle diagonal banked track pieces. - Fix: [#22615] Crash when drawing Space Rings with an invalid ride entry. - Fix: [#22633] Crash when drawing loading screen with an outdated g2.dat. - Fix: [#22908] Crash when passing through a door from an invalid wall type. - Fix: [#22918] Zooming with keyboard moves the view off centre. - Fix: [#22920] Crash when sacking a staff member. - Fix: [#22921] Wooden RollerCoaster flat to steep railings appear in front of track in front of them. - Fix: [#22962] Fuzzy horizontal-to-vertical line transitions in charts. - Fix: [#23009] Scenarios from RCT Classic (.sea files) are not included in the scenario index. - Fix: [#23015] Crash when loading a save game when the construction window is still open. - Fix: [#23018] Crash when loading a new game when the construction window is still open. - Fix: [#23023] Large scenery clearance height interpreted as negative when greater than 127. - Fix: [#23044] "remove_unused_objects" command causes blank peep names. - Fix: [#23048] Map generator allows map sizes out of range through text input. - Fix: [#23058] [Plugin] Changing window colours doesn’t trigger the window to be fully redrawn. - Fix: [#23085] LIM Launched Roller Coaster medium half loops clip into each other when built back-to-back.
tupaschoal
pushed a commit
to tupaschoal/OpenRCT2
that referenced
this pull request
Nov 12, 2024
- Feature: [OpenRCT2#20810] New ride type: LSM Launched Roller Coaster. - Improved: [OpenRCT2#22937] Add banked sloped turns and many other pieces to the Corkscrew, Hypercoaster and Lay-down Roller Coaster. - Improved: [OpenRCT2#22967] Add medium and large half loops to the Wooden and Classic Wooden Roller Coasters. - Improved: [OpenRCT2#23010] Make AppImage compatible with Ubuntu 22.04 and Debian Bookworm again. - Change: [OpenRCT2#20810] Giga Coaster boosters and launched lift hill track pieces are now locked behind cheats. - Fix: [OpenRCT2#21221] Trains use unbanked sprites on flat to gentle diagonal banked track pieces. - Fix: [OpenRCT2#22615] Crash when drawing Space Rings with an invalid ride entry. - Fix: [OpenRCT2#22633] Crash when drawing loading screen with an outdated g2.dat. - Fix: [OpenRCT2#22908] Crash when passing through a door from an invalid wall type. - Fix: [OpenRCT2#22918] Zooming with keyboard moves the view off centre. - Fix: [OpenRCT2#22920] Crash when sacking a staff member. - Fix: [OpenRCT2#22921] Wooden RollerCoaster flat to steep railings appear in front of track in front of them. - Fix: [OpenRCT2#22962] Fuzzy horizontal-to-vertical line transitions in charts. - Fix: [OpenRCT2#23009] Scenarios from RCT Classic (.sea files) are not included in the scenario index. - Fix: [OpenRCT2#23015] Crash when loading a save game when the construction window is still open. - Fix: [OpenRCT2#23018] Crash when loading a new game when the construction window is still open. - Fix: [OpenRCT2#23023] Large scenery clearance height interpreted as negative when greater than 127. - Fix: [OpenRCT2#23044] "remove_unused_objects" command causes blank peep names. - Fix: [OpenRCT2#23048] Map generator allows map sizes out of range through text input. - Fix: [OpenRCT2#23058] [Plugin] Changing window colours doesn’t trigger the window to be fully redrawn. - Fix: [OpenRCT2#23085] LIM Launched Roller Coaster medium half loops clip into each other when built back-to-back.
foodisgoodyesiam
added a commit
to foodisgoodyesiam/OpenRCT2-sven
that referenced
this pull request
Nov 13, 2024
Release v0.4.16 - Feature: [OpenRCT2#20810] New ride type: LSM Launched Roller Coaster. - Improved: [OpenRCT2#22937] Add banked sloped turns and many other pieces to the Corkscrew, Hypercoaster and Lay-down Roller Coaster. - Improved: [OpenRCT2#22967] Add medium and large half loops to the Wooden and Classic Wooden Roller Coasters. - Improved: [OpenRCT2#23010] Make AppImage compatible with Ubuntu 22.04 and Debian Bookworm again. - Change: [OpenRCT2#20810] Giga Coaster boosters and launched lift hill track pieces are now locked behind cheats. - Fix: [OpenRCT2#21221] Trains use unbanked sprites on flat to gentle diagonal banked track pieces. - Fix: [OpenRCT2#22615] Crash when drawing Space Rings with an invalid ride entry. - Fix: [OpenRCT2#22633] Crash when drawing loading screen with an outdated g2.dat. - Fix: [OpenRCT2#22908] Crash when passing through a door from an invalid wall type. - Fix: [OpenRCT2#22918] Zooming with keyboard moves the view off centre. - Fix: [OpenRCT2#22920] Crash when sacking a staff member. - Fix: [OpenRCT2#22921] Wooden RollerCoaster flat to steep railings appear in front of track in front of them. - Fix: [OpenRCT2#22962] Fuzzy horizontal-to-vertical line transitions in charts. - Fix: [OpenRCT2#23009] Scenarios from RCT Classic (.sea files) are not included in the scenario index. - Fix: [OpenRCT2#23015] Crash when loading a save game when the construction window is still open. - Fix: [OpenRCT2#23018] Crash when loading a new game when the construction window is still open. - Fix: [OpenRCT2#23023] Large scenery clearance height interpreted as negative when greater than 127. - Fix: [OpenRCT2#23044] "remove_unused_objects" command causes blank peep names. - Fix: [OpenRCT2#23048] Map generator allows map sizes out of range through text input. - Fix: [OpenRCT2#23058] [Plugin] Changing window colours doesn’t trigger the window to be fully redrawn. - Fix: [OpenRCT2#23085] LIM Launched Roller Coaster medium half loops clip into each other when built back-to-back.
CorySanin
added a commit
to CorySanin/OpenRCT2
that referenced
this pull request
Feb 3, 2025
Release v0.4.16 - Feature: [OpenRCT2#20810] New ride type: LSM Launched Roller Coaster. - Improved: [OpenRCT2#22937] Add banked sloped turns and many other pieces to the Corkscrew, Hypercoaster and Lay-down Roller Coaster. - Improved: [OpenRCT2#22967] Add medium and large half loops to the Wooden and Classic Wooden Roller Coasters. - Improved: [OpenRCT2#23010] Make AppImage compatible with Ubuntu 22.04 and Debian Bookworm again. - Change: [OpenRCT2#20810] Giga Coaster boosters and launched lift hill track pieces are now locked behind cheats. - Fix: [OpenRCT2#21221] Trains use unbanked sprites on flat to gentle diagonal banked track pieces. - Fix: [OpenRCT2#22615] Crash when drawing Space Rings with an invalid ride entry. - Fix: [OpenRCT2#22633] Crash when drawing loading screen with an outdated g2.dat. - Fix: [OpenRCT2#22908] Crash when passing through a door from an invalid wall type. - Fix: [OpenRCT2#22918] Zooming with keyboard moves the view off centre. - Fix: [OpenRCT2#22920] Crash when sacking a staff member. - Fix: [OpenRCT2#22921] Wooden RollerCoaster flat to steep railings appear in front of track in front of them. - Fix: [OpenRCT2#22962] Fuzzy horizontal-to-vertical line transitions in charts. - Fix: [OpenRCT2#23009] Scenarios from RCT Classic (.sea files) are not included in the scenario index. - Fix: [OpenRCT2#23015] Crash when loading a save game when the construction window is still open. - Fix: [OpenRCT2#23018] Crash when loading a new game when the construction window is still open. - Fix: [OpenRCT2#23023] Large scenery clearance height interpreted as negative when greater than 127. - Fix: [OpenRCT2#23044] "remove_unused_objects" command causes blank peep names. - Fix: [OpenRCT2#23048] Map generator allows map sizes out of range through text input. - Fix: [OpenRCT2#23058] [Plugin] Changing window colours doesn’t trigger the window to be fully redrawn. - Fix: [OpenRCT2#23085] LIM Launched Roller Coaster medium half loops clip into each other when built back-to-back.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the lim launched rollercoaster medium half loops from clipping in to eachother. In order for the LIM train to go through these loops correctly I have changed the draw order 9 bounding boxes for pitch up 105 and 120. This brings them more in line with the bounding boxes of other trains/vehicles.
before.mp4
after.mp4