Refactor map generator and move it into its own namespace #23509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronVanGeffen
force-pushed
the
mapgen-refactor
branch
from
17c4138 to
de4612a
Compare
AaronVanGeffen
force-pushed
the
mapgen-refactor
branch
from
c43a841 to
dffa3fa
Compare
AaronVanGeffen
force-pushed
the
mapgen-refactor
branch
from
dffa3fa to
4c5bf54
Compare
AaronVanGeffen
force-pushed
the
mapgen-refactor
branch
from
b3b4b42 to
d997845
Compare
AaronVanGeffen
force-pushed
the
mapgen-refactor
branch
from
83c44e3 to
a573356
Compare
AaronVanGeffen
changed the title
AaronVanGeffen
changed the title
tupaschoal
approved these changes
Dec 31, 2024
There was a problem hiding this comment.
I haven't tested it, but code-wise it seems to be fine, as most commits only move code around. Just need to make sure d997845 is doing as before and it should be good to go.
That's currently only used by the Simplex Noise generator, fwiw. It seems to work fine on my end. I think this does need to be tested by someone else before this is merged, though. |
AaronVanGeffen
force-pushed
the
mapgen-refactor
branch
from
a573356 to
a809f48
Compare
AaronVanGeffen
force-pushed
the
mapgen-refactor
branch
3 times, most recently
from
7f099c8 to
167daaa
Compare
janisozaur
added a commit
that referenced
this pull request
Jan 5, 2025
- Improved: [#23200] Add banked sloped turns and many other pieces to the Stand-Up and Classic Stand-Up Roller Coaster. - Improved: [#23260] Add diagonal (block) brakes to LSM Launched Roller Coaster. - Improved: [#23350] Increased the maximum width of the ride graph window. - Improved: [#23404] Folders are now paired with an icon in the load/save window. - Improved: [#23405] Filenames can now be input directly into the file browser (load/save) window. - Improved: [#23431] Opaque water and Corkscrew Roller Coaster boosters now show up if RCT1 isn’t linked. - Improved: [objects#369] Updated Russian translation. - Change: [#23413] The max number of park entrance objects has been raised to 255. - Fix: [#1122] Trains spawned on a cable lift hill will fall down and crash (original bug). - Fix: [#19780] Guest screams loop on long drops. - Fix: [#22742, #22793] In game console does not handle format tokens properly. - Fix: [#23135] Map generator tree placement has noticable patterns. - Fix: [#23286] Currency formatted incorrectly in the in game console. - Fix: [#23348] Console set commands don't print output properly. - Fix: [#23376] Peeps with balloons, hats and umbrellas may leave artifacts on screen. - Fix: [#23486] Object selection minimum requirements can be bypassed with close window hotkey. - Fix: [#23496] Newly spawned vehicles are invisible when spawned while the game is paused. - Fix: [#23509] Map generator window reverts to flatland after selecting a heightmap image. - Fix: [objects#359] Fix water colours in Hover Cars preview image. - Fix: [objects#361] Fix water colours in River Styx boats preview image. - Fix: [objects#362] Fix water colours in Neptune Ride preview image. - Fix: [objects#363] Fix water colours in Harpies Trains preview image.
janisozaur
added a commit
that referenced
this pull request
Jan 8, 2025
- Improved: [#23200] Add banked sloped turns and many other pieces to the Stand-Up and Classic Stand-Up Roller Coaster. - Improved: [#23260] Add diagonal (block) brakes to LSM Launched Roller Coaster. - Improved: [#23350] Increased the maximum width of the ride graph window. - Improved: [#23404] Folders are now paired with an icon in the load/save window. - Improved: [#23405] Filenames can now be input directly into the file browser (load/save) window. - Improved: [#23431] Opaque water and Corkscrew Roller Coaster boosters now show up if RCT1 isn’t linked. - Improved: [objects#369] Updated Russian translation. - Change: [#23413] The max number of park entrance objects has been raised to 255. - Fix: [#1122] Trains spawned on a cable lift hill will fall down and crash (original bug). - Fix: [#19780] Guest screams loop on long drops. - Fix: [#22742, #22793] In game console does not handle format tokens properly. - Fix: [#23135] Map generator tree placement has noticable patterns. - Fix: [#23286] Currency formatted incorrectly in the in game console. - Fix: [#23348] Console set commands don't print output properly. - Fix: [#23376] Peeps with balloons, hats and umbrellas may leave artifacts on screen. - Fix: [#23486] Object selection minimum requirements can be bypassed with close window hotkey. - Fix: [#23496] Newly spawned vehicles are invisible when spawned while the game is paused. - Fix: [#23509] Map generator window reverts to flatland after selecting a heightmap image. - Fix: [objects#359] Fix water colours in Hover Cars preview image. - Fix: [objects#361] Fix water colours in River Styx boats preview image. - Fix: [objects#362] Fix water colours in Neptune Ride preview image. - Fix: [objects#363] Fix water colours in Harpies Trains preview image.
CorySanin
added a commit
to CorySanin/OpenRCT2
that referenced
this pull request
Feb 3, 2025
Release v0.4.18 - Improved: [OpenRCT2#23200] Add banked sloped turns and many other pieces to the Stand-Up and Classic Stand-Up Roller Coaster. - Improved: [OpenRCT2#23260] Add diagonal (block) brakes to LSM Launched Roller Coaster. - Improved: [OpenRCT2#23350] Increased the maximum width of the ride graph window. - Improved: [OpenRCT2#23404] Folders are now paired with an icon in the load/save window. - Improved: [OpenRCT2#23405] Filenames can now be input directly into the file browser (load/save) window. - Improved: [OpenRCT2#23431] Opaque water and Corkscrew Roller Coaster boosters now show up if RCT1 isn’t linked. - Improved: [objects#369] Updated Russian translation. - Change: [OpenRCT2#23413] The max number of park entrance objects has been raised to 255. - Fix: [OpenRCT2#1122] Trains spawned on a cable lift hill will fall down and crash (original bug). - Fix: [OpenRCT2#19780] Guest screams loop on long drops. - Fix: [OpenRCT2#22742, OpenRCT2#22793] In game console does not handle format tokens properly. - Fix: [OpenRCT2#23135] Map generator tree placement has noticable patterns. - Fix: [OpenRCT2#23286] Currency formatted incorrectly in the in game console. - Fix: [OpenRCT2#23348] Console set commands don't print output properly. - Fix: [OpenRCT2#23376] Peeps with balloons, hats and umbrellas may leave artifacts on screen. - Fix: [OpenRCT2#23496] Newly spawned vehicles are invisible when spawned while the game is paused. - Fix: [OpenRCT2#23509] Map generator window reverts to flatland after selecting a heightmap image. - Fix: [objects#359] Fix water colours in Hover Cars preview image. - Fix: [objects#361] Fix water colours in River Styx boats preview image. - Fix: [objects#362] Fix water colours in Neptune Ride preview image. - Fix: [objects#363] Fix water colours in Harpies Trains preview image.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits up the map generator compilation unit into smaller, generator-specific units. Along the way, a namespace structure is adopted, making it easier to extend the map generator in the (near) future.