Skip to content

Allow ^7.0 for league/uri and league/uri-components #1004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 26, 2024
Merged

Allow ^7.0 for league/uri and league/uri-components #1004

merged 2 commits into from
Sep 26, 2024

Conversation

mbenoukaiss
Copy link

According to the changelog none of the functions that got dropped in 7.0 version were used by payum/payum but some are seemingly missing from the changelog because the Path constructor being changed to private was not mentioned
https://github.com/thephpleague/uri/blob/master/CHANGELOG.md
https://github.com/thephpleague/uri-components/blob/master/CHANGELOG.md

If I were to make a similar pull request into 1.7.x would it be possible to accept it and make a new patch version or the fact it's a major version bump for a dependency would forbide that ?

@mbenoukaiss mbenoukaiss changed the title Bump league/uri and league/uri-components to ^7.0 Allow ^7.0 for league/uri and league/uri-components Sep 26, 2024
@pierredup
Copy link
Member

Thanks for the patch @mbenoukaiss

If I were to make a similar pull request into 1.7.x would it be possible to accept it and make a new patch version

Yes I think this can go into 1.7.x, you can just rebase your PR against 1.7.x. After merging and creating a new release, the changes should sync up to the master branch

@mbenoukaiss mbenoukaiss changed the base branch from master to 1.7.x September 26, 2024 12:46
@mbenoukaiss
Copy link
Author

mbenoukaiss commented Sep 26, 2024 •
edited
Loading

So like this ? And is the rector pipeline fail due to a change I made or not ?

@pierredup pierredup added this to the 1.7.6 milestone Sep 26, 2024
@pierredup pierredup self-assigned this Sep 26, 2024
@pierredup
Copy link
Member

Thank you @mbenoukaiss

@pierredup pierredup merged commit 33d5c20 into Payum:1.7.x Sep 26, 2024
10 of 11 checks passed
@pierredup pierredup mentioned this pull request Sep 26, 2024
Closed
@ownede
Copy link

ownede commented Feb 5, 2025

Just ran into this issue myself.
For people still having the issue: I wasn't able to require payum/core for 1.7.x branch, as the dependencies weren't fixed there. A workaround is requiring 1.7.x branch for payum/payum, which worked fine.

@pierredup do you maybe have an idea when 1.7.6 could get released?
It would be great to switch to a tagged version instead of dev branch.

@wiewiurdp wiewiurdp mentioned this pull request Jun 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pierredup pierredup

Labels
dependency
Projects
None yet
Milestone
1.7.6
Development

Successfully merging this pull request may close these issues.
3 participants
@mbenoukaiss @pierredup @ownede