[Stripe][FIX] LogicException when card is declined #801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BadPixxel Thank for the contribution. Could you please add a test? |
|
Let try! I'll update the existing test that set Status as failed as it's now unused |
|
Look like tests are now OK. |
|
Hi @makasim, Any reason not to merge this? |
|
See #854 |
|
@BadPixxel If you are up to finishing this one, can you please rebase against master? That should fix the Twig deprecation notices and make the build green |
|
@pierredup no problem I'll do that. |
pierredup
force-pushed
the
patch-1
branch
2 times, most recently
from
ffa0fb8 to
8e64f8a
Compare
With Stripe, if "save_card" is requested but card is declined, CreateCustomer fails and both $model['card'] && $model['customer'] are unset. Fix => keep card unchanged if CreateCustomer fails and move forward
pierredup
approved these changes
Apr 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Stripe, if "save_card" is requested but card is declined, CreateCustomer fails and both $model['card'] && $model['customer'] are unset.
Fix => keep card unchanged if CreateCustomer fails and move forward