Skip to content

Update KlarnaInvoice package to use solidworx/klarna-invoice #979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 7, 2023
Merged

Update KlarnaInvoice package to use solidworx/klarna-invoice #979

merged 2 commits into from
Dec 7, 2023

Conversation

pierredup
Copy link
Member

The fp/klarna-invoice package doesn't seem to be maintained anymore, and currently emits a lot of deprecation notices when using with PHP 8+

PHP Deprecated:  Return type of KlarnaConfig::offsetExists($offset) should either be compatible with ArrayAccess::offsetExists(mixed $offset): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in vendor/fp/klarna-invoice/klarnaconfig.php on line 130

PHP Deprecated:  Return type of KlarnaConfig::offsetGet($offset) should either be compatible with ArrayAccess::offsetGet(mixed $offset): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in vendor/fp/klarna-invoice/klarnaconfig.php on line 142

PHP Deprecated:  Return type of KlarnaConfig::offsetSet($offset, $value) should either be compatible with ArrayAccess::offsetSet(mixed $offset, mixed $value): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in vendor/fp/klarna-invoice/klarnaconfig.php on line 158

PHP Deprecated:  Return type of KlarnaConfig::offsetUnset($offset) should either be compatible with ArrayAccess::offsetUnset(mixed $offset): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in vendor/fp/klarna-invoice/klarnaconfig.php on line 170

The fp/klarna-invoice package has been forked to solidworx/klarna-invoice and the deprecations fixed. So let's use the forked package, where we can then continue making other improvements to the package.

@pierredup pierredup added the integration External integrations or bridges label Dec 7, 2023
@pierredup pierredup added this to the 1.7.4 milestone Dec 7, 2023
@pierredup pierredup self-assigned this Dec 7, 2023
@what-the-diff What The Diff
Copy link

what-the-diff bot commented Dec 7, 2023

PR Summary

  • Update to the Library Version
    The solidworx/klarna-invoice library, used in the src/Payum/Klarna/Invoice directory, has been upgraded from version 0.1.* to version 0.2.*. This update may improve the feature-set, security, or performance of the components that depend on this library.

@pierredup pierredup merged commit a363025 into 1.7.x Dec 7, 2023
@pierredup pierredup deleted the sw-klarna-invoice branch December 7, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pierredup pierredup

Labels
integration External integrations or bridges
Projects
None yet
Milestone
1.7.4
Development

Successfully merging this pull request may close these issues.
2 participants
@pierredup @actions-user