Disable __GL_THREADED_OPTIMIZATIONS on discrete graphics #1706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes minecraft freezes/crashes when full-screening/exiting the game. The problem exists for like a year on all my devices and it also was reported on nvidia/reddit forums by users. On old versions, like 1.8.9 this happens every minecraft launch. On new versions I don't see the problem, but here might be some related artefacts (black line in bottom on random minecraft launch). The solution was found by a user on nvidia forum, but it seems, like no fix was applied: https://forums.developer.nvidia.com/t/opengl-crash-when-entering-fullscreen-on-rtx-3060-mobile-with-nvidia-dkms-555-58-02-minecraft/299192/26 This commit implements a workaround in PolyMC useDiscreteGpu option. Signed-off-by: Vadim Vetrov <vetrovvd@gmail.com>
|
That's funny but I wasn't able to test it. I has built PolyMC but it has crashed the gnome session when I open it. The crash happens in like 30 seconds every time after open. The program works, I am able to even create an instance and the gnome session crashes and brings me to login screen: Anyways I am sure this commit will work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes minecraft freezes/crashes when full-screening/exiting the game.
The problem exists for like a year on all my devices and it also was reported on nvidia/reddit forums by users. On old versions, like 1.8.9 this happens every minecraft launch. On new versions I don't see the problem, but here might be some related artefacts (black line in bottom on random minecraft launch).
The solution was found by a user on nvidia forum, but it seems, like no fix was applied: https://forums.developer.nvidia.com/t/opengl-crash-when-entering-fullscreen-on-rtx-3060-mobile-with-nvidia-dkms-555-58-02-minecraft/299192/26
This PR implements a workaround in PolyMC useDiscreteGpu option.