-
-
Notifications
You must be signed in to change notification settings - Fork 926
Update Input widget documentation #5961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update Input widget documentation #5961
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, very small request
docs/widgets/input.md
Outdated
@@ -134,6 +133,7 @@ If you set `valid_empty=True` then empty values will bypass any validators, and | |||
|
|||
- [Input.Changed][textual.widgets.Input.Changed] | |||
- [Input.Submitted][textual.widgets.Input.Submitted] | |||
- [Input.Blurred][textual.widgets.Input.Blurred] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have this in alphabetical order please.
@@ -78,8 +78,7 @@ input = Input(validate_on=["submitted"]) | |||
|
|||
Validation is considered to have failed if *any* of the validators fail. | |||
|
|||
You can check whether the validation succeeded or failed inside an [Input.Changed][textual.widgets.Input.Changed] or | |||
[Input.Submitted][textual.widgets.Input.Submitted] handler by looking at the `validation_result` attribute on these events. | |||
You can check whether the validation succeeded or failed inside an [Input.Changed][textual.widgets.Input.Changed], [Input.Submitted][textual.widgets.Input.Submitted], or [Input.Blurred][textual.widgets.Input.Blurred] handler by looking at the `validation_result` attribute on these events. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Props for the Oxford comma
Docs have been deployed since you wrote this, I see the new Message: https://textual.textualize.io/widgets/input/#textual.widgets.Input.Blurred |
order has been fixed |
Please review the following checklist.
I realized that the Input widget documentation needed to be updated for a previous PR I made, which added the
Blurred
message to the Input widget. My apologies, I was newer to this at the time and didn't realize I should have updated that at the same time. This PR updates the Input widget reference page in the two places whereInput.Changed
andInput.Submitted
are mentioned.Also I see that the technical class reference section seems to be auto generated. The Input.Blurred message is not in the current version so I'm guessing it needs to be regenerated? I'm not sure if you need me to do anything for that.