Add invoketarget & invokeaction attributes #18794

keithamus · 2023-10-06T23:29:57Z

`de91640`

Add invoketarget & invokeaction attributes

https://bugs.webkit.org/show_bug.cgi?id=262850

Reviewed by Tim Nguyen.

This adds support for the experimental `invoketarget` and `invokeaction`
attributes, as specified in the open-ui "Invokers" explainer.

(https://open-ui.org/components/invokers.explainer/)

The `invoketarget` attribute maps to the IDL `invokeTargetElement`,
similar to `popoverTargetElement`, and the `invokeaction` is a freeform
string.

The Button behaviour checks for `invokeTargetElement` in its activation
behaviour, and dispatches an `InvokeEvent` if there is one.

This also adds some basic scaffolding for `handleInvokeInternal` which
will allow elements to provide their own invocation action algorithms.

Co-authored-by: Keith Cirkel <keithamus@users.noreply.github.com>

* LayoutTests/imported/w3c/web-platform-tests/html/semantics/invokers/idlharness.tentative-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/invokers/invokeelement-interface.tentative-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/invokers/invokeevent-dispatch-shadow.tentative-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/invokers/invokeevent-interface.tentative-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/invokers/invoketarget-button-event-dispatch.tentative-expected.txt:
* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebCore/CMakeLists.txt:
* Source/WebCore/DerivedSources-input.xcfilelist:
* Source/WebCore/DerivedSources-output.xcfilelist:
* Source/WebCore/DerivedSources.make:
* Source/WebCore/Headers.cmake:
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/bindings/js/WebCoreBuiltinNames.h:
* Source/WebCore/dom/Element.cpp:
(WebCore::Element::isElementReflectionAttribute):
* Source/WebCore/dom/Event.h:
(WebCore::Event::isInvokeEvent const):
* Source/WebCore/dom/EventNames.h:
* Source/WebCore/dom/EventNames.in:
* Source/WebCore/dom/InvokeEvent.cpp: Added.
(WebCore::InvokeEvent::InvokeEvent):
(WebCore::InvokeEvent::create):
(WebCore::InvokeEvent::createForBindings):
(WebCore::InvokeEvent::eventInterface const):
(WebCore::InvokeEvent::isInvokeEvent const):
(WebCore::InvokeEvent::invoker const):
* Source/WebCore/dom/InvokeEvent.h: Added.
* Source/WebCore/dom/InvokeEvent.idl: Added.
* Source/WebCore/html/HTMLAttributeNames.in:
* Source/WebCore/html/HTMLButtonElement.cpp:
(WebCore::HTMLButtonElement::defaultEventHandler):
* Source/WebCore/html/HTMLButtonElement.idl:
* Source/WebCore/html/HTMLElement.h:
(WebCore::HTMLElement::handleInvokeInternal):
* Source/WebCore/html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::invokeTargetElement const):
(WebCore::HTMLFormControlElement::invokeAction const):
(WebCore::HTMLFormControlElement::setInvokeAction):
(WebCore::HTMLFormControlElement::handleInvokeAction):
* Source/WebCore/html/HTMLFormControlElement.h:
* Source/WebCore/html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::defaultEventHandler):
* Source/WebCore/html/HTMLInputElement.idl:
* Source/WebCore/html/InvokerElement.idl: Added.

Canonical link: https://commits.webkit.org/271428@main

4547842

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 gtk
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 gtk-wk2
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv-sim		✅ 🛠 jsc-armv7
✅ 🛠 🧪 merge	✅ 🛠 watch		✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-10-06T23:30:16Z

EWS run on previous version of this PR (hash 8598b9f)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	❌ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	❌ 🧪 gtk-wk2
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	❌ 🧪 mac-wk2	✅ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv	❌ 🧪 mac-AS-debug-wk2	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim	❌ 🧪 mac-wk2-stress	✅ 🧪 jsc-armv7-tests
	❌ 🛠 watch		✅ 🛠 jsc-mips
	❌ 🛠 watch-sim		✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2023-10-07T17:00:25Z

EWS run on previous version of this PR (hash f10ca30)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	❌ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
✅ 🧪 webkitpy	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	❌ 🧪 gtk-wk2
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	❌ 🧪 mac-wk2	✅ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv	❌ 🧪 mac-AS-debug-wk2	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim	❌ 🧪 mac-wk2-stress	✅ 🧪 jsc-armv7-tests
	❌ 🛠 watch		✅ 🛠 jsc-mips
	❌ 🛠 watch-sim		✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2023-10-07T20:05:28Z

EWS run on previous version of this PR (hash fab3ae1)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	❌ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
✅ 🧪 webkitpy	~~🧪 ios-wk2-wpt~~	✅ 🧪 mac-wk1	~~🧪 gtk-wk2~~
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk2	~~🧪 api-gtk~~
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv	~~🧪 mac-AS-debug-wk2~~	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 jsc-armv7-tests
	❌ 🛠 watch		✅ 🛠 jsc-mips
	❌ 🛠 watch-sim		✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2023-10-07T21:02:51Z

EWS run on previous version of this PR (hash c627d9d)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	~~🛠 wincairo~~
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🧪 api-mac~~	✅ 🛠 gtk
✅ 🧪 webkitpy	~~🧪 ios-wk2-wpt~~	~~🧪 mac-wk1~~	~~🧪 gtk-wk2~~
✅ 🛠 🧪 jsc	~~🧪 api-ios~~	~~🧪 mac-wk2~~	✅ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv	~~🧪 mac-AS-debug-wk2~~	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim	~~🧪 mac-wk2-stress~~	✅ 🧪 jsc-armv7-tests
	❌ 🛠 watch		✅ 🛠 jsc-mips
	❌ 🛠 watch-sim		✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2023-10-07T21:33:20Z

EWS run on previous version of this PR (hash ae68448)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	~~🛠 wincairo~~
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🧪 api-mac~~	✅ 🛠 gtk
✅ 🧪 webkitpy	~~🧪 ios-wk2-wpt~~	~~🧪 mac-wk1~~	~~🧪 gtk-wk2~~
✅ 🛠 🧪 jsc	~~🧪 api-ios~~	~~🧪 mac-wk2~~	✅ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv	~~🧪 mac-AS-debug-wk2~~	✅ 🛠 jsc-armv7
	~~🛠 tv-sim~~	~~🧪 mac-wk2-stress~~	✅ 🧪 jsc-armv7-tests
	~~🛠 watch~~		✅ 🛠 jsc-mips
	~~🛠 watch-sim~~		✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2023-10-07T21:38:20Z

EWS run on previous version of this PR (hash 5a6c0c7)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	⏳ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	⏳ 🛠 wincairo
✅ 🧪 bindings	⏳ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
✅ 🧪 webkitperl	⏳ 🧪 ios-wk2	~~🧪 api-mac~~	✅ 🛠 gtk
✅ 🧪 webkitpy	⏳ 🧪 ios-wk2-wpt	~~🧪 mac-wk1~~	~~🧪 gtk-wk2~~
⏳ 🛠 🧪 jsc	⏳ 🧪 api-ios	~~🧪 mac-wk2~~	~~🧪 api-gtk~~
✅ 🛠 🧪 jsc-arm64	⏳ 🛠 tv	~~🧪 mac-AS-debug-wk2~~	✅ 🛠 jsc-armv7
	⏳ 🛠 tv-sim	~~🧪 mac-wk2-stress~~	✅ 🧪 jsc-armv7-tests
	⏳ 🛠 watch		✅ 🛠 jsc-mips
	~~🛠 watch-sim~~		✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2023-10-07T21:49:29Z

EWS run on previous version of this PR (hash 940b8cb)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	~~🛠 wincairo~~
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🧪 api-mac~~	✅ 🛠 gtk
✅ 🧪 webkitpy	~~🧪 ios-wk2-wpt~~	~~🧪 mac-wk1~~	~~🧪 gtk-wk2~~
⏳ 🛠 🧪 jsc	~~🧪 api-ios~~	~~🧪 mac-wk2~~	✅ 🧪 api-gtk
⏳ 🛠 🧪 jsc-arm64	✅ 🛠 tv	~~🧪 mac-AS-debug-wk2~~	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim	~~🧪 mac-wk2-stress~~	✅ 🧪 jsc-armv7-tests
	~~🛠 watch~~		✅ 🛠 jsc-mips
	~~🛠 watch-sim~~		✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2023-10-07T22:01:51Z

EWS run on previous version of this PR (hash 8a7530f)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	⏳ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	⏳ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🧪 api-mac~~	✅ 🛠 gtk
✅ 🧪 webkitpy	~~🧪 ios-wk2-wpt~~	~~🧪 mac-wk1~~	~~🧪 gtk-wk2~~
⏳ 🛠 🧪 jsc	~~🧪 api-ios~~	~~🧪 mac-wk2~~	~~🧪 api-gtk~~
⏳ 🛠 🧪 jsc-arm64	⏳ 🛠 tv	~~🧪 mac-AS-debug-wk2~~	✅ 🛠 jsc-armv7
	⏳ 🛠 tv-sim	~~🧪 mac-wk2-stress~~	✅ 🧪 jsc-armv7-tests
	⏳ 🛠 watch		✅ 🛠 jsc-mips
	⏳ 🛠 watch-sim		✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2023-10-07T22:07:15Z

EWS run on previous version of this PR (hash b9b87d2)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	~~🛠 wincairo~~
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	✅ 🧪 api-mac	✅ 🛠 gtk
✅ 🧪 webkitpy	✅ 🧪 ios-wk2-wpt	~~🧪 mac-wk1~~	~~🧪 gtk-wk2~~
~~🛠 🧪 jsc~~	✅ 🧪 api-ios	~~🧪 mac-wk2~~	✅ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 jsc-armv7-tests
	~~🛠 watch~~		✅ 🛠 jsc-mips
	❌ 🛠 watch-sim		❌ 🧪 jsc-mips-tests

keithamus · 2023-10-07T22:10:01Z

Going to mark this as ready for review to get some feedback on direction. There's no spec yet for this feature - happy to go write that first if necessary.

/cc @lindseywild @nt1m

Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml

metadata/contributors.json

webkit-early-warning-system · 2023-10-07T23:09:40Z

EWS run on previous version of this PR (hash 991d91c)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	❌ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
✅ 🧪 webkitpy	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 jsc-armv7-tests
	❌ 🛠 watch		✅ 🛠 jsc-mips
	❌ 🛠 watch-sim		❌ 🧪 jsc-mips-tests

Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.mm

webkit-early-warning-system · 2023-11-08T14:46:07Z

EWS run on previous version of this PR (hash cf13d2f)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	❌ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim		✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch
	✅ 🛠 watch-sim

nt1m

There's some iOS stuff to rebaseline, but in general this looks OK.

Can you change the commit title to "Add invoketarget & invokeaction attributes"

Source/WebCore/dom/InvokeEvent.cpp

Source/WebCore/html/InvokerElement.idl

Source/WebCore/dom/Element.cpp

Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml

webkit-early-warning-system · 2023-11-10T10:07:21Z

EWS run on previous version of this PR (hash 55578c2)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	❌ 🛠 wpe	❌ 🛠 wincairo
✅ 🧪 bindings	❌ 🛠 ios-sim	❌ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	❌ 🧪 api-mac	❌ 🛠 gtk
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	❌ 🧪 gtk-wk2
✅ 🛠 🧪 jsc	❌ 🧪 api-ios	❌ 🧪 mac-wk2	❌ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64	❌ 🛠 tv	❌ 🧪 mac-AS-debug-wk2	✅ 🛠 jsc-armv7
	❌ 🛠 tv-sim	❌ 🧪 mac-wk2-stress	✅ 🧪 jsc-armv7-tests
	❌ 🛠 watch
	❌ 🛠 watch-sim

Source/WebCore/html/HTMLElement.h

Source/WebCore/html/HTMLFormControlElement.cpp

webkit-early-warning-system · 2023-11-11T12:12:49Z

EWS run on previous version of this PR (hash 708a342)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim		✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch
	✅ 🛠 watch-sim

nt1m

This looks generally good to me. @annevk WDYT of landing this?

Source/WebCore/html/HTMLElement.h

webkit-early-warning-system · 2023-11-12T10:12:49Z

EWS run on current version of this PR (hash 4547842)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 gtk
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 gtk-wk2
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv-sim		✅ 🛠 jsc-armv7
✅ 🛠 🧪 merge	✅ 🛠 watch		✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch-sim

webkit-ews-buildbot · 2023-12-02T09:31:45Z

Safe-Merge-Queue: Build #5022.

https://bugs.webkit.org/show_bug.cgi?id=262850 Reviewed by Tim Nguyen. This adds support for the experimental `invoketarget` and `invokeaction` attributes, as specified in the open-ui "Invokers" explainer. (https://open-ui.org/components/invokers.explainer/) The `invoketarget` attribute maps to the IDL `invokeTargetElement`, similar to `popoverTargetElement`, and the `invokeaction` is a freeform string. The Button behaviour checks for `invokeTargetElement` in its activation behaviour, and dispatches an `InvokeEvent` if there is one. This also adds some basic scaffolding for `handleInvokeInternal` which will allow elements to provide their own invocation action algorithms. Co-authored-by: Keith Cirkel <keithamus@users.noreply.github.com> * LayoutTests/imported/w3c/web-platform-tests/html/semantics/invokers/idlharness.tentative-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/invokers/invokeelement-interface.tentative-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/invokers/invokeevent-dispatch-shadow.tentative-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/invokers/invokeevent-interface.tentative-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/invokers/invoketarget-button-event-dispatch.tentative-expected.txt: * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WebCore/CMakeLists.txt: * Source/WebCore/DerivedSources-input.xcfilelist: * Source/WebCore/DerivedSources-output.xcfilelist: * Source/WebCore/DerivedSources.make: * Source/WebCore/Headers.cmake: * Source/WebCore/Sources.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/bindings/js/WebCoreBuiltinNames.h: * Source/WebCore/dom/Element.cpp: (WebCore::Element::isElementReflectionAttribute): * Source/WebCore/dom/Event.h: (WebCore::Event::isInvokeEvent const): * Source/WebCore/dom/EventNames.h: * Source/WebCore/dom/EventNames.in: * Source/WebCore/dom/InvokeEvent.cpp: Added. (WebCore::InvokeEvent::InvokeEvent): (WebCore::InvokeEvent::create): (WebCore::InvokeEvent::createForBindings): (WebCore::InvokeEvent::eventInterface const): (WebCore::InvokeEvent::isInvokeEvent const): (WebCore::InvokeEvent::invoker const): * Source/WebCore/dom/InvokeEvent.h: Added. * Source/WebCore/dom/InvokeEvent.idl: Added. * Source/WebCore/html/HTMLAttributeNames.in: * Source/WebCore/html/HTMLButtonElement.cpp: (WebCore::HTMLButtonElement::defaultEventHandler): * Source/WebCore/html/HTMLButtonElement.idl: * Source/WebCore/html/HTMLElement.h: (WebCore::HTMLElement::handleInvokeInternal): * Source/WebCore/html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::invokeTargetElement const): (WebCore::HTMLFormControlElement::invokeAction const): (WebCore::HTMLFormControlElement::setInvokeAction): (WebCore::HTMLFormControlElement::handleInvokeAction): * Source/WebCore/html/HTMLFormControlElement.h: * Source/WebCore/html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): * Source/WebCore/html/HTMLInputElement.idl: * Source/WebCore/html/InvokerElement.idl: Added. Canonical link: https://commits.webkit.org/271428@main

webkit-commit-queue · 2023-12-02T16:08:49Z

Committed 271428@main (de91640): https://commits.webkit.org/271428@main

Reviewed commits have been landed. Closing PR #18794 and removing active labels.

Ahmad-S792 assigned keithamus Oct 7, 2023

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 7, 2023

keithamus force-pushed the add-invoke branch from 8598b9f to f10ca30 Compare October 7, 2023 17:00

keithamus force-pushed the add-invoke branch from f10ca30 to fab3ae1 Compare October 7, 2023 20:05

keithamus force-pushed the add-invoke branch from fab3ae1 to c627d9d Compare October 7, 2023 21:02

keithamus force-pushed the add-invoke branch from c627d9d to ae68448 Compare October 7, 2023 21:33

keithamus force-pushed the add-invoke branch from ae68448 to 5a6c0c7 Compare October 7, 2023 21:37

keithamus force-pushed the add-invoke branch from 5a6c0c7 to 940b8cb Compare October 7, 2023 21:49

keithamus force-pushed the add-invoke branch from 940b8cb to 8a7530f Compare October 7, 2023 22:01

keithamus force-pushed the add-invoke branch from 8a7530f to b9b87d2 Compare October 7, 2023 22:07

keithamus marked this pull request as ready for review October 7, 2023 22:09

keithamus requested review from cdumez, rniwa and JonWBedard as code owners October 7, 2023 22:09

Ahmad-S792 reviewed Oct 7, 2023

View reviewed changes

Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml Outdated Show resolved Hide resolved

Ahmad-S792 reviewed Oct 7, 2023

View reviewed changes

metadata/contributors.json Outdated Show resolved Hide resolved

keithamus force-pushed the add-invoke branch from b9b87d2 to 991d91c Compare October 7, 2023 23:09

keithamus mentioned this pull request Oct 7, 2023

Add 'Keith Cirkel' and 'Lindsey Wild' to contributor.json #18815

Merged

nt1m reviewed Oct 8, 2023

View reviewed changes

Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.mm Outdated Show resolved Hide resolved

keithamus force-pushed the add-invoke branch from 1474716 to cf13d2f Compare November 8, 2023 14:46

nt1m reviewed Nov 9, 2023

View reviewed changes

keithamus changed the title ~~Add invoke attribute~~ Add invoketarget & invokeaction attributes Nov 9, 2023

keithamus force-pushed the add-invoke branch from cf13d2f to 55578c2 Compare November 10, 2023 10:07

nt1m reviewed Nov 10, 2023

View reviewed changes

Source/WebCore/html/HTMLElement.h Outdated Show resolved Hide resolved

nt1m reviewed Nov 10, 2023

View reviewed changes

Source/WebCore/html/HTMLFormControlElement.cpp Outdated Show resolved Hide resolved

keithamus force-pushed the add-invoke branch from 55578c2 to 708a342 Compare November 11, 2023 12:12

nt1m reviewed Nov 11, 2023

View reviewed changes

Source/WebCore/html/HTMLElement.h Outdated Show resolved Hide resolved

keithamus force-pushed the add-invoke branch from 708a342 to 4547842 Compare November 12, 2023 10:12

Ahmad-S792 added DOM For bugs specific to XML/HTML DOM elements (including parsing). and removed merging-blocked Applied to prevent a change from being merged labels Nov 12, 2023

nt1m approved these changes Dec 2, 2023

View reviewed changes

lukewarlow added the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label Dec 2, 2023

webkit-ews-buildbot added merge-queue Applied to send a pull request to merge-queue and removed safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks labels Dec 2, 2023

lukewarlow added merge-queue Applied to send a pull request to merge-queue and removed merge-queue Applied to send a pull request to merge-queue labels Dec 2, 2023

webkit-commit-queue force-pushed the add-invoke branch from 4547842 to de91640 Compare December 2, 2023 16:08

webkit-commit-queue merged commit de91640 into WebKit:main Dec 2, 2023

webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Dec 2, 2023

Add invoketarget & invokeaction attributes #18794

Add invoketarget & invokeaction attributes #18794

Uh oh!

Conversation

keithamus commented Oct 6, 2023 • edited by webkit-early-warning-system Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

de91640

Uh oh!

webkit-early-warning-system commented Oct 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Oct 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Oct 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Oct 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Oct 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Oct 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Oct 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Oct 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Oct 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

keithamus commented Oct 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

webkit-early-warning-system commented Oct 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

webkit-early-warning-system commented Nov 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nt1m left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

webkit-early-warning-system commented Nov 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

webkit-early-warning-system commented Nov 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nt1m left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

webkit-early-warning-system commented Nov 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-ews-buildbot commented Dec 2, 2023

Uh oh!

webkit-commit-queue commented Dec 2, 2023

Uh oh!

Uh oh!

keithamus commented Oct 6, 2023 •

edited by webkit-early-warning-system

Loading

`de91640`

webkit-early-warning-system commented Oct 6, 2023 •

edited

Loading

webkit-early-warning-system commented Oct 7, 2023 •

edited

Loading

webkit-early-warning-system commented Oct 7, 2023 •

edited

Loading

webkit-early-warning-system commented Oct 7, 2023 •

edited

Loading

webkit-early-warning-system commented Oct 7, 2023 •

edited

Loading

webkit-early-warning-system commented Oct 7, 2023 •

edited

Loading

webkit-early-warning-system commented Oct 7, 2023 •

edited

Loading

webkit-early-warning-system commented Oct 7, 2023 •

edited

Loading

webkit-early-warning-system commented Oct 7, 2023 •

edited

Loading

keithamus commented Oct 7, 2023 •

edited

Loading

webkit-early-warning-system commented Oct 7, 2023 •

edited

Loading

webkit-early-warning-system commented Nov 8, 2023 •

edited

Loading

webkit-early-warning-system commented Nov 10, 2023 •

edited

Loading

webkit-early-warning-system commented Nov 11, 2023 •

edited

Loading

webkit-early-warning-system commented Nov 12, 2023 •

edited

Loading