-
Notifications
You must be signed in to change notification settings - Fork 12k
Created GitHub Project Layout with example #3072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
MUmarShahbaz
commented
Mar 13, 2025
I don't really understand what the error in the prettier workflow is, could you explain it to me? |
@george-gca do you think this layout is good? |
I am not sure either what is the issue here with prettier. Maybe you should remove and re-add the file? As for the layout, I'll give some thought and bring you a better feedback. |
ok |
@george-gca this time I have fixed the prettier error. The plugin just kept breaking at that file for some reason. After a lot of back and forth I eventually just deleted the file altogether and nested the code into the place where I needed it. This will not affect any other files and the code will work as it is supposed to. As always, you can find the link over here: https://mumarshahbaz.github.io/al-folio/projects/10_project/ |
@george-gca btw, even after the edits the project looks exactly like in the images above. I think this is ready to be merged |
a45b457
to
c8ff198
Compare
@george-gca review? |
Still waiting for that review 😢 |
Sorry, I've been with a strict time to effectively analyze the PRs, so I've been focusing only on the Q&As. I will try to save some time to give these PRs a nice review sometime the next week. |
Thanks for your contribution, and sorry for the long delay in checking this. I very much like this layout. |
This reverts commit 9d1e1c6.