Skip to content

Created GitHub Project Layout with example #3072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 16, 2025

Conversation

MUmarShahbaz
Copy link
Contributor

image
image

@MUmarShahbaz
Copy link
Contributor Author

@MUmarShahbaz
Copy link
Contributor Author

Added Tablet and Mobile Layouts

Tablet

image
image

Mobile

image
image

@MUmarShahbaz
Copy link
Contributor Author

I don't really understand what the error in the prettier workflow is, could you explain it to me?

@MUmarShahbaz
Copy link
Contributor Author

@george-gca do you think this layout is good?

@george-gca
Copy link
Collaborator

I am not sure either what is the issue here with prettier. Maybe you should remove and re-add the file?

As for the layout, I'll give some thought and bring you a better feedback.

@MUmarShahbaz
Copy link
Contributor Author

I am not sure either what is the issue here with prettier. Maybe you should remove and re-add the file?

As for the layout, I'll give some thought and bring you a better feedback.

ok

@MUmarShahbaz
Copy link
Contributor Author

@george-gca this time I have fixed the prettier error. The plugin just kept breaking at that file for some reason. After a lot of back and forth I eventually just deleted the file altogether and nested the code into the place where I needed it.

This will not affect any other files and the code will work as it is supposed to.

As always, you can find the link over here: https://mumarshahbaz.github.io/al-folio/projects/10_project/

@MUmarShahbaz
Copy link
Contributor Author

@george-gca btw, even after the edits the project looks exactly like in the images above.

I think this is ready to be merged

@MUmarShahbaz MUmarShahbaz force-pushed the master branch 7 times, most recently from a45b457 to c8ff198 Compare April 25, 2025 10:11
@MUmarShahbaz
Copy link
Contributor Author

MUmarShahbaz commented Apr 25, 2025

I changed the project to match all of their others as well as contain a description of how to use the layout.

image

@MUmarShahbaz
Copy link
Contributor Author

@george-gca review?

@MUmarShahbaz
Copy link
Contributor Author

Still waiting for that review 😢

@george-gca
Copy link
Collaborator

Sorry, I've been with a strict time to effectively analyze the PRs, so I've been focusing only on the Q&As. I will try to save some time to give these PRs a nice review sometime the next week.

@george-gca
Copy link
Collaborator

Thanks for your contribution, and sorry for the long delay in checking this. I very much like this layout.

@george-gca george-gca merged commit 9d1e1c6 into alshedivat:master Jul 16, 2025
3 checks passed
jiadonglee added a commit to jiadonglee/jiadonglee.github.io that referenced this pull request Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants