Skip to content

Fix Prettier Feature DevContainer Link #3196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rinehartj
Copy link

Fixes #3193

Copy link

netlify bot commented Jun 5, 2025

Deploy Preview for relaxed-lollipop-b6bc17 ready!

Name Link
🔨 Latest commit 1a81d09
🔍 Latest deploy log https://app.netlify.com/projects/relaxed-lollipop-b6bc17/deploys/6841a7546a35f0000810e421
😎 Deploy Preview https://deploy-preview-3196--relaxed-lollipop-b6bc17.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@CheariX
Copy link
Contributor

CheariX commented Jul 4, 2025

LGTM. Tested + works as expected.

@CheariX
Copy link
Contributor

CheariX commented Jul 15, 2025

I tested with a clean checkout.
For some reason, I needed to run yarn add --dev prettier @shopify/prettier-plugin-liquid now.

@george-gca
Copy link
Collaborator

This is weird, since this file should resolve this @shopify/prettier-plugin-liquid issue. Maybe the plugin should also be added somewhere to the devcontainer file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prettier package in devcontainer.json no longer resolves (causing build fail)
3 participants