Skip to content

THRIFT-5821: support building against AWS-LC #3049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 24, 2024
Merged

THRIFT-5821: support building against AWS-LC #3049

merged 1 commit into from
Oct 24, 2024

Conversation

jeking3
Copy link
Contributor

@jeking3 jeking3 commented Oct 4, 2024 •
edited
Loading

To use AWS-LC (a BoringSSL derivitive maintained by AWS) instead of openssl for libcrypto, a few lines needed to be patched.

  • Did you create an Apache Jira ticket? (Request account here, not required for trivial changes)
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

@jeking3 jeking3 self-assigned this Oct 4, 2024
@Jens-G Jens-G added the c++ label Oct 11, 2024
@jeking3 jeking3 requested a review from Jens-G October 15, 2024 14:52
@jeking3 jeking3 merged commit 61080c6 into apache:master Oct 24, 2024
20 of 22 checks passed
@jeking3 jeking3 deleted the THRIFT-5821 branch October 24, 2024 11:45
@jeking3 jeking3 mentioned this pull request Oct 24, 2024
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jens-G Jens-G Awaiting requested review from Jens-G

Assignees

@jeking3 jeking3

Labels
c++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeking3 @Jens-G