Added warning about credentials in debug info #1457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arnau Mora <arnyminerz@proton.me>
Closed
There was a problem hiding this comment.
Pull Request Overview
This PR adds a warning message to the debug information screen, alerting users that log messages may contain credentials.
- Adds new string resources for a credentials warning.
- Introduces a new CardWithImage in the DebugInfoScreen to display the warning, using a password icon.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| app/src/main/res/values/strings.xml | Added new string resources for the credentials warning message. |
| app/src/main/kotlin/at/bitfire/davdroid/ui/DebugInfoScreen.kt | Inserts a new CardWithImage to show the credentials warning within the debug info screen. |
Signed-off-by: Arnau Mora <arnyminerz@proton.me>
sunkup
previously approved these changes
May 12, 2025
Signed-off-by: Arnau Mora <arnyminerz@proton.me>
sunkup
previously approved these changes
May 13, 2025
rfc2822
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Logs may contain confidential information like passwords or Base64 encoded credentials, people may not know it.
Short description
Added a warning message in the debug information screen to let the user know that log messages can contain credentials, and that they should be really careful while sharing.
Screenshot
Checklist