Skip to content

TaskSyncer: accept nullable ResyncType #1487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2025
Merged

TaskSyncer: accept nullable ResyncType #1487

merged 1 commit into from
May 22, 2025

Conversation

rfc2822
Copy link
Member

@rfc2822 rfc2822 commented May 22, 2025

No description provided.

@rfc2822 rfc2822 self-assigned this May 22, 2025
@rfc2822 rfc2822 added the bug Something isn't working label May 22, 2025
@rfc2822 rfc2822 linked an issue May 22, 2025 that may be closed by this pull request
Doesn't sync tasks.org tasks anymore #1486
Closed
@rfc2822 rfc2822 marked this pull request as ready for review May 22, 2025 17:41
@rfc2822 rfc2822 requested a review from Copilot May 22, 2025 17:41
Copilot
Copilot AI reviewed May 22, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the TaskSyncer constructor to accept a nullable ResyncType instead of requiring a non-null value.

  • Changed the resync parameter type to ResyncType?
  • No null-handling or default behavior added for the new nullable parameter

@rfc2822 rfc2822 merged commit 3efb8d5 into main-ose May 22, 2025
7 checks passed
@rfc2822 rfc2822 deleted the 1486-doesnt-sync-tasksorg-tasks-anymore branch May 22, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

@rfc2822 rfc2822

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Doesn't sync tasks.org tasks anymore
1 participant
@rfc2822