-
-
Notifications
You must be signed in to change notification settings - Fork 89
Use lowercase GroupIDs as a workaround for jitpack.io issues #1489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use lowercase GroupIDs as a workaround for jitpack.io issues #1489
Conversation
Related discussion at bitfireAT#1236 and jitpack/jitpack.io#3295 (comment) For example trying to access: https://jitpack.io/com/github/bitfireAT/dav4jvm/b87d772e44/ I get: File not found. Build ok In comparison under https://jitpack.io/com/github/bitfireat/dav4jvm/b87d772e44/ I get: build.log dav4jvm-b87d772e44-sources.jar dav4jvm-b87d772e44.jar dav4jvm-b87d772e44.module dav4jvm-b87d772e44.pom dav4jvm-b87d772e44.pom.md5 dav4jvm-b87d772e44.pom.sha1
The only reference I've managed to find regarding upper/lowercase issues with Jitpack is this one: jitpack/jitpack.io#3722. And of course, even though GitHub is not case sensitive for names, Gradle definitely is, and according to that short thread, Jitpack also is. So I'd rather just keep the "official" capitalization, but @rfc2822 may say otherwise. A longer explanation: I know about the issues there are building old releases, and honestly, I think it would be more suitable so use a Gradle host like Sonatype. When we moved from submodules to actual dependencies we used Jitpack just because it was simpler, not because it was better in any way. Also we didn't want to spend time on releases, just use commit ID, which Jitpack is great for. Then, I know this works, but if we don't even know why, and the organization name is in capitals in GitHub, I would not like to change it now just "because for some reason it works better". We can try reopening jitpack/jitpack.io#3722 and see what they say. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See other comment
It's an issue I run into occassionally and apparently other users as well (see the linked github issue I referenced). The all lower-case group-id names was the only "solution" I found so far. If you have a better solution, I'm all ears. |
That is not the only issue. See the issue I referenced jitpack/jitpack.io#3295 (comment) and it has many referenced issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mmmh okay, upon further inspection, seems to be the only fix (for some reason). I suggest merging this, and thinking about properly hosting the dependencies somewhere else than Jitpack
thanks! |
Related discussion at
#1236
and
jitpack/jitpack.io#3295 (comment)
For example trying to access:
https://jitpack.io/com/github/bitfireAT/dav4jvm/b87d772e44/ I get:
File not found. Build ok
In comparison under
https://jitpack.io/com/github/bitfireat/dav4jvm/b87d772e44/ I get:
build.log
dav4jvm-b87d772e44-sources.jar
dav4jvm-b87d772e44.jar
dav4jvm-b87d772e44.module
dav4jvm-b87d772e44.pom
dav4jvm-b87d772e44.pom.md5
dav4jvm-b87d772e44.pom.sha1