feat: Implement Salesforce custom object support #221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces support for ingesting data from Salesforce custom objects.
The `get_records` helper function in the Salesforce source has been updated to recognize a new table naming convention: `custom:<object-name>`. When this convention is used, the source will correctly translate the object name to the Salesforce API format (`<object-name>__c`) for all interactions, including describing the object, querying data, and constructing SOQL queries.
Key changes:
- Modified `ingestr/src/salesforce/helpers.py`:
- The `get_records` function now parses the `sobject` parameter.
- If `sobject` starts with `custom:`, it extracts the object name and appends `__c`.
- Otherwise, the standard object name is used.
- Added `ingestr/tests/unit/test_salesforce.py`:
- New unit tests to verify the correct handling of custom object names.
- Tests ensure that standard object ingestion remains unaffected.
- Tests cover data iteration, field exclusion (compound fields), and datetime formatting.
All new and existing tests pass, confirming the functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces support for ingesting data from Salesforce custom objects.
The
get_recordshelper function in the Salesforce source has been updated to recognize a new table naming convention:custom:<object-name>. When this convention is used, the source will correctly translate the object name to the Salesforce API format (<object-name>__c) for all interactions, including describing the object, querying data, and constructing SOQL queries.Key changes:
ingestr/src/salesforce/helpers.py:get_recordsfunction now parses thesobjectparameter.sobjectstarts withcustom:, it extracts the object name and appends__c.ingestr/tests/unit/test_salesforce.py:All new and existing tests pass, confirming the functionality.