Skip to content

fix distributed initialization #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix distributed initialization #285

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix distributed initialization
  • Loading branch information
@ZiyueHuang
ZiyueHuang committed Aug 5, 2020
commit c7c030db2bf23ac9c0157b769ab6051d5e73a298
2 changes: 0 additions & 2 deletions byteps/mxnet/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,8 +221,6 @@ def _init_params(self):
param_arrays = param._check_and_get(param._data, list)
idx = self._param2idx[param.name]

if rank() != self.root_rank:
param_arrays[0].__imul__(0)
byteps_push_pull(param_arrays[0], version=0, priority=0,
name="parameter_" + str(idx), is_average=False)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be we should use is_average=True here?

Copy link
Contributor Author

@ZiyueHuang ZiyueHuang Aug 5, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is no need to average, since the server just selects one received tensor and copy it to the stored buffer then send it to all workers.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right.


Expand Down