Skip to content

refact: migrate net.IP -> net/netip: part 2 #3682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Jun 12, 2025

No description provided.

@mmetc mmetc added this to the Next release milestone Jun 12, 2025
Copy link

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

codecov bot commented Jun 12, 2025

Codecov Report

Attention: Patch coverage is 74.32432% with 57 lines in your changes missing coverage. Please review.

Project coverage is 34.30%. Comparing base (b5d90ff) to head (a789ebd).

Files with missing lines Patch % Lines
pkg/database/alertfilter.go 43.24% 20 Missing and 1 partial ⚠️
pkg/database/decisions.go 56.41% 17 Missing ⚠️
pkg/database/alerts.go 65.21% 8 Missing ⚠️
pkg/apiserver/apic.go 50.00% 3 Missing and 1 partial ⚠️
pkg/csnet/ip.go 95.08% 2 Missing and 1 partial ⚠️
pkg/csconfig/api.go 66.66% 1 Missing and 1 partial ⚠️
pkg/database/allowlists.go 93.75% 1 Missing and 1 partial ⚠️

❗ There is a different number of reports uploaded between BASE (b5d90ff) and HEAD (a789ebd). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (b5d90ff) HEAD (a789ebd)
bats 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #3682       +/-   ##
===========================================
- Coverage   61.24%   34.30%   -26.95%     
===========================================
  Files         361      359        -2     
  Lines       40273    40206       -67     
===========================================
- Hits        24667    13791    -10876     
- Misses      13598    25129    +11531     
+ Partials     2008     1286      -722     
Flag Coverage Δ
bats ?
unit-linux 34.30% <74.32%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mmetc mmetc force-pushed the net-range-netip branch from 8cc8e42 to f4e23c9 Compare June 12, 2025 12:00
@mmetc mmetc force-pushed the net-range-netip branch from f4e23c9 to 9e456ac Compare June 20, 2025 07:26
@mmetc mmetc force-pushed the net-range-netip branch from 9e456ac to a789ebd Compare June 20, 2025 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant