Skip to content

Improve bouncer flush criteria #3728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improve bouncer flush criteria #3728

wants to merge 1 commit into from

Conversation

david-garcia-garcia
Copy link
Contributor

@david-garcia-garcia david-garcia-garcia commented Jul 11, 2025 •
edited
Loading

  • Only flush auto_created=1 bouncers
  • When a bouncer has never pulled, use creation date to flush

Fixes #3726

/kind enhancement
/area local-api

@github-actions GitHub Actions
Copy link

@david-garcia-garcia: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@github-actions GitHub Actions
Copy link

@david-garcia-garcia: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@david-garcia-garcia david-garcia-garcia mentioned this pull request Jul 11, 2025
Open
@codecov Codecov
Copy link

codecov bot commented Jul 11, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 27 lines in your changes missing coverage. Please review.

Project coverage is 61.17%. Comparing base (2046376) to head (03b3217).

Files with missing lines Patch % Lines
pkg/database/flush.go 0.00% 27 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3728      +/-   ##
==========================================
+ Coverage   60.70%   61.17%   +0.46%     
==========================================
  Files         374      362      -12     
  Lines       41277    40429     -848     
==========================================
- Hits        25058    24733     -325     
+ Misses      14156    13671     -485     
+ Partials     2063     2025      -38
Flag Coverage Δ
bats 44.71% <0.00%> (-0.09%) ⬇️
unit-linux 34.25% <0.00%> (-0.04%) ⬇️
unit-windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs/area needs/kind
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Let bouncers identify themselves instead of using the current IP address approach
1 participant
@david-garcia-garcia