Skip to content

new service detection and configuration at postinst #3730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 55 commits into
base: master
Choose a base branch
from
Draft

new service detection and configuration at postinst #3730

wants to merge 55 commits into from

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Jul 15, 2025 •
edited
Loading

todo:

  • check/improve all user facing messages
  • trim down and review detect.yaml
  • check config file hash
  • update wizard.sh
  • update in-package readme
    ...

mmetc added 30 commits July 15, 2025 10:40
@mmetc
refact: split "cscli setup"
959e8fd
@mmetc
cscli setup detect --install-hub --datasources
9da57d3
@mmetc
cscli setup --auto (interactive by default)
4c5c02f
@mmetc
fixes
dc3cd3c
@mmetc
update tests, setup constructor, refact
77a8a20
@mmetc
more stup refact
7324b5f
@mmetc
improve feedback/prompt, support items of type appsec, context etc.
aac1b49
@mmetc
tests
069097e
@mmetc
todo
d4f5ddd
@mmetc
collect list of acquisition files
de60974
@mmetc
deb/rpm postinst: replace wizard.sh with cscli setup
dde7644
@mmetc
rename
40b9a9f
@mmetc
wip
2721d35
@mmetc
rename fields
809bd83
@mmetc
struct Detector
20df240
@mmetc
tests
cbd7491
@mmetc
extracted expr.go
ff85896
@mmetc
rename stuff
960a03c
@mmetc
more rename
df90a7c
@mmetc
more rename
d039639
@mmetc
ignore generated acquisition files
a2ae12e
@mmetc
dead code
512c0d3
@mmetc
explicit acquisition filename
31eaaa8
@mmetc
refact tests and boundaries
47f091a
@mmetc
update go-yaml, etc
68536ed
@mmetc
explicit logger
2091d8a
@mmetc
move pkg/setup to cscli
b66ec31
@mmetc
wip
2fa2e0f
@mmetc
cscli setup interactive/unattended
beaf474
@mmetc
wip
fdbe0ea
@github-actions GitHub Actions
Copy link

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@github-actions GitHub Actions
Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@mmetc mmetc requested a review from blotus July 15, 2025 11:17
@codecov Codecov
Copy link

codecov bot commented Jul 16, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 71.13857% with 327 lines in your changes missing coverage. Please review.

Project coverage is 44.95%. Comparing base (2046376) to head (c325782).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
cmd/crowdsec-cli/clisetup/wizard.go 48.91% 77 Missing and 17 partials ⚠️
cmd/crowdsec-cli/clisetup/setup/acquisition.go 49.35% 26 Missing and 13 partials ⚠️
cmd/crowdsec-cli/clisetup/setup/detector.go 70.83% 15 Missing and 6 partials ⚠️
cmd/crowdsec-cli/clisetup/detect.go 85.92% 14 Missing and 5 partials ⚠️
pkg/csconfig/crowdsec_service.go 67.79% 14 Missing and 5 partials ⚠️
cmd/crowdsec-cli/clisetup/acquisition.go 77.50% 12 Missing and 6 partials ⚠️
cmd/crowdsec-cli/clisetup/setup/expr.go 79.26% 14 Missing and 3 partials ⚠️
cmd/crowdsec-cli/clisetup/hub.go 79.72% 10 Missing and 5 partials ⚠️
cmd/crowdsec-cli/clisetup/interactive.go 69.56% 13 Missing and 1 partial ⚠️
cmd/crowdsec-cli/clisetup/setup/systemd.go 63.63% 8 Missing and 4 partials ⚠️
... and 11 more

❗ There is a different number of reports uploaded between BASE (2046376) and HEAD (c325782). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (2046376) HEAD (c325782)
unit-linux 1 0
unit-windows 1 0
Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #3730       +/-   ##
===========================================
- Coverage   60.70%   44.95%   -15.76%     
===========================================
  Files         374      369        -5     
  Lines       41277    40266     -1011     
===========================================
- Hits        25058    18102     -6956     
- Misses      14156    20403     +6247     
+ Partials     2063     1761      -302
Flag Coverage Δ
bats 44.95% <71.13%> (+0.14%) ⬆️
unit-linux ?
unit-windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

sabban
sabban reviewed Jul 16, 2025
View reviewed changes
Copy link
Contributor

@sabban sabban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite clear to me. Only thing I saw is you forgot to add the detect.yaml in the rpm spec file though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sabban sabban sabban left review comments

@blotus blotus Awaiting requested review from blotus

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
kind/feature needs/area
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmetc @sabban