SRE-3104 ci: Use DAOS specific HTTPS_PROXY variable #16496

grom72 · 2025-06-10T15:10:04Z

SRE-3104 ci: Use DAOS specific HTTPS_PROXY variable

The HTTPS_PROXY variable set in Jenkins may force any shell script to use a proxy server.
This is not expected, as we want to avoid using a proxy unless it is explicitly needed by
the DAOS tests or the build process.

Steps for the author:

Commit message follows the guidelines.
Appropriate Features or Test-tag pragmas were used.
Appropriate Functional Test Stages were run.
At least two positive code reviews including at least one code owner from each category referenced in the PR.
Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

Gatekeeper requested (daos-gatekeeper added as a reviewer).

Use custom library for validation purpose The HTTPS_PROXY variable set in Jenkins may force any shell script to use a proxy server. This is not expected, as we want to avoid using a proxy unless it is explicitly needed by the DAOS tests or the build process. Priority: 2 Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>

The HTTPS_PROXY variable set in Jenkins may force any shell script to use a proxy server. This is not expected, as we want to avoid using a proxy unless it is explicitly needed by the DAOS tests or the build process. Priority: 2 Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>

Priority: 2 Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>

github-actions · 2025-06-10T15:10:22Z

Errors are Unable to load ticket data
https://daosio.atlassian.net/browse/SRE-3104

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>

This reverts commit a3a1779. Priority: 2 Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>

Skip-python-bandit: true Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>

daosbuild3 · 2025-06-11T06:02:02Z

Test stage Build RPM on EL 8 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-16496/7/execution/node/268/log

This reverts commit c737e52. Cancel-prev-build: false Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>

daosbuild3 · 2025-06-11T06:09:23Z

Test stage Build RPM on EL 9 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-16496/7/execution/node/269/log

daosbuild3 · 2025-06-11T06:16:58Z

Test stage Build RPM on EL 8 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-16496/8/execution/node/339/log

daosbuild3 · 2025-06-11T06:17:01Z

Test stage Build RPM on Leap 15.5 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-16496/7/execution/node/270/log

daosbuild3 · 2025-06-11T06:24:41Z

Test stage Build RPM on EL 9 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-16496/8/execution/node/345/log

daosbuild3 · 2025-06-11T06:31:11Z

Test stage Build RPM on Leap 15.5 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-16496/8/execution/node/340/log

daosbuild3 · 2025-06-11T08:59:43Z

Test stage Test RPMs on EL 8.6 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos/job/PR-16496/8/display/redirect

daosbuild3 · 2025-06-11T09:01:31Z

Test stage Functional on EL 8.8 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos/job/PR-16496/8/display/redirect

daosbuild3 · 2025-06-11T09:06:07Z

Test stage Test RPMs on EL 8.6 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos/job/PR-16496/7/display/redirect

daosbuild3 · 2025-06-11T09:09:31Z

Test stage Functional on EL 8.8 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos/job/PR-16496/7/display/redirect

daosbuild3 · 2025-06-11T12:29:58Z

Test stage Functional Hardware Medium Verbs Provider MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos/job/PR-16496/11/display/redirect

daosbuild3 · 2025-06-11T13:43:31Z

Test stage Functional Hardware Medium MD on SSD completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-16496/11/testReport/

daosbuild3 · 2025-06-11T13:46:11Z

Test stage Functional Hardware Medium completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-16496/11/testReport/

daosbuild3 · 2025-06-11T13:59:14Z

Test stage Functional Hardware Large MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-16496/11/execution/node/768/log

daosbuild3 · 2025-06-11T14:11:31Z

Test stage Functional on EL 9 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-16496/10/execution/node/782/log

JohnMalmberg

Looks good with some minor nits.

JohnMalmberg · 2025-06-11T14:21:21Z

src/control/common/env_utils.go

 // (C) Copyright 2019-2024 Intel Corporation.
+// (C) Copyright 2025 Hewlett Packard Enterprise Development LP


As we update these, we should be removing the (C) as it has no legal meaning in Copyright messages.
Copyright messages must use the word Copyright or the special symbol of an R with a circle around it as a shorthand,.
Copyright messages should not have both the word Copyright and the special symbol.
The (C) can not be used as a substitute for the special symbol or the word Copyright.
Note copyright messages are not required to enforce a the right of copyright, they just make it easier to do so.

FWIW these copyright messages get updated automatically. So if we really want to remove the (C) I think it would be better to update the githook to do that instead of doing it manually

Yes, the GitHook should be fixed with a comment in it that (C) is not part of the copyright law.

JohnMalmberg · 2025-06-11T14:21:46Z

src/control/common/env_utils_test.go

 // (C) Copyright 2019-2024 Intel Corporation.
+// (C) Copyright 2025 Hewlett Packard Enterprise Development LP


daltonbohning · 2025-06-11T14:41:47Z

src/control/common/env_utils.go

@@ -63,6 +64,7 @@ func ScrubProxyVariables() {
 	proxyVars := []string{
 		"http_proxy", "https_proxy", "ftp_proxy", "socks_proxy", "no_proxy",
 		"HTTP_PROXY", "HTTPS_PROXY", "FTP_PROXY", "SOCKS_PROXY", "NO_PROXY",
+		"DAOS_HTTPS_PROXY",


I'm not familiar enough, but do we really need this change in the control plane? Since we ultimately

export HTTPS_PROXY=DAOS_HTTPS_PROXY

This affects the engine process environment, @mjmac understands this better than I do?

Yeah, I don't think we want or need this here, as it's specific to the HPE CI environment. The utility of this helper is for allowing e.g. the dmg utility to invoke gRPC methods on an internal server without accidentally going through the proxy.

Cancel-prev-build: false Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>

Cancel-prev-build Priority: 2 Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>

daosbuild3 · 2025-06-11T19:54:36Z

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-16496/17/testReport/

kjacque

Looks OK to me, now that the Go stuff is removed. Should get another review from someone on devops or validation.

daosbuild3 · 2025-06-12T07:05:47Z

Test stage Functional on EL 8.8 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos/job/PR-16496/18/display/redirect

daosbuild3 · 2025-06-12T20:59:26Z

Test stage Functional on EL 9 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-16496/20/execution/node/1197/log

This reverts commit 0bebf70. Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>

daosbuild3 · 2025-06-13T18:56:55Z

Test stage Functional Hardware Large MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-16496/22/execution/node/1337/log

daosbuild3 · 2025-06-14T00:36:26Z

Test stage Functional Hardware Medium MD on SSD completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-16496/22/testReport/

daosbuild3 · 2025-06-14T02:06:45Z

Test stage Functional Hardware Medium Verbs Provider MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-16496/22/execution/node/1476/log

grom72 added 3 commits June 10, 2025 16:54

Unset HTTPS_PROXY for validation purpose

7879ac6

Priority: 2 Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>

grom72 added 3 commits June 10, 2025 18:30

Custom proxy to check which one is used

a3a1779

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>

Revert "Custom proxy to check which one is used"

d014bdf

This reverts commit a3a1779. Priority: 2 Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>

Skip Pre-build checks

c737e52

Skip-python-bandit: true Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>

Revert "Skip Pre-build checks"

e7fc8b6

This reverts commit c737e52. Cancel-prev-build: false Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>

grom72 changed the title ~~Use DAOS specific HTTPS_PROXY variable~~ SRE-3104 ci: Use DAOS specific HTTPS_PROXY variable Jun 11, 2025

grom72 marked this pull request as ready for review June 11, 2025 14:18

grom72 requested review from a team as code owners June 11, 2025 14:18

JohnMalmberg previously approved these changes Jun 11, 2025

View reviewed changes

grom72 added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Jun 11, 2025

daltonbohning reviewed Jun 11, 2025

View reviewed changes

Fix - rollback unneded changes

6875c09

Cancel-prev-build: false Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>

grom72 dismissed JohnMalmberg’s stale review via 6875c09 June 11, 2025 15:53

Fix licenses (rollback)

98202a1

Cancel-prev-build Priority: 2 Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>

grom72 requested review from JohnMalmberg and ryon-jensen and removed request for a team June 11, 2025 18:07

JohnMalmberg previously approved these changes Jun 11, 2025

View reviewed changes

kjacque reviewed Jun 12, 2025

View reviewed changes

tanabarr previously approved these changes Jun 12, 2025

View reviewed changes

Revert "SRE-3104 ci: Use DAOS specific HTTPS_PROXY variable"

2a4207b

This reverts commit 0bebf70. Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>

grom72 dismissed stale reviews from tanabarr and JohnMalmberg via 2a4207b June 13, 2025 11:42

grom72 requested review from tanabarr and JohnMalmberg June 13, 2025 11:43

tanabarr approved these changes Jun 13, 2025

View reviewed changes

		// (C) Copyright 2019-2024 Intel Corporation.
		// (C) Copyright 2025 Hewlett Packard Enterprise Development LP

SRE-3104 ci: Use DAOS specific HTTPS_PROXY variable #16496

Are you sure you want to change the base?

SRE-3104 ci: Use DAOS specific HTTPS_PROXY variable #16496

Uh oh!

Conversation

grom72 commented Jun 10, 2025

Steps for the author:

After all prior steps are complete:

Uh oh!

github-actions bot commented Jun 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

daosbuild3 commented Jun 11, 2025

Uh oh!

daosbuild3 commented Jun 11, 2025

Uh oh!

daosbuild3 commented Jun 11, 2025

Uh oh!

daosbuild3 commented Jun 11, 2025

Uh oh!

daosbuild3 commented Jun 11, 2025

Uh oh!

daosbuild3 commented Jun 11, 2025

Uh oh!

daosbuild3 commented Jun 11, 2025

Uh oh!

daosbuild3 commented Jun 11, 2025

Uh oh!

daosbuild3 commented Jun 11, 2025

Uh oh!

daosbuild3 commented Jun 11, 2025

Uh oh!

daosbuild3 commented Jun 11, 2025

Uh oh!

daosbuild3 commented Jun 11, 2025

Uh oh!

daosbuild3 commented Jun 11, 2025

Uh oh!

daosbuild3 commented Jun 11, 2025

Uh oh!

daosbuild3 commented Jun 11, 2025

Uh oh!

JohnMalmberg left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tanabarr Jun 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

daosbuild3 commented Jun 11, 2025

Uh oh!

kjacque left a comment

Choose a reason for hiding this comment

Uh oh!

daosbuild3 commented Jun 12, 2025

Uh oh!

daosbuild3 commented Jun 12, 2025

Uh oh!

daosbuild3 commented Jun 13, 2025

Uh oh!

daosbuild3 commented Jun 14, 2025

Uh oh!

github-actions bot commented Jun 10, 2025 •

edited

Loading

tanabarr Jun 11, 2025 •

edited

Loading