Skip to content

Ensure Market1501 dataset dir exists #1227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 3, 2020
Merged

Ensure Market1501 dataset dir exists #1227

merged 1 commit into from
May 3, 2020

Conversation

HieronymusLex
Copy link
Contributor

@HieronymusLex HieronymusLex commented Mar 23, 2020 •
edited
Loading

  • Ensures the market 1501 download dir exists
  • Add script args to make script behaviour clearer
  • PEP8 styling

@mli
Copy link
Member

mli commented Mar 23, 2020

Job PR-1227-1 is done.
Docs are uploaded to http://gluon-vision-staging.s3-website-us-west-2.amazonaws.com/PR-1227/1/index.html
Code coverage of this PR: pr.svg vs. Master: master.svg

zhreshold
zhreshold approved these changes Apr 3, 2020
View reviewed changes
Copy link
Member

@zhreshold zhreshold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the patch, looks good to me

@mli
Copy link
Member

mli commented Apr 10, 2020

Job PR-1227-2 is done.
Docs are uploaded to http://gluon-vision-staging.s3-website-us-west-2.amazonaws.com/PR-1227/2/index.html
Code coverage of this PR: pr.svg vs. Master: master.svg

@bryanyzhu bryanyzhu merged commit 2716ec9 into dmlc:master May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhreshold zhreshold zhreshold approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HieronymusLex @mli @zhreshold @bryanyzhu