Skip to content

feat: use environment variable in docker-compose.yml for configurability #1215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tuladhar
Copy link

@tuladhar tuladhar commented May 28, 2025

This PR updates the docker-compose.yml file to replace hard-coded configuration values with environment variable substitutions. Instead of directly editing the docker-compose.yml file to change configurations during the installation, users can now supply values via a .env file.

Important

If this gets merged, we need to merge this PR in the documentation: docmost/docs#14

@CLAassistant
Copy link

CLAassistant commented May 28, 2025

CLA assistant check
All committers have signed the CLA.

@tuladhar tuladhar changed the title Use environment variable in docker-compose.yml for configurability feat: use environment variable in docker-compose.yml for configurability May 29, 2025
@ctmbl
Copy link

ctmbl commented Jun 17, 2025

In my (totally personal and humble) opinion, this kind of change is not desirable in general.

When you want to deploy to test a new app it's pretty cool if the provided docker-compose works out-of-the-box, because you're looking for a fast try-and-test configuration.

Yes the provided docker-compose is not configurable, and yes it is really not secured and shouldn't be used as-is in production. But replacing default value by some environment variable stored in a .env is a Docker feature and workflow, and thus not really the scope of Docmost documentation (once again in my opinion).
Maybe the docs should instead precise that this is not a production-ready compose file and point to the appropriate documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants