[android] Update gradle.properties #30543
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds a suppression flag to gradle.properties to enable building with Android SDK 34 without warnings from the Android Gradle plugin.
- Introduces
android.suppressUnsupportedCompileSdk=34to silence unsupported compile SDK warnings. - Ensures compatibility when using SDK 34 in Android projects.
|
|
||
| # Android Gradle plugin requires additional configuration for SDK 34 | ||
| android.suppressUnsupportedCompileSdk=34 |
There was a problem hiding this comment.
Can we update this instead of suppressing the warning?
This could just be 35 in main? and 36 on net10.0?
|
Build not happy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This pull request introduces updates to environment variable handling for .NET and upgrades the Android SDK versions in the build configuration. These changes ensure compatibility with newer versions and address specific platform requirements.
Updates to .NET environment variable handling:
eng/cake/dotnet.cake: Added a conditional setup for theDOTNET_HOST_PATHenvironment variable on Windows systems to work around a specific issue with dev18.Android SDK version upgrades:
src/Core/AndroidNative/maui/build.gradle: UpdatedcompileSdkandtargetSdkversions from 34 to 35 to align with the latest Android SDK standards.