fix null checks in KeyboardTypeConverter #30562
Open
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @@SimonCropp! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
There was a problem hiding this comment.
Pull Request Overview
This PR cleans up the null-check logic in the KeyboardTypeConverter, removing redundant checks and simplifying how reflection calls retrieve static fields and properties.
- Removed unnecessary null checks around
parts, sinceSplitnever returns null. - Dropped null-conditional operators on
GetFields()andGetProperties()and simplified the conditional checks. - Streamlined matching logic for both static fields and properties.
Comments suppressed due to low confidence (2)
src/Core/src/Converters/KeyboardTypeConverter.cs:26
- Add unit tests for both conversion formats (with and without the "Keyboard" prefix) to ensure these branches behave as expected after the cleanup.
if (parts.Length == 1 || (parts.Length == 2 && parts[0] == "Keyboard"))
src/Core/src/Converters/KeyboardTypeConverter.cs:30
- [nitpick] The variable name
keyboardcan be confused with theKeyboardtype; consider renaming it tokeyboardNameor similar for clarity.
string keyboard = parts[parts.Length - 1];
|
What does this fix? |
|
@rmarinho it remove redundant and misleading code |
|
/rebase |
github-actions
bot
force-pushed
the
fix-null-checks-in-KeyboardTypeConverter
branch
from
2facf5b to
c22c5f0
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.