Skip to content

[net10.0] Revert trimming workaround net10 #30570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: net10.0
Choose a base branch
from
Open

[net10.0] Revert trimming workaround net10 #30570

wants to merge 3 commits into from
+20 −12

Conversation

rmarinho
Copy link
Member

Description of Change

When moving to net10.0 we disable some trimming warnings for iOS, will try enable them again.

@rmarinho rmarinho requested review from rolfbjarne and Copilot July 11, 2025 11:04
@rmarinho rmarinho requested a review from a team as a code owner July 11, 2025 11:04
Copilot
Copilot AI reviewed Jul 11, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Reverts the temporary trimming analyzer workaround in the netstandard2.0 build targets so that trimming warnings are once again enabled.

  • Removed the conditional <PropertyGroup> that disabled the trim analyzer and suppressed related warnings.
  • Restored default trimming analyzer behavior for non-AOT, non-full-trim, non-explicit-suppression scenarios.
Comments suppressed due to low confidence (1)

@rmarinho rmarinho added this to the .NET 10.0-preview7 milestone Jul 11, 2025
@rmarinho rmarinho added the perf/app-size Application Size / Trimming (sub: perf) label Jul 11, 2025
rolfbjarne
rolfbjarne previously approved these changes Jul 11, 2025
View reviewed changes
@rmarinho
Copy link
Member Author

@rolfbjarne seems still lots of warnings on the sample apps , device tests etc.. is there anything else other than ignore the warnings ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@rolfbjarne rolfbjarne rolfbjarne left review comments

@jfversluis jfversluis Awaiting requested review from jfversluis jfversluis is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

@jsuarezruiz jsuarezruiz Awaiting requested review from jsuarezruiz jsuarezruiz is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
perf/app-size Application Size / Trimming (sub: perf)
Projects
None yet
Milestone
.NET 10.0-preview7
Development

Successfully merging this pull request may close these issues.
2 participants
@rmarinho @rolfbjarne