[net10.0, Testing] Disabling the Graphics IImage related test cases on Android platform #30577
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @@HarishKumarSF4517! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
dotnet-policy-service
bot
added
the
partner/syncfusion
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
Pull Request Overview
This PR adds the TEST_FAILS_ON_ANDROID symbol to existing preprocessor directives on three test files, ensuring those tests are also disabled on Android and linking to the relevant GitHub issue (#30576).
- Include
TEST_FAILS_ON_ANDROIDin preprocessor conditions for three Shared.Tests files - Append Android-specific issue references (#30576) in comments for traceability
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue30006.cs | Added Android to #if directive and linked issue #30576 |
| src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue16767_Resize.cs | Added Android to #if directive and linked issue #30576 |
| src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue16767_Downsize.cs | Added Android to #if directive and linked issue #30576 |
Comments suppressed due to low confidence (2)
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue16767_Resize.cs:1
- [nitpick] Use
macOSinstead ofmacwhen referring to the platform for clarity and consistency with platform naming conventions.
#if TEST_FAILS_ON_CATALYST && TEST_FAILS_ON_IOS && TEST_FAILS_ON_ANDROID //NullReferenceException throws on iOS and mac Issue link - https://github.com/dotnet/maui/issues/19642 and for Android : https://github.com/dotnet/maui/issues/30576
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue16767_Downsize.cs:1
- [nitpick] Use
macOSinstead ofmacto refer to the platform consistently with other references.
#if TEST_FAILS_ON_CATALYST && TEST_FAILS_ON_IOS && TEST_FAILS_ON_ANDROID //NullReferenceException throws on iOS and mac Issue link - https://github.com/dotnet/maui/issues/19642 and For Android: https://github.com/dotnet/maui/issues/30576
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue30006.cs
Outdated
Show resolved
Hide resolved
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue16767_Resize.cs
Outdated
Show resolved
Hide resolved
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue16767_Downsize.cs
Outdated
Show resolved
Hide resolved
…006.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…767_Resize.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…767_Downsize.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates preprocessor directives in several test files to reflect that certain tests also fail on Android, in addition to the previously noted platforms. The updates include references to the relevant GitHub issues for better traceability.
Updates to preprocessor directives:
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue16767_Downsize.cs: Modified the#ifdirective to includeTEST_FAILS_ON_ANDROIDand added a reference to GitHub issue [net10.0, Testing] Re-enable the Graphics IImage related test cases on Android platform #30576 for Android-specific failures.src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue16767_Resize.cs: Updated the#ifdirective to includeTEST_FAILS_ON_ANDROIDand appended the corresponding GitHub issue reference ([net10.0, Testing] Re-enable the Graphics IImage related test cases on Android platform #30576) for Android failures.src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue30006.cs: Adjusted the#ifdirective to includeTEST_FAILS_ON_ANDROIDand added a reference to GitHub issue [net10.0, Testing] Re-enable the Graphics IImage related test cases on Android platform #30576 for Android-specific issues.