Remove MS.Extensions.Hosting from Maui #4505

eerhardt · 2022-02-04T00:40:57Z

Remove MS.Extensions.Hosting as a dependency. Users can configure DI servcies, Configuration, and Logging without needing the indirection by going through Hosting to build the ServiceProvider.
Add a new ConfigureContainer method to MauiApplicationBuilder so the DI implementation can be replaced.
Remove Logging Providers by default. Libraries can still get ILogger services, as normal. Apps can add the logging providers they care about.

- Remove MS.Extensions.Hosting as a dependency. Users can configure DI servcies, Configuration, and Logging without needing the indirection by going through Hosting to build the ServiceProvider. - Remove Logging Providers by default. Libraries can still get ILogger services, as normal. Apps can add the logging providers they care about. Fix dotnet#4393 Fix dotnet#4394

jonathanpeppers · 2022-02-04T03:07:53Z

/azp run

azure-pipelines · 2022-02-04T03:08:13Z

Azure Pipelines successfully started running 2 pipeline(s).

PureWeen

Looks good.

While poking around I noticed that our two CreateBuilder methods seem kind of redundant

maui/src/Core/src/Hosting/MauiApp.cs

Lines 36 to 43 in b1442f0

    
           public static MauiAppBuilder CreateBuilder() => new(); 
        
           /// <summary> 
        
           /// Initializes a new instance of the <see cref="MauiAppBuilder"/> class with optional defaults. 
        
           /// </summary> 
        
           /// <param name="useDefaults">Whether to create the <see cref="MauiAppBuilder"/> with common defaults.</param> 
        
           /// <returns>The <see cref="MauiAppBuilder"/>.</returns> 
        
           public static MauiAppBuilder CreateBuilder(bool useDefaults = true) => new(useDefaults);

Feels like we should just delete the first one since the second one takes an optional parameter. Not sure if there's an advantage to having both.

I realize you didn't touch those but maybe while we're here :-)

eerhardt · 2022-02-04T17:42:13Z

While poking around I noticed that our two CreateBuilder methods seem kind of redundant

On it.

src/Core/src/Hosting/MauiAppBuilder.cs

jsuarezruiz · 2022-02-04T17:50:41Z

Do we have metrics about how it impacts in the startup time?

pictos · 2022-02-04T17:51:43Z

@jsuarezruiz you can find the numbers here

src/Core/src/Hosting/MauiApp.cs

- remove redundant and unusable methods on MauiApp

eerhardt · 2022-02-05T13:21:37Z

/azp run

azure-pipelines · 2022-02-05T13:21:57Z

Azure Pipelines successfully started running 2 pipeline(s).

jamesmontemagno · 2022-02-05T17:58:22Z

A few questions here:
1.) Is functionality removed at all? For example the new Constructor Injection for Shell?
2.) Does this have any impact with sharing code with Blazor? (I think you answered this)
3.) We expose any of these in the implicit usings
4.) Any impact on templates?

eerhardt · 2022-02-05T21:41:14Z

@jamesmontemagno -

1.) As far as I know, no functionality that anyone is using. The pieces that are getting removed are all related to "startup" of the app. Instead of trying to interoperate with the "Generic Host" to build the DI container, we are now doing it ourselves. And we are no longer adding logging providers by default. There shouldn't be any DI functionality removed at all - like the new Constructor Injection for Shell.

2.) It doesn't impact control / component sharing with Blazor at all. The only impact it could have is if someone has extension methods that only take an IHostBuilder, since we will no longer have an IHostBuilder. In those cases, the same extension methods couldn't be used with Blazor WASM, since they also don't have an IHostBuilder either.

3.) I don't think so. I searched for "Extensions.Hosting" in the whole repo, and only this Sample.Server.WebAuthenticator is left after these changes.

4.) The one potential impact on the templates we could consider is conditionally adding a Debug log provider when the app is built for Debug. Today we are shipping the "Debug" log provider even in a Release built app. But that log provider doesn't do anything unless a debugger is attached.

jamesmontemagno · 2022-02-06T02:25:45Z

@eerhardt LOVELY! Thank you so much for the detailed response, detailed PR, detailed issue! 👏👏👏👏👏

* Remove MS.Extensions.Hosting from Maui - Remove MS.Extensions.Hosting as a dependency. Users can configure DI servcies, Configuration, and Logging without needing the indirection by going through Hosting to build the ServiceProvider. - Remove Logging Providers by default. Libraries can still get ILogger services, as normal. Apps can add the logging providers they care about. Fix dotnet#4393 Fix dotnet#4394 * PR feedback - remove redundant and unusable methods on MauiApp Co-authored-by: redth <jondick@gmail.com>

* Remove MS.Extensions.Hosting from Maui - Remove MS.Extensions.Hosting as a dependency. Users can configure DI servcies, Configuration, and Logging without needing the indirection by going through Hosting to build the ServiceProvider. - Remove Logging Providers by default. Libraries can still get ILogger services, as normal. Apps can add the logging providers they care about. Fix #4393 Fix #4394 * PR feedback - remove redundant and unusable methods on MauiApp Co-authored-by: redth <jondick@gmail.com> Co-authored-by: redth <jondick@gmail.com>

Syed-RI · 2022-07-15T15:52:48Z

So how does one go about adding logging now? i.e. Microsoft.Extensions.Logging.Debug or serilog to use via DI and MAUI?

Eilon · 2022-07-15T16:30:08Z

@Syed-RI the upcoming update to .NET MAUI will have this by default: https://github.com/dotnet/maui/pull/8180/files

But for now, add a NuGet reference to Microsoft.Extensions.Logging.Debug, and then in MauiProgram.cs add code like this:

using Microsoft.Extensions.Logging;

...

#if DEBUG
		builder.Logging.AddDebug();
#endif

Syed-RI · 2022-07-15T16:34:09Z

That doesn't output anything I'm afraid (ILogger.LogDebug). Do you want me to create and attach a repro?

Syed-RI · 2022-07-15T16:38:42Z

However, ILogger.LogInformation does provide output on the console. Seems the log level is set somewhere but I dont know where and cant find any documentation on it either. Any pointers?

Eilon · 2022-07-15T16:49:13Z

@Syed-RI if something isn't working, please log a new issue so that we can investigate. It sounds like in your case some messages are indeed being filtered if some log levels are showing up and some aren't. Lots more info here to get you started: https://docs.microsoft.com/en-us/dotnet/core/extensions/logging?tabs=command-line (though note that some features like setting filters in appsettings.json don't work by default in .NET MAUI).

Syed-RI · 2022-07-18T16:50:01Z

@Eilon per your suggestion #8818

Redth requested review from mattleibow and PureWeen February 4, 2022 14:52

PureWeen requested a review from rmarinho February 4, 2022 16:50

PureWeen approved these changes Feb 4, 2022

View reviewed changes

rmarinho approved these changes Feb 4, 2022

View reviewed changes

Eilon added the area-core-hosting Extensions / Hosting / AppBuilder / Startup label Feb 4, 2022

davidfowl reviewed Feb 4, 2022

View reviewed changes

src/Core/src/Hosting/MauiAppBuilder.cs Show resolved Hide resolved

eerhardt mentioned this pull request Feb 4, 2022

Consider exposing IServiceProviderFactory implementation so Grace can be used with Blazor WASM and MAUI ipjohnson/Grace.DependencyInjection.Extensions#32

Closed

eerhardt commented Feb 4, 2022

View reviewed changes

src/Core/src/Hosting/MauiApp.cs Outdated Show resolved Hide resolved

PR feedback

3676393

- remove redundant and unusable methods on MauiApp

Merge branch 'main' into pr/4505

5a681e7

Redth merged commit d27a522 into dotnet:main Feb 6, 2022

eerhardt mentioned this pull request Feb 7, 2022

Remove MS.Extensions.Hosting from Maui (#4505) #4545

Merged

eerhardt deleted the RemoveHosting branch February 7, 2022 16:26

Eilon mentioned this pull request Feb 10, 2022

Consider default Host configuration for MauiAppBuilder (incl. perf) #2270

Open

Syed-RI mentioned this pull request Jul 18, 2022

ILogger.LogDebug does not output anything #8818

Closed

Arkatufus mentioned this pull request May 4, 2023

MAUI support for Akka.Hosting (disable IHostedService) akkadotnet/Akka.Hosting#289

Closed

github-actions bot locked and limited conversation to collaborators Dec 21, 2023

samhouts added the fixed-in-6.0.200-preview.14.2 Look for this fix in 6.0.200-preview.14.2! label Aug 2, 2024

	public static MauiAppBuilder CreateBuilder() => new();

	/// <summary>
	/// Initializes a new instance of the <see cref="MauiAppBuilder"/> class with optional defaults.
	/// </summary>
	/// <param name="useDefaults">Whether to create the <see cref="MauiAppBuilder"/> with common defaults.</param>
	/// <returns>The <see cref="MauiAppBuilder"/>.</returns>
	public static MauiAppBuilder CreateBuilder(bool useDefaults = true) => new(useDefaults);

Remove MS.Extensions.Hosting from Maui #4505

Remove MS.Extensions.Hosting from Maui #4505

Uh oh!

Conversation

eerhardt commented Feb 4, 2022

Uh oh!

jonathanpeppers commented Feb 4, 2022

Uh oh!

azure-pipelines bot commented Feb 4, 2022

Uh oh!

PureWeen left a comment

Choose a reason for hiding this comment

Uh oh!

eerhardt commented Feb 4, 2022

Uh oh!

Uh oh!

jsuarezruiz commented Feb 4, 2022

Uh oh!

pictos commented Feb 4, 2022

Uh oh!

Uh oh!

eerhardt commented Feb 5, 2022

Uh oh!

azure-pipelines bot commented Feb 5, 2022

Uh oh!

jamesmontemagno commented Feb 5, 2022

Uh oh!

eerhardt commented Feb 5, 2022

Uh oh!

jamesmontemagno commented Feb 6, 2022

Uh oh!

Syed-RI commented Jul 15, 2022

Uh oh!

Eilon commented Jul 15, 2022

Uh oh!

Syed-RI commented Jul 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Syed-RI commented Jul 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Eilon commented Jul 15, 2022

Uh oh!

Syed-RI commented Jul 18, 2022

Uh oh!

Uh oh!

Syed-RI commented Jul 15, 2022 •

edited

Loading

Syed-RI commented Jul 15, 2022 •

edited

Loading