spec!: add support for several topic matcher types, including URL Pattern #959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soyuka
reviewed
Oct 16, 2024
Co-authored-by: Antoine Bluchet <soyuka@users.noreply.github.com>
Co-authored-by: Antoine Bluchet <soyuka@users.noreply.github.com>
Co-authored-by: Antoine Bluchet <soyuka@users.noreply.github.com>
This was referenced Oct 21, 2024
soyuka
approved these changes
Oct 25, 2024
soyuka
reviewed
Oct 25, 2024
soyuka
reviewed
Oct 25, 2024
Co-authored-by: Antoine Bluchet <soyuka@users.noreply.github.com>
soyuka
reviewed
Oct 25, 2024
Co-authored-by: Antoine Bluchet <soyuka@users.noreply.github.com>
soyuka
reviewed
Oct 25, 2024
Co-authored-by: Antoine Bluchet <soyuka@users.noreply.github.com>
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This is still ongoing work |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #831 with a more flexible and future-proof approach.
Summary
topicquery parameter becomesmatchand now only supports exact matchingmatch{MatchType}are introducedmatchRegexp,matchURLPattern,matchCEL, andmatchURITemplateare definedThe official hub will be able to support both the current and new protocols simultaneously (no hard BC break).
TODO: