[ZEN-557] do not set zenohid in the config if it is unset, do it in the runtime builder instead #1978
+73
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR missing one of the required labels: {'breaking-change', 'dependencies', 'enhancement', 'documentation', 'new feature', 'bug', 'internal'} |
|
PR missing one of the required labels: {'bug', 'new feature', 'internal', 'documentation', 'dependencies', 'breaking-change', 'enhancement'} |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1978 +/- ##
==========================================
- Coverage 70.92% 70.84% -0.09%
==========================================
Files 364 364
Lines 61509 61520 +11
==========================================
- Hits 43628 43584 -44
- Misses 17881 17936 +55 ☔ View full report in Codecov by Sentry. |
DenisBiryukov91
requested review from
oteffahi,
OlivierHecart,
yellowhatter and
fuzzypixelz
DenisBiryukov91
changed the title
milyin
approved these changes
Jun 12, 2025
JEnoch
added a commit
to eclipse-zenoh/zenoh-plugin-ros2dds
that referenced
this pull request
Jun 16, 2025
JEnoch
added a commit
to eclipse-zenoh/zenoh-plugin-mqtt
that referenced
this pull request
Jun 16, 2025
JEnoch
added a commit
to eclipse-zenoh/zenoh-plugin-dds
that referenced
this pull request
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
do not set zenohid in the config if it is unset, do it in the runtime builder instead;
resolves #998
supersedes #1977