test: deflake clipboard read/write specs #47752
Merged
+21
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
added
semver/none
target/36-x-y
dsanders11
approved these changes
Jul 16, 2025
There was a problem hiding this comment.
LGTM. It might be more ironclad if we just always called focus since checking the state first does allow for a bit of a race condition, depending on what is causing the window to not be already focused. But there's still a race after focusing it and the rest of the test so on the whole it's probably minimal how much of a difference that would make.
|
No Release Notes |
This was referenced Jul 16, 2025
|
I have automatically backported this PR to "36-x-y", please check out #47786 |
|
I have automatically backported this PR to "38-x-y", please check out #47787 |
|
I have automatically backported this PR to "37-x-y", please check out #47788 |
trop
bot
added
in-flight/37-x-y
merged/38-x-y
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Deflake the following failure:
https://github.com/electron/electron/actions/runs/16273281729/job/45949205666?pr=47744
Checklist
npm testpassesRelease Notes
Notes: none