Support returning Not Modified responses in FileResponse #2955
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulo-raca
force-pushed
the
FileResponseNotModified
branch
from
d6d6c2b to
63b8950
Compare
paulo-raca
force-pushed
the
FileResponseNotModified
branch
from
63b8950 to
8b9e306
Compare
|
@abersheeran I know you've played a lot with this. Does this PR make sense? |
abersheeran
requested changes
Jun 27, 2025
| "Not Modified" response could be returned instead. | ||
| """ | ||
| if http_if_none_match is not None: | ||
| match = [tag.strip(" W/") for tag in http_if_none_match.split(",")] |
There was a problem hiding this comment.
There are some issues here; the strong and weak semantics of etag should not be handled this way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Looking at the souce for StaticFiles, it verifies the timestamp/etag and returns
HTTP 304 - Not Modifiedwhen appropriate.IMHO it would be simpler / more reusable if this was part of FileResponse.
(I brought this up a few hours ago in #2954, and decided to give it a try)
I haven't written new tests: There already is a ton of them and there is good coverage.
Checklist