-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Name length too long error fix #21668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Name length too long error fix #21668
Conversation
Thank you for opening this PR! We appreciate you! For all pull requests coming from third-party forks we will need to A Forem Team member will review this contribution and get back to |
CLA Assistant Lite bot: I have read the CLA Document and I hereby sign the CLA 1 out of 2 committers have signed the CLA. |
1613055
to
f4e0357
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't able to reproduce this. It looks like the name
and username
fields are hardcoded with a 30-character limit, so it's not possible to type more and trigger the error.
I even installed and tested on Zen Browser, as noted in the issue, and the 30-character limit worked correctly there too.
My guess is this was either a one-off glitch or has since been fixed. I'd recommend closing this PR and the associated issue #21620
@kkrypt0nn Thanks for pushing back on this. Although I was unable to duplicate the error under normal user behaviour, as the However, in testing this change, I found that it introduces a design issue. I tested with various lengths, and although it's not a common case, it is possible for a long name without spaces to break the layout in the user dropdown menu. Most other areas I checked seem to handle this with truncation or line breaks already, but this one needs a fix. A possible fix could be to target the #user-profile-link-placeholder .fw-medium {
white-space: nowrap;
overflow: hidden;
text-overflow: ellipsis;
} @benhalpern, what do you think? |
What type of PR is this? (check all applicable)
Description
The maximum length for a name according to the backend is 100 characters. Though when editing the profile, the maximum length of the input field is 30.
Related Tickets & Documents
#21620
QA Instructions, Screenshots, Recordings
Please replace this line with instructions on how to test your changes, a note
on the devices and browsers this has been tested on, as well as any relevant
images for UI changes.
UI accessibility checklist
If your PR includes UI changes, please utilize this checklist:
Critical
andSerious
issues?For more info, check out the
Forem Accessibility Docs.
Added/updated tests?
We encourage you to keep the code coverage percentage at 80% and above.
have not been included
[optional] Are there any post deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?