Fix: Preserve HTML in runkit source code blocks #22099
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change modifies the RunkitTag class to use inner_html instead of text when parsing the content, which preserves HTML tags in the runkit source. Fixes forem#1228
|
Thank you for opening this PR! We appreciate you! For all pull requests coming from third-party forks we will need to A Forem Team member will review this contribution and get back to |
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
benhalpern
requested changes
Jul 9, 2025
There was a problem hiding this comment.
Hmmm actually looks like this failing test needs to be looked into:
1) RunkitTag#render preserves HTML tags in content
Failure/Error: expect(rendered).not_to include('🍔Hello, World!🍔') # This would indicate HTML was stripped
expected "<div class=\"runkit-element\">\n <code style=\"display: none\">\n const myVar = 9001\n\n </code...ot;<marquee>🍔Hello, World!🍔</marquee>"\n }\n};\n</p>\n </code>\n</div>\n" not to include "🍔Hello, World!🍔"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change modifies the RunkitTag class to use inner_html instead of text when parsing the content, which preserves HTML tags in the runkit source.
Fixes #1228
What type of PR is this? (check all applicable)
Description
Related Tickets & Documents
QA Instructions, Screenshots, Recordings
Please replace this line with instructions on how to test your changes, a note
on the devices and browsers this has been tested on, as well as any relevant
images for UI changes.
UI accessibility checklist
If your PR includes UI changes, please utilize this checklist:
CriticalandSeriousissues?For more info, check out the
Forem Accessibility Docs.
Added/updated tests?
We encourage you to keep the code coverage percentage at 80% and above.
have not been included
I have read the CLA Document and I hereby sign the CLA