Add better color on selected text in dark and light mode #22100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change modifies the RunkitTag class to use inner_html instead of text when parsing the content, which preserves HTML tags in the runkit source. Fixes forem#1228
|
Thank you for opening this PR! We appreciate you! For all pull requests coming from third-party forks we will need to A Forem Team member will review this contribution and get back to |
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description This PR addresses issue #2799 by adding better color for selected text in dark mode.
The current selection color in dark mode is not very visible, making it difficult to see what text is selected.
Changes - Added ::selection and ::-moz-selection pseudo-elements to dark.css with improved colors for dark mode\n- Added the same styling to the default light theme in _colors.css for consistency
Screenshots:
Before: Text selection in dark mode was difficult to see
After: Text selection now uses the accent brand color with white text for better visibility
Solved with Zencoder