Skip to content

Fix static quality gates image suffix logic #37802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 10, 2025
Merged

Fix static quality gates image suffix logic #37802

merged 3 commits into from
Jun 10, 2025

Conversation

pgimalac
Copy link
Member

@pgimalac pgimalac commented Jun 10, 2025 •
edited
Loading

What does this PR do?

Fix the logic to compute static quality gates image suffix.
Parenthesis are needed to have the correct operation priority.

Also updates the static quality gates limits, increasing each by the diff with the previous value (so that the "margin" stays the same).

Motivation

Have correct numbers for jmx images.

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@pgimalac pgimalac requested a review from a team as a code owner June 10, 2025 08:42
@pgimalac pgimalac added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation team/agent-delivery labels Jun 10, 2025
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Jun 10, 2025
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jun 10, 2025 •
edited
Loading

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 96e38c9

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
✅ agent_deb_amd64 $${0}$$ $${696.06}$$ < $${752.99}$$ $${+0.05}$$ $${176.03}$$ < $${187.44}$$
✅ agent_deb_amd64_fips $${0}$$ $${694.29}$$ < $${751.36}$$ $${+0.05}$$ $${175.53}$$ < $${187.06}$$
✅ agent_heroku_amd64 $${0}$$ $${358.56}$$ < $${369.68}$$ $${-0}$$ $${96.5}$$ < $${99.55}$$
✅ agent_msi $${0}$$ $${959.87}$$ < $${987.01}$$ $${+0.03}$$ $${146.46}$$ < $${150.72}$$
✅ agent_rpm_amd64 $${0}$$ $${696.05}$$ < $${752.98}$$ $${+0.01}$$ $${177.55}$$ < $${190.03}$$
✅ agent_rpm_amd64_fips $${0}$$ $${694.28}$$ < $${751.35}$$ $${-0}$$ $${177.43}$$ < $${189.81}$$
✅ agent_rpm_arm64 $${0}$$ $${686.0}$$ < $${739.42}$$ $${-0.01}$$ $${161.0}$$ < $${171.23}$$
✅ agent_rpm_arm64_fips $${0}$$ $${684.35}$$ < $${737.91}$$ $${-0}$$ $${160.07}$$ < $${170.22}$$
✅ agent_suse_amd64 $${0}$$ $${696.05}$$ < $${752.98}$$ $${+0.01}$$ $${177.55}$$ < $${190.03}$$
✅ agent_suse_amd64_fips $${0}$$ $${694.28}$$ < $${751.35}$$ $${-0}$$ $${177.43}$$ < $${189.81}$$
✅ agent_suse_arm64 $${0}$$ $${686.0}$$ < $${739.42}$$ $${-0.01}$$ $${161.0}$$ < $${171.23}$$
✅ agent_suse_arm64_fips $${0}$$ $${684.35}$$ < $${737.91}$$ $${-0}$$ $${160.07}$$ < $${170.22}$$
✅ docker_agent_amd64 $${+0}$$ $${779.85}$$ < $${849.39}$$ $${-0}$$ $${268.59}$$ < $${288.34}$$
✅ docker_agent_arm64 $${+0}$$ $${793.26}$$ < $${858.97}$$ $${+0}$$ $${255.98}$$ < $${274.36}$$
✅ docker_agent_jmx_amd64 $${+191.19}$$ $${971.04}$$ < $${1040.59}$$ $${+69.0}$$ $${337.58}$$ < $${357.3}$$
✅ docker_agent_jmx_arm64 $${+179.79}$$ $${973.05}$$ < $${1038.77}$$ $${+64.94}$$ $${320.92}$$ < $${339.32}$$
✅ docker_agent_windows1809 $${+708.12}$$ $${1487.97}$$ < $${1557.19}$$ $${+219.71}$$ $${488.3}$$ < $${507.33}$$
✅ docker_agent_windows1809_core $${+5438.07}$$ $${6217.91}$$ < $${6287.46}$$ $${+1779.41}$$ $${2048.0}$$ < $${2067.76}$$
✅ docker_agent_windows1809_core_jmx $${+5559.65}$$ $${6339.5}$$ < $${6409.04}$$ $${+1779.41}$$ $${2048.0}$$ < $${2067.76}$$
✅ docker_agent_windows1809_jmx $${+829.75}$$ $${1609.6}$$ < $${1679.14}$$ $${+261.95}$$ $${530.54}$$ < $${550.27}$$
✅ docker_agent_windows2022 $${+727.23}$$ $${1507.08}$$ < $${1576.85}$$ $${+232.42}$$ $${501.01}$$ < $${520.76}$$
✅ docker_agent_windows2022_core $${+5411.2}$$ $${6191.05}$$ < $${6260.53}$$ $${+1779.41}$$ $${2048.0}$$ < $${2067.76}$$
✅ docker_agent_windows2022_core_jmx $${+5532.96}$$ $${6312.81}$$ < $${6382.17}$$ $${+1779.41}$$ $${2048.0}$$ < $${2067.76}$$
✅ docker_agent_windows2022_jmx $${+849.03}$$ $${1628.88}$$ < $${1698.2}$$ $${+274.69}$$ $${543.27}$$ < $${562.99}$$
✅ docker_cluster_agent_amd64 $${-0}$$ $${259.2}$$ < $${259.73}$$ $${-0}$$ $${102.88}$$ < $${103.68}$$
✅ docker_cluster_agent_arm64 $${-0}$$ $${273.58}$$ < $${274.24}$$ $${-0}$$ $${97.61}$$ < $${98.45}$$
✅ docker_cws_instrumentation_amd64 $${-0}$$ $${7.08}$$ < $${7.12}$$ $${-0}$$ $${2.95}$$ < $${3.29}$$
✅ docker_cws_instrumentation_arm64 $${0}$$ $${6.69}$$ < $${6.92}$$ $${+0}$$ $${2.7}$$ < $${3.07}$$
✅ docker_dogstatsd_amd64 $${+0}$$ $${38.93}$$ < $${39.57}$$ $${+0}$$ $${14.95}$$ < $${15.76}$$
✅ docker_dogstatsd_arm64 $${0}$$ $${37.52}$$ < $${38.2}$$ $${-0}$$ $${13.96}$$ < $${14.83}$$
✅ dogstatsd_deb_amd64 $${0}$$ $${30.61}$$ < $${31.52}$$ $${+0}$$ $${8.04}$$ < $${8.97}$$
✅ dogstatsd_deb_arm64 $${0}$$ $${29.16}$$ < $${30.08}$$ $${+0}$$ $${6.98}$$ < $${7.92}$$
✅ dogstatsd_rpm_amd64 $${0}$$ $${30.61}$$ < $${31.52}$$ $${-0}$$ $${8.04}$$ < $${8.98}$$
✅ dogstatsd_suse_amd64 $${0}$$ $${30.61}$$ < $${31.52}$$ $${-0}$$ $${8.04}$$ < $${8.98}$$
✅ iot_agent_deb_amd64 $${0}$$ $${50.49}$$ < $${60.17}$$ $${-0}$$ $${12.85}$$ < $${15.82}$$
✅ iot_agent_deb_arm64 $${0}$$ $${47.94}$$ < $${56.94}$$ $${+0}$$ $${11.15}$$ < $${13.86}$$
✅ iot_agent_deb_armhf $${0}$$ $${47.52}$$ < $${56.41}$$ $${+0}$$ $${11.22}$$ < $${13.86}$$
✅ iot_agent_rpm_amd64 $${0}$$ $${50.49}$$ < $${60.18}$$ $${+0}$$ $${12.87}$$ < $${15.84}$$
✅ iot_agent_rpm_arm64 $${0}$$ $${47.94}$$ < $${56.94}$$ $${+0}$$ $${11.17}$$ < $${13.76}$$
✅ iot_agent_suse_amd64 $${0}$$ $${50.49}$$ < $${60.18}$$ $${+0}$$ $${12.87}$$ < $${15.84}$$

@Pythyu Pythyu added the backport/7.67.x Automatically create a backport PR to 7.67.x label Jun 10, 2025
@cit-pr-commenter cit-pr-commenter
Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: e25fcb30-7a7b-45df-b879-0d45378c64c4

Baseline: 96e38c9
Comparison: f31c198
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
➖ file_tree memory utilization +1.67 [+1.51, +1.83] 1 Logs
➖ docker_containers_cpu % cpu utilization +1.25 [-1.73, +4.24] 1 Logs
➖ quality_gate_idle memory utilization +0.96 [+0.89, +1.04] 1 Logs bounds checks dashboard
➖ quality_gate_logs % cpu utilization +0.72 [-2.04, +3.47] 1 Logs bounds checks dashboard
➖ docker_containers_memory memory utilization +0.35 [+0.28, +0.43] 1 Logs
➖ file_to_blackhole_0ms_latency egress throughput +0.15 [-0.45, +0.74] 1 Logs
➖ file_to_blackhole_500ms_latency egress throughput +0.11 [-0.54, +0.75] 1 Logs
➖ file_to_blackhole_1000ms_latency egress throughput +0.08 [-0.51, +0.66] 1 Logs
➖ file_to_blackhole_0ms_latency_http2 egress throughput +0.08 [-0.52, +0.67] 1 Logs
➖ file_to_blackhole_300ms_latency egress throughput +0.04 [-0.60, +0.69] 1 Logs
➖ file_to_blackhole_0ms_latency_http1 egress throughput -0.00 [-0.57, +0.57] 1 Logs
➖ tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.02, +0.02] 1 Logs
➖ uds_dogstatsd_to_api ingress throughput -0.00 [-0.28, +0.28] 1 Logs
➖ file_to_blackhole_1000ms_latency_linear_load egress throughput -0.01 [-0.25, +0.22] 1 Logs
➖ file_to_blackhole_100ms_latency egress throughput -0.02 [-0.61, +0.58] 1 Logs
➖ quality_gate_idle_all_features memory utilization -0.04 [-0.14, +0.06] 1 Logs bounds checks dashboard
➖ ddot_metrics memory utilization -0.06 [-0.18, +0.06] 1 Logs
➖ otlp_ingest_metrics memory utilization -0.19 [-0.35, -0.03] 1 Logs
➖ otlp_ingest_logs memory utilization -0.24 [-0.37, -0.12] 1 Logs
➖ ddot_logs memory utilization -0.37 [-0.51, -0.23] 1 Logs
➖ uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -0.51 [-0.56, -0.45] 1 Logs
➖ uds_dogstatsd_to_api_cpu % cpu utilization -0.82 [-1.67, +0.04] 1 Logs
➖ tcp_syslog_to_blackhole ingress throughput -1.86 [-1.92, -1.79] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
✅ docker_containers_cpu simple_check_run 10/10
✅ docker_containers_memory memory_usage 10/10
✅ docker_containers_memory simple_check_run 10/10
✅ file_to_blackhole_0ms_latency lost_bytes 10/10
✅ file_to_blackhole_0ms_latency memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http1 memory_usage 10/10
✅ file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
✅ file_to_blackhole_0ms_latency_http2 memory_usage 10/10
✅ file_to_blackhole_1000ms_latency memory_usage 10/10
✅ file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
✅ file_to_blackhole_100ms_latency lost_bytes 10/10
✅ file_to_blackhole_100ms_latency memory_usage 10/10
✅ file_to_blackhole_300ms_latency lost_bytes 10/10
✅ file_to_blackhole_300ms_latency memory_usage 10/10
✅ file_to_blackhole_500ms_latency lost_bytes 10/10
✅ file_to_blackhole_500ms_latency memory_usage 10/10
✅ quality_gate_idle intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle memory_usage 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
✅ quality_gate_logs intake_connections 10/10 bounds checks dashboard
✅ quality_gate_logs lost_bytes 10/10 bounds checks dashboard
✅ quality_gate_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@Pythyu
Copy link
Contributor

Pythyu commented Jun 10, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jun 10, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-06-10 13:50:37 UTC ℹ️ Start processing command /merge

2025-06-10 13:50:47 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 47m (p90).

2025-06-10 14:28:33 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit bea966a into main Jun 10, 2025
222 checks passed
@dd-mergequeue dd-mergequeue bot deleted the pgimalac/fix-static-quality-gates-image-suffix branch June 10, 2025 14:28
@github-actions github-actions bot added this to the 7.68.0 milestone Jun 10, 2025
@agent-platform-auto-pr
Copy link
Contributor

The backport to 7.67.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-7.67.x 7.67.x
# Navigate to the new working tree
cd .worktrees/backport-7.67.x
# Create a new branch
git switch --create backport-37802-to-7.67.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 bea966a3165e2cce505f55aada6897b293932318
# Push it to GitHub
git push --set-upstream origin backport-37802-to-7.67.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-7.67.x

Then, create a pull request where the base branch is 7.67.x and the compare/head branch is backport-37802-to-7.67.x.

Pythyu pushed a commit that referenced this pull request Jun 12, 2025
@pgimalac @Pythyu
Fix static quality gates image suffix logic (#37802)
5004f17 
(cherry picked from commit bea966a)
chouquette pushed a commit that referenced this pull request Jun 13, 2025
@Pythyu @pgimalac
Fix static quality gates image suffix logic (#37802) (#37891)
f7ece82 
Co-authored-by: Pierre Gimalac <pierre.gimalac@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pythyu Pythyu Pythyu approved these changes

Assignees
No one assigned
Labels
backport/7.67.x Automatically create a backport PR to 7.67.x changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly team/agent-delivery
Projects
None yet
Milestone
7.68.0
Development

Successfully merging this pull request may close these issues.
2 participants
@pgimalac @Pythyu