Skip to content

Add LoongArch 64-bit support #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Add LoongArch 64-bit support #340

wants to merge 1 commit into from

Conversation

Dandan336
Copy link

Hi maintainers,
Compiling the mayo failed for loong64 in the Debian Package Auto-Building environment.
The build error log is as follows,

[ 27%] Building CXX object CMakeFiles/MayoCore.dir/src/graphics/ais_text.cpp.o
/usr/bin/c++ -DOCCT_HANDLE_NOCAST -DOCC_CONVERT_SIGNALS -DQT_DISABLE_DEPRECATED_BEFORE=0x050F00 -DQT_IMPLICIT_QFILEINFO_CONSTRUCTION -I/<<PKGBUILDDIR>>/obj-loongarch64-linux-gnu/MayoCore_autogen/include -I/<<PKGBUILDDIR>>/src/3rdparty -I/<<PKGBUILDDIR>>/obj-loongarch64-linux-gnu -isystem /usr/include/opencascade -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -std=gnu++17 -MD -MT CMakeFiles/MayoCore.dir/src/graphics/ais_text.cpp.o -MF CMakeFiles/MayoCore.dir/src/graphics/ais_text.cpp.o.d -o CMakeFiles/MayoCore.dir/src/graphics/ais_text.cpp.o -c /<<PKGBUILDDIR>>/src/graphics/ais_text.cpp
In file included from /<<PKGBUILDDIR>>/src/3rdparty/fast_float/ascii_number.h:9,
                 from /<<PKGBUILDDIR>>/src/3rdparty/fast_float/parse_number.h:3,
                 from /<<PKGBUILDDIR>>/src/3rdparty/fast_float/fast_float.h:44,
                 from /<<PKGBUILDDIR>>/src/base/unit_system.cpp:9:
/<<PKGBUILDDIR>>/src/3rdparty/fast_float/float_common.h:20:2: error: #error Unknown platform (not 32-bit, not 64-bit?)
   20 | #error Unknown platform (not 32-bit, not 64-bit?)
      |  ^~~~~
/<<PKGBUILDDIR>>/src/3rdparty/fast_float/float_common.h:161:4: error: #error Not implemented
  161 |   #error Not implemented
      |    ^~~~~

The full log can be found at https://buildd.debian.org/status/fetch.php?pkg=mayo&arch=loong64&ver=0.9.0%2Bds-1&stamp=1744735590&raw=0.

Please review this patch.
I have built mayo successfully on my locally.

......
   dh_builddeb
dpkg-deb: building package 'mayo' in '../mayo_0.9.0+ds-1+loong64_loong64.deb'.
dpkg-deb: building package 'mayo-dbgsym' in '../mayo-dbgsym_0.9.0+ds-1+loong64_loong64.deb'.
 dpkg-genbuildinfo -O../mayo_0.9.0+ds-1+loong64_loong64.buildinfo
 dpkg-genchanges -O../mayo_0.9.0+ds-1+loong64_loong64.changes

Best regards,
Dandan Zhang

@HuguesDelorme
Copy link
Member

I've updated 3rdparty fast_float to v8.0.2
Author of the library added support of __loongarch64, see:

mayo/src/3rdparty/fast_float/fast_float.h

Line 236 in f8b7e1d

defined(__loongarch64))

Can you please check develop branch builds fine on this arch without your PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dandan336 @HuguesDelorme