Skip to content

Fix for issue #4581 #4585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 14, 2025
Merged

Fix for issue #4581 #4585

merged 2 commits into from
Jul 14, 2025

Conversation

AnXh3L0
Copy link
Member

@AnXh3L0 AnXh3L0 commented Jul 14, 2025

In this pull request, I have addressed the issue #4581 and implemented the following changes:

  • Registered missing locales/languages from the locale-provider.ts helper file, fixing Angular error NG0701.
  • Changed formatDate function in the custom-datepicker-i18n.ts file from the previous EEE to the EEEEE format, in order to display the short version for the week days, preventing the text overflow in several languages/locales with longer strings. This solution also prevents the need for visual/CSS changes.

@AnXh3L0 AnXh3L0 requested a review from a team as a code owner July 14, 2025 11:31
@github-project-automation github-project-automation bot moved this to Needs triaging in GLOBALEAKS Jul 14, 2025
@AnXh3L0 AnXh3L0 self-assigned this Jul 14, 2025
@AnXh3L0 AnXh3L0 moved this from Needs triaging to Needs review in GLOBALEAKS Jul 14, 2025
@AnXh3L0 AnXh3L0 added this to the 5.0.73 milestone Jul 14, 2025
Copy link

codacy-production bot commented Jul 14, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-14.36% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (672fd81) 19832 17365 87.56%
Head commit (bd0b6e2) 44870 (+25038) 32846 (+15481) 73.20% (-14.36%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#4585) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@evilaliv3 evilaliv3 changed the base branch from devel to stable July 14, 2025 12:53
@evilaliv3 evilaliv3 changed the base branch from stable to devel July 14, 2025 13:05
@evilaliv3 evilaliv3 changed the base branch from devel to stable July 14, 2025 13:08
@@ -15,7 +15,7 @@ export class CustomDatepickerI18n extends NgbDatepickerI18n {
this.translationService.currentLocale$.subscribe(locale => {
if (locale === 'crh') {
this.locale = 'tk';
} else if (locale === 'dv') {
} else if (locale === 'ba' || locale === 'dv' || locale.startsWith('ug')) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As noted there are other languages that requires specific handling like: "ba", "ug", "ug@cyrl", "ug@latin"

@evilaliv3 evilaliv3 merged commit d6f7213 into stable Jul 14, 2025
6 of 9 checks passed
@evilaliv3 evilaliv3 deleted the fix/date-picker branch July 14, 2025 19:59
@github-project-automation github-project-automation bot moved this from Needs review to Completed in GLOBALEAKS Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

2 participants