Add a method to read static roles in the database engine #1009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a method to read static roles in the database engine
briantist
added
enhancement
Codecov Report
@@ Coverage Diff @@
## main #1009 +/- ##
==========================================
+ Coverage 83.59% 83.72% +0.13%
==========================================
Files 65 65
Lines 3023 2992 -31
==========================================
- Hits 2527 2505 -22
+ Misses 496 487 -9
|
briantist
approved these changes
Jun 21, 2023
There was a problem hiding this comment.
Hi @mimato , welcome and thanks very much for this contribution! I was going to ask if you might be able to add tests for the new method... and then realized we don't have tests for this engine at all 😔 so I can't reasonably ask for that as a pre-requisite on this PR!
The code looks great though, if you're interested we have lots more we can use help with, thanks again!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the database backend does not provide a way to read static roles, only dynamic roles. This PR adds a method to read static roles as well.
Vault API doc: https://developer.hashicorp.com/vault/api-docs/secret/databases#read-static-role