Remove MFA class #1056
Merged
Remove MFA class #1056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briantist
added
auth methods
Codecov Report
@@ Coverage Diff @@
## main #1056 +/- ##
==========================================
+ Coverage 85.00% 86.13% +1.12%
==========================================
Files 65 64 -1
Lines 3135 3101 -34
==========================================
+ Hits 2665 2671 +6
+ Misses 470 430 -40
|
kaypeter87
approved these changes
Sep 20, 2023
|
Thanks again for reviewing @kaypeter87 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1026
As previously announced, the deprecated
MFAclass is being removed. All of its methods were moved to theLegacyMFAclass.The
MFAclass may resurface depending onhvac's implementation of Vault's newer "Login MFA":In addition to removing the class, this PR is cleaning up some other things:
authpropertyclient.mfapropertyutilsmodule functions, whose code paths are no longer hit because they aren't currently in use